Prepare to remove base::JSONReader::ReadDict's parsing option default [chromium/src : main]
0 views
Skip to first unread message
Daniel Cheng (Gerrit)
Sep 23, 2025, 11:36:46 AM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 23, 2025, 11:37:02 AM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 23, 2025, 11:37:24 AM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 23, 2025, 11:37:43 AM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Lei Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Sep 23, 2025, 12:12:48 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved
WDYT about first adding a second set of equivalent `enum JSONParserOptions` values with `kFoo` naming style, and then using those (well just one of those) in these CLs? Then we won't need to make a second pass to switch to `kFoo` style enum values in the future.
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Sep 23, 2025, 12:13:10 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Sep 23, 2025, 12:15:29 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Sep 23, 2025, 12:15:47 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Attention needed from Daniel Cheng
Lei Zhang voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Sep 23, 2025, 1:46:25 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 2:44:54 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Prepare to remove base::JSONReader::ReadDict's parsing option default
Callers should be explicit if they need to opt into non-compliant JSON
parsing that allows Chromium-specific extensions, e.g. comments. This
fixes instances included in a typical Linux developer build.
Bug: 446188265
Change-Id: Ibe3ebc195a5e8db8c54180be24e29ac42ceea1a2
Owners-Override: Lei Zhang <the...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519488}
Files:
- M cc/paint/skottie_mru_resource_provider.cc
- M chrome/browser/bookmarks/bookmark_merged_surface_ordering_storage_unittest.cc
- M chrome/browser/controlled_frame/scoped_test_driver_proxy.cc
- M chrome/browser/devtools/device/devtools_device_discovery.cc
- M chrome/browser/devtools/device/port_forwarding_controller.cc
- M chrome/browser/devtools/devtools_ui_bindings.cc
- M chrome/browser/devtools/devtools_window.cc
- M chrome/browser/enterprise/connectors/device_trust/key_management/core/persistence/linux_key_persistence_delegate.cc
- M chrome/browser/enterprise/remote_commands/clear_browsing_data_job.cc
- M chrome/browser/enterprise/remote_commands/rotate_attestation_credential_job.cc
- M chrome/browser/extensions/component_loader.cc
- M chrome/browser/extensions/extension_service_unittest.cc
- M chrome/browser/first_run/bookmark_importer_unittest.cc
- M chrome/browser/glic/glic_user_status_request.cc
- M chrome/browser/media/router/discovery/access_code/access_code_cast_discovery_interface.cc
- M chrome/browser/printing/print_preview_sticky_settings.cc
- M chrome/browser/privacy_sandbox/notice/notice_storage_unittest.cc
- M chrome/browser/save_to_drive/drive_uploader.cc
- M chrome/browser/signin/bound_session_credentials/bound_session_registration_fetcher_impl.cc
- M chrome/browser/storage/shared_storage_browsertest.cc
- M chrome/browser/ui/webui/commerce/price_insights_handler_browsertest.cc
- M chrome/browser/ui/webui/commerce/product_specifications_ui_handler_delegate_browsertest.cc
- M chrome/browser/ui/webui/commerce/shopping_ui_handler_delegate_browsertest.cc
- M chrome/browser/ui/webui/print_preview/extension_printer_handler.cc
- M chrome/browser/upgrade_detector/version_history_client.cc
- M chrome/common/extensions/manifest_handlers/settings_overrides_handler_unittest.cc
- M chrome/updater/test/request_matcher.cc
- M components/account_id/account_id.cc
- M components/autofill/core/browser/manual_testing_import.cc
- M components/autofill/core/browser/payments/iban_save_manager_unittest.cc
- M components/autofill/core/browser/payments/save_and_fill_manager_impl_unittest.cc
- M components/bookmarks/browser/bookmark_storage_unittest.cc
- M components/cast_streaming/browser/cast_message_port_impl.cc
- M components/cast_streaming/common/message_serialization.cc
- M components/client_hints/browser/client_hints.cc
- M components/cloud_devices/common/cloud_device_description.cc
- M components/commerce/core/commerce_heuristics_data.cc
- M components/commerce/core/compare/cluster_server_proxy_unittest.cc
- M components/dom_distiller/core/page_features.cc
- M components/enterprise/connectors/core/realtime_reporting_test_server.cc
- M components/feedback/feedback_common.cc
- M components/heap_profiling/multi_process/test_driver.cc
- M components/media_router/common/providers/cast/channel/cast_message_handler_unittest.cc
- M components/net_log/net_export_file_writer_unittest.cc
- M components/network_time/network_time_tracker.cc
- M components/omnibox/browser/autocomplete_match_test_util.cc
- M components/omnibox/browser/autocomplete_match_type_unittest.cc
- M components/omnibox/browser/suggestion_answer_unittest.cc
- M components/plus_addresses/core/browser/plus_address_test_utils.cc
- M components/search_engines/search_engine_choice/search_engine_choice_service.cc
- M components/signin/public/base/session_binding_test_utils.cc
- M components/update_client/protocol_parser_json.cc
- M components/webcrypto/jwk.cc
- M content/browser/devtools/protocol/target_handler.cc
- M content/browser/interest_group/bidding_and_auction_serializer.cc
- M content/browser/site_per_process_browsertest.cc
- M content/browser/webid/delegation/email_verification_request_unittest.cc
- M content/browser/webid/delegation/sd_jwt_unittest.cc
- M content/browser/webid/webid_browsertest.cc
- M content/web_test/browser/devtools_protocol_test_bindings.cc
- M extensions/common/file_util_unittest.cc
- M google_apis/gaia/gaia_auth_fetcher.cc
- M google_apis/gaia/gaia_config.cc
- M google_apis/gaia/gaia_oauth_client.cc
- M google_apis/gaia/oauth2_access_token_fetcher_impl.cc
- M google_apis/gaia/oauth2_mint_token_flow.cc
- M net/device_bound_sessions/test_support.cc
- M net/dns/public/dns_over_https_config.cc
- M net/http/transport_security_persister.cc
- M net/tools/transport_security_state_generator/input_file_parsers.cc
- M remoting/base/instance_identity_token.cc
- M remoting/host/it2me/it2me_native_messaging_host_unittest.cc
- M remoting/host/security_key/security_key_extension_session.cc
- M remoting/host/setup/me2me_native_messaging_host.cc
- M remoting/host/setup/me2me_native_messaging_host_unittest.cc
- M remoting/protocol/ice_config_unittest.cc
- M remoting/test/it2me_cli_host.cc
- M remoting/test/test_token_storage.cc
- M services/network/sct_auditing/sct_auditing_reporter.cc
- M services/network/trust_tokens/trust_token_key_commitment_parser.cc
- M services/tracing/public/cpp/trace_startup_config.cc
- M third_party/blink/common/origin_trials/trial_token.cc
- M third_party/blink/renderer/core/inspector/dev_tools_host.cc
- M third_party/inspector_protocol/crdtp/chromium/protocol_traits_test.cc
- M tools/json_schema_compiler/test/generated_schemas_unittest.cc
Change size: L
Delta: 85 files changed, 243 insertions(+), 186 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 2:46:07 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Prepare to remove base::JSONReader::ReadDict's parsing option default
Callers should be explicit if they need to opt into non-compliant JSON
parsing that allows Chromium-specific extensions, e.g. comments. This
fixes instances included in a typical CrOS-on-Linux developer build.
Bug: 446188265
Change-Id: I53bb1778bbc24015759ce25cb229cd06c6c1afbb
Owners-Override: Lei Zhang <the...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519490}
Files:
- M ash/accelerators/tablet_volume_controller.cc
- M ash/system/power/power_button_controller.cc
- M chrome/browser/ash/arc/extensions/arc_support_message_host.cc
- M chrome/browser/ash/arc/tracing/arc_tracing_graphics_model.cc
- M chrome/browser/ash/guest_os/guest_os_terminal.cc
- M chrome/browser/ash/guest_os/guest_os_terminal_unittest.cc
- M chrome/browser/ash/login/demo_mode/demo_login_controller.cc
- M chrome/browser/ash/login/oobe_quick_start/second_device_auth_broker_unittest.cc
- M chrome/browser/ash/login/screens/locale_switch_screen.cc
- M chrome/browser/ash/net/rollback_network_config/rollback_network_config.cc
- M chrome/browser/ash/plugin_vm/plugin_vm_license_checker.cc
- M chrome/browser/ash/policy/networking/network_policy_application_browsertest.cc
- M chrome/browser/ash/policy/remote_commands/crd/device_command_start_crd_session_job.cc
- M chrome/browser/ash/policy/remote_commands/device_command_fetch_support_packet_job.cc
- M chrome/browser/ash/policy/remote_commands/device_command_get_routine_update_job.cc
- M chrome/browser/ash/policy/remote_commands/device_command_reboot_job.cc
- M chrome/browser/ash/policy/remote_commands/device_command_run_routine_job.cc
- M chrome/browser/ash/policy/remote_commands/device_command_screenshot_job.cc
- M chrome/browser/ash/policy/remote_commands/device_command_set_volume_job.cc
- M chrome/browser/ash/printing/oauth2/http_exchange.cc
- M chrome/browser/ui/webui/ash/network_ui/network_ui.cc
- M chromeos/ash/components/boca/receiver/register_receiver_request_unittest.cc
- M chromeos/ash/components/boca/receiver/start_kiosk_receiver_request_unittest.cc
- M chromeos/ash/components/dbus/debug_daemon/debug_daemon_client.cc
- M chromeos/ash/components/dbus/easy_unlock/fake_easy_unlock_client.cc
- M chromeos/ash/components/dbus/oobe_config/fake_oobe_configuration_client.cc
- M chromeos/ash/components/growth/campaigns_manager.cc
- M chromeos/ash/components/metrics/login_event_recorder.cc
- M chromeos/ash/components/network/cellular_metrics_logger_unittest.cc
- M chromeos/ash/components/policy/weekly_time/weekly_time_checked_unittest.cc
- M chromeos/ash/components/policy/weekly_time/weekly_time_interval_checked_unittest.cc
- M chromeos/ash/components/proximity_auth/messenger_impl.cc
- M chromeos/ash/services/secure_channel/wire_message.cc
- M chromeos/printing/ppd_metadata_parser.cc
- M components/quirks/quirks_client.cc
- M extensions/browser/api/networking_private/networking_private_chromeos_unittest.cc
- M remoting/host/chromeos/file_session_storage.cc
Change size: M
Delta: 37 files changed, 90 insertions(+), 70 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 2:46:56 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Prepare to remove base::JSONReader::ReadDict's parsing option default
Callers should be explicit if they need to opt into non-compliant JSON
parsing that allows Chromium-specific extensions, e.g. comments. This
fixes instances included in a typical Android developer build.
Bug: 446188265
Change-Id: Ic749bb9f113d8c55ecb7d255f57ec0372b944df1
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519491}
Files:
- M chrome/browser/android/backup/dict_pref_backup_serializer.cc
- M chrome/browser/password_manager/android/unified_password_manager_proto_utils.cc
Change size: XS
Delta: 2 files changed, 4 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 23, 2025, 2:48:10 PM (2 days ago) Sep 23
to Daniel Cheng, Lei Zhang, Christian Biesinger, chromium...@chromium.org, chromotin...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Kaan Icer, Mike Taylor, Nikhil Nayunigari, Victor Tan, ajayramamurthy+w...@google.com, ajayramamurthy+...@google.com, arc-review...@google.com, armalhotra+a...@google.com, asvitki...@chromium.org, ayman...@chromium.org, bcb+watch-pl...@chromium.org, bhartmire+wa...@google.com, blink-...@chromium.org, bnc+...@chromium.org, browser-comp...@chromium.org, cambickel+watc...@google.com, cbe-cep-eng...@google.com, cc-...@chromium.org, chadduffin+w...@chromium.org, chasej...@chromium.org, christia...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, cros-ed...@google.com, cros-print...@google.com, crost...@chromium.org, devtools-re...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, ejcaruso+wa...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, gcasto+w...@chromium.org, hansberry+wat...@chromium.org, hansberry+wa...@chromium.org, hashimo...@chromium.org, hidehik...@chromium.org, hsuregan+wa...@chromium.org, iclella...@chromium.org, jackshira+wat...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jasonrhee+wa...@google.com, jdeblas...@chromium.org, jdonnel...@chromium.org, jiajunz+wa...@google.com, jimmyxgong+wat...@chromium.org, jkeitel+watch-...@google.com, joeantonetti+wa...@google.com, jonmann+watc...@chromium.org, jonmann+wa...@chromium.org, kaklilu+watch-...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, longbowei+watc...@google.com, marimatthew+watc...@google.com, martijn...@martijnc.be, mdjone...@chromium.org, mfoltz+wa...@chromium.org, michaelcheco+wa...@google.com, milicau+watchlis...@google.com, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, npm+...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, print-rev...@chromium.org, print-revi...@chromium.org, rouslan+au...@chromium.org, rrsilva+wat...@google.com, rsleev...@chromium.org, security-...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, spang...@chromium.org, stevenjb+wa...@chromium.org, tbarzi...@chromium.org, tracing...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, wfh+...@chromium.org, yhanada+...@chromium.org, yigu+...@chromium.org, yuezhang...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Prepare to remove base::JSONReader::ReadDict's parsing option default
Callers should be explicit if they need to opt into non-compliant JSON
parsing that allows Chromium-specific extensions, e.g. comments. This
fixes instances included in a typical Windows developer build.
Bug: 446188265
Change-Id: Idb100d96a484cbedece64ee2921c0aab1d77599e
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Owners-Override: Lei Zhang <the...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1519493}
Files:
- M chrome/credential_provider/gaiacp/gem_device_details_manager_unittest.cc
- M content/browser/device_posture/device_posture_registry_watcher_win.cc
- M remoting/host/crash/crash_file_uploader.cc
Change size: S
Delta: 3 files changed, 7 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages