Remove superfluous includes from devtools_ui_bindings.h [chromium/src : main]

0 views

Skip to first unread message

Lei Zhang (Gerrit)

unread,

Oct 13, 2025, 7:33:40 PM (7 hours ago) Oct 13

to Lei Zhang, Alex Rudenko, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org

Attention needed from Alex Rudenko

Lei Zhang voted Auto-Submit+1

Auto-Submit

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

2:01 AM (18 minutes ago) 2:01 AM

to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org

Attention needed from Lei Zhang

Alex Rudenko voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

2:07 AM (13 minutes ago) 2:07 AM

to Lei Zhang, Alex Rudenko, chromium...@chromium.org, devtools...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Remove superfluous includes from devtools_ui_bindings.h

Move includes that are really only used in devtools_ui_bindings.cc over
into the .cc file. Forward declare in one instance. Then do IWYU to fix
the build.

Bug: 40318405

Change-Id: I623aff2afe7e107f5b992c90ef6d374f79eecc10

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7038753

Auto-Submit: Lei Zhang <the...@chromium.org>

Commit-Queue: Alex Rudenko <alexr...@chromium.org>

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1529330}

Files:

M chrome/browser/devtools/devtools_ui_bindings.cc
M chrome/browser/devtools/devtools_ui_bindings.h
M chrome/browser/ui/views/hats/hats_browsertest.cc

Change size: S

Delta: 3 files changed, 16 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alex Rudenko

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages