Support pre-filling the creation node in the `devtools-data-grid` [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Danil Somsikov (Gerrit)

unread,
Mar 23, 2026, 1:40:53 PM (19 hours ago) Mar 23
to Philip Pfaffe, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe

Danil Somsikov voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ifd625c4e03adaa803ac08ad671f5f6a33e9c84e8
Gerrit-Change-Number: 7691620
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Mar 2026 17:40:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
5:07 AM (3 hours ago) 5:07 AM
to Danil Somsikov, Jack Franklin, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov and Jack Franklin

Philip Pfaffe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ifd625c4e03adaa803ac08ad671f5f6a33e9c84e8
Gerrit-Change-Number: 7691620
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:07:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Danil Somsikov (Gerrit)

unread,
5:17 AM (3 hours ago) 5:17 AM
to Philip Pfaffe, Jack Franklin, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Danil Somsikov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ifd625c4e03adaa803ac08ad671f5f6a33e9c84e8
Gerrit-Change-Number: 7691620
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:17:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
5:19 AM (3 hours ago) 5:19 AM
to Danil Somsikov, Philip Pfaffe, Jack Franklin, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Support pre-filling the creation node in the `devtools-data-grid`

`<tr placeholder>` element now supports optional nested `<td>`s.
Bug: 407751405
Change-Id: Ifd625c4e03adaa803ac08ad671f5f6a33e9c84e8
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Commit-Queue: Danil Somsikov <d...@chromium.org>
Auto-Submit: Danil Somsikov <d...@chromium.org>
Files:
  • M front_end/ui/legacy/components/data_grid/DataGridElement.test.ts
  • M front_end/ui/legacy/components/data_grid/DataGridElement.ts
Change size: S
Delta: 2 files changed, 46 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Pfaffe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ifd625c4e03adaa803ac08ad671f5f6a33e9c84e8
Gerrit-Change-Number: 7691620
Gerrit-PatchSet: 2
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages