Remove use deprecated [Native] types in network_param.mojom [chromium/src : main]

[Daniel Cheng (Gerrit)]

Attention needed from mmenke

Daniel Cheng voted and added 3 comments

Votes added by Daniel Cheng

Commit-Queue

+1

3 comments

File services/network/public/mojom/network_context.mojom

Line 1602, Patchset 13 (Latest): // `tls_certificate`, or null otherwise.

Daniel Cheng . resolved

I needed to mark this as nullable; now that the type is no longer opaque to Mojo, Mojo enforces nullability. This comment is updated to reflect a very similar comment in cert_verifier_service.mojom

Line 1745, Patchset 13 (Latest): // TODO(dcheng): Why can this be optional?

Daniel Cheng . unresolved

... this one also came up in tests, though I'm not actually sure what it means to pass null here... any thoughts or feedback on improving this comment would be helpful.

File services/network/public/mojom/url_response_head.mojom

Line 57, Patchset 13 (Latest): HttpResponseHeaders? headers;

Daniel Cheng . resolved

I needed to mark this as nullable; now that the type is no longer opaque to Mojo, Mojo enforces nullability.

Open in Gerrit

Related details

Attention is currently required from:

• mmenke

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 13

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Ian Vollick <vol...@chromium.org>

Gerrit-CC: James Su <su...@chromium.org>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Lin, Wanming <wanmi...@intel.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Victor Tan <vict...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: mmenke <mme...@chromium.org>

Gerrit-Comment-Date: Mon, 06 Apr 2026 15:14:23 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Attention needed from mmenke

Daniel Cheng added 2 comments

File net/http/http_response_headers.cc

Line 379, Patchset 13 (Latest): pickle->WriteData(serialized);

Daniel Cheng . resolved

This is a slight change, but they are represented identically inside Pickle.

Line 873, Patchset 13 (Latest):std::vector<uint8_t> HttpResponseHeaders::Serialize(

Daniel Cheng . resolved

I made this a helper because it's silly to make a string and copy it into a pickle and then copy that into the IPC.

Gerrit-Comment-Date: Mon, 06 Apr 2026 15:19:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[mmenke (Gerrit)]

Attention needed from Daniel Cheng

mmenke added 13 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

mmenke . resolved

I am going to try to do a fairly thorough review here. Still need to review everything from services/network/public/cpp/BUILD.gn down to signed_certificate_timestamp_and_status.h (I'm reviewing mojom and traits together, of course).

Hope to have done a pass over everything by Wednesday. May end up finishing things tomorrow, just stopping once my eyes start to glaze over.

File net/http/http_response_headers.cc

Line 379, Patchset 13 (Latest): pickle->WriteData(serialized);

Daniel Cheng . unresolved

This is a slight change, but they are represented identically inside Pickle.

mmenke

This new code means we create an extra copy of the string in the case of PERSIST_RAW, which we didn't do before.

While I agree that saving us extra copies in the Mojo case is likely more important, I think we should also keep the old behavior here in the PERSIST_RAW case. We can either also make Serialize() have its own redundant code for PERSIST_RAW, or have it CHECK that PERSIST_RAW isn't passed to it.

File services/network/public/cpp/ssl_info_mojom_traits_unittest.cc

Line 21, Patchset 13 (Latest):TEST(SSLInfoMojoTraitsTest, SSLInfo) {

mmenke . unresolved

Suggest having two tests, with the values set differently, sharing a comparisons helper. Can just use default values in the other test, and non-defaults in this one.

Line 74, Patchset 13 (Latest): ASSERT_EQ(in.client_cert_sent, out.client_cert_sent);
ASSERT_EQ(in.handshake_type, out.handshake_type);
ASSERT_EQ(in.public_key_hashes, out.public_key_hashes);
ASSERT_EQ(in.encrypted_client_hello, out.encrypted_client_hello);

mmenke . unresolved

Let's match order in the mojom file here.

Line 104, Patchset 13 (Latest): ASSERT_EQ(in.ocsp_result, out.ocsp_result);

mmenke . unresolved

is_fatal_cert_error is missing.

Line 104, Patchset 13 (Latest): ASSERT_EQ(in.ocsp_result, out.ocsp_result);

mmenke . unresolved

Check that early_data_received and early_data_accepted are false? They're the two fields in SSLInfo that aren't passed over mojo. I have no idea if that's a but or not.

File services/network/public/cpp/x509_certificate_mojom_traits.cc

Line 1, Patchset 13 (Latest):// Copyright 2026 The Chromium Authors

mmenke . unresolved

Note: I did not review this file, and am not currently planning to - feel this is a bit too far out of my balliwick (though entirely possible I'll change my mind).

File services/network/public/mojom/signed_certificate_timestamp.mojom

Line 11, Patchset 13 (Latest): HASH_ALGO_NONE = 0,

mmenke . unresolved

In some of the other files, you switched to using kCamelCaseConstScheme for fields that

Line 43, Patchset 13 (Latest): kFromTlsExtension = 1,

mmenke . unresolved

Think it's a bit weird that for some of these, you kept net's LEGACY ENUM NAMING SCHEME, while for others you switched to kCoolNewNamingScheme. Fine as-is, but think it's better to adopt a philosophy here and stick with it.

File services/network/public/mojom/ssl_info.mojom

Line 29, Patchset 13 (Latest): // https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-signaturescheme, or 0 if unknown.

mmenke . unresolved

Reflow comment.

File services/network/public/mojom/websocket.mojom

Line 54, Patchset 13 (Latest): IPEndPoint remote_endpoint)
=> (AuthCredentials? credentials);

mmenke . unresolved

I highly recommend not doing random reformats in 2,000 line CLs. If you want to reformat stuff, send out another CL first. I'm happy to rubberstamp such CLs.

File services/network/shared_storage/shared_storage_request_helper.h

Line 15, Patchset 13 (Latest):#include "base/memory/weak_ptr.h"
#include "net/http/http_request_headers.h"

mmenke . unresolved

Think we can use a forward declaration here? Though the C++ file does need the include.

File third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Line 380, Patchset 13 (Latest): 'net::HttpVersion',
'net::HttpResponseHeaders',

mmenke . unresolved

These probably shouldn't the in the "Shared Memory" block, right?

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Mon, 06 Apr 2026 18:31:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>

[Daniel Cheng (Gerrit)]

Attention needed from mmenke

Daniel Cheng added 9 comments

Patchset-level comments

File-level comment, Patchset 13:

mmenke . resolved

I am going to try to do a fairly thorough review here. Still need to review everything from services/network/public/cpp/BUILD.gn down to signed_certificate_timestamp_and_status.h (I'm reviewing mojom and traits together, of course).

Hope to have done a pass over everything by Wednesday. May end up finishing things tomorrow, just stopping once my eyes start to glaze over.

Daniel Cheng

Thanks for the detailed review! I've uploaded a patchset, but it doesn't address the `SSLInfo` comments yet; I need to work my way through those more carefully.

File-level comment, Patchset 14:

Daniel Cheng . resolved

I haven't addressed all the comments yet

File net/http/http_response_headers.cc

Line 379, Patchset 13: pickle->WriteData(serialized);

Daniel Cheng . resolved

This is a slight change, but they are represented identically inside Pickle.

mmenke

This new code means we create an extra copy of the string in the case of PERSIST_RAW, which we didn't do before.

While I agree that saving us extra copies in the Mojo case is likely more important, I think we should also keep the old behavior here in the PERSIST_RAW case. We can either also make Serialize() have its own redundant code for PERSIST_RAW, or have it CHECK that PERSIST_RAW isn't passed to it.

Daniel Cheng

Done, with the latter.

File services/network/public/mojom/signed_certificate_timestamp.mojom

Line 11, Patchset 13: HASH_ALGO_NONE = 0,

mmenke . unresolved

In some of the other files, you switched to using kCamelCaseConstScheme for fields that

Daniel Cheng

These are moved from the original digitally_signed.mojom so I didn't change these (git/gerrit is inconsistent about detecting this as a move).

If you want consistency... I can go with the legacy style naming for everything, but I'm hoping not to :)

Line 43, Patchset 13: kFromTlsExtension = 1,

mmenke . resolved

Think it's a bit weird that for some of these, you kept net's LEGACY ENUM NAMING SCHEME, while for others you switched to kCoolNewNamingScheme. Fine as-is, but think it's better to adopt a philosophy here and stick with it.

Daniel Cheng

But these are new, hence the updated naming.

File services/network/public/mojom/ssl_info.mojom

Line 29, Patchset 13: // https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-signaturescheme, or 0 if unknown.

mmenke . resolved

Reflow comment.

Daniel Cheng

... apparently the mojom formatter does not deal with this case. Done, manually.

File services/network/public/mojom/websocket.mojom

Line 54, Patchset 13: IPEndPoint remote_endpoint)
=> (AuthCredentials? credentials);

mmenke . resolved

I highly recommend not doing random reformats in 2,000 line CLs. If you want to reformat stuff, send out another CL first. I'm happy to rubberstamp such CLs.

Daniel Cheng

Sadly, The mojom formatter isn't nearly as clever as the C++ one, so it formats the whole file. I'll see what I can do...

File services/network/shared_storage/shared_storage_request_helper.h

Line 15, Patchset 13:#include "base/memory/weak_ptr.h"
#include "net/http/http_request_headers.h"

mmenke . resolved

Think we can use a forward declaration here? Though the C++ file does need the include.

Daniel Cheng

Done

File third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Line 380, Patchset 13: 'net::HttpVersion',
'net::HttpResponseHeaders',

mmenke . resolved

These probably shouldn't the in the "Shared Memory" block, right?

Daniel Cheng

Blah, that's what I get for running `git cl format`. Fixed with a comment to hopefully keep this from happening again.

Open in Gerrit

Related details

Attention is currently required from:

• mmenke

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 15

Gerrit-Attention: mmenke <mme...@chromium.org>

Gerrit-Comment-Date: Tue, 07 Apr 2026 05:21:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: mmenke <mme...@chromium.org>

Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>

[mmenke (Gerrit)]

Attention needed from Daniel Cheng

mmenke added 4 comments

Patchset-level comments

File-level comment, Patchset 16 (Latest):

mmenke . resolved

Sorry, did not get very far on this today. Still hoping to finish up tomorrow.

File services/network/public/cpp/http_response_headers_mojom_traits.cc

Line 27, Patchset 16 (Latest): scoped_refptr<net::HttpResponseHeaders>* out) {
mojo::ArrayDataView<uint8_t> headers_data;

mmenke . unresolved

This class is undocumented. I assume this gets us a raw view of the data sent over IPC without copying?

File services/network/public/cpp/ssl_info_mojom_traits_unittest.cc

Line 104, Patchset 13: ASSERT_EQ(in.ocsp_result, out.ocsp_result);

mmenke . unresolved

Check that early_data_received and early_data_accepted are false? They're the two fields in SSLInfo that aren't passed over mojo. I have no idea if that's a but or not.

mmenke

*If that's a bug or not, rather.

File services/network/public/mojom/signed_certificate_timestamp.mojom

Line 11, Patchset 13: HASH_ALGO_NONE = 0,

mmenke . resolved

In some of the other files, you switched to using kCamelCaseConstScheme for fields that

Daniel Cheng

These are moved from the original digitally_signed.mojom so I didn't change these (git/gerrit is inconsistent about detecting this as a move).

If you want consistency... I can go with the legacy style naming for everything, but I'm hoping not to :)

mmenke

Acknowledged. Hadn't realized this was copied from old code. I agree it's best to leave well enough alone in this CL.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 16

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Tue, 07 Apr 2026 21:56:47 +0000

[mmenke (Gerrit)]

Attention needed from Daniel Cheng

mmenke added 2 comments

Patchset-level comments

File-level comment, Patchset 17 (Latest):

mmenke . resolved

Finished looking at this. Will sign off once comments are resolved. Thanks for the other CLs you made in response to my comments, too.

File services/network/public/cpp/http_response_headers_mojom_traits_unittest.cc

Line 13, Patchset 17 (Latest):
TEST(NetworkParamTraitsTest, HttpResponseHeaders) {

mmenke . unresolved

We should probably make sure cookie headers are removed, to make sure the right method is being invoked.

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 17

Gerrit-Comment-Date: Wed, 08 Apr 2026 20:54:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Daniel Cheng (Gerrit)]

Attention needed from mmenke

Daniel Cheng added 8 comments

File services/network/public/cpp/http_response_headers_mojom_traits.cc

Line 27, Patchset 16: scoped_refptr<net::HttpResponseHeaders>* out) {
mojo::ArrayDataView<uint8_t> headers_data;

mmenke . resolved

This class is undocumented. I assume this gets us a raw view of the data sent over IPC without copying?

Daniel Cheng

Yeah... I'll add some comments to this in a separate CL.

File services/network/public/cpp/http_response_headers_mojom_traits_unittest.cc

Line 13, Patchset 17:
TEST(NetworkParamTraitsTest, HttpResponseHeaders) {

mmenke . resolved

We should probably make sure cookie headers are removed, to make sure the right method is being invoked.

Daniel Cheng

Done (good catch; I had meant to do that but forgot to come back to it)

File services/network/public/cpp/ssl_info_mojom_traits_unittest.cc

Line 21, Patchset 13:TEST(SSLInfoMojoTraitsTest, SSLInfo) {

mmenke . resolved

Suggest having two tests, with the values set differently, sharing a comparisons helper. Can just use default values in the other test, and non-defaults in this one.

Daniel Cheng

I was being lazy so I had gemini-cli write the boilerplate.

I think ... it's OK? But there doesn't seem to be a good place for these sorts of things to live outside the tests so I just left it in the test.

Line 74, Patchset 13: ASSERT_EQ(in.client_cert_sent, out.client_cert_sent);


ASSERT_EQ(in.handshake_type, out.handshake_type);
ASSERT_EQ(in.public_key_hashes, out.public_key_hashes);
ASSERT_EQ(in.encrypted_client_hello, out.encrypted_client_hello);

mmenke . resolved

Let's match order in the mojom file here.

Daniel Cheng

Done

Line 104, Patchset 13: ASSERT_EQ(in.ocsp_result, out.ocsp_result);

mmenke . resolved

is_fatal_cert_error is missing.

Daniel Cheng

Done

Line 104, Patchset 13: ASSERT_EQ(in.ocsp_result, out.ocsp_result);

mmenke . resolved

Check that early_data_received and early_data_accepted are false? They're the two fields in SSLInfo that aren't passed over mojo. I have no idea if that's a but or not.

mmenke

*If that's a bug or not, rather.

Daniel Cheng

I've filed a bug and added a TODO to followup here as well.

File services/network/public/cpp/x509_certificate_mojom_traits.cc

Line 1, Patchset 13:// Copyright 2026 The Chromium Authors

mmenke . resolved

Note: I did not review this file, and am not currently planning to - feel this is a bit too far out of my balliwick (though entirely possible I'll change my mind).

Daniel Cheng

FWIW this is largely moved from network_param_mojom_traits.cc. Maybe the copyright header should match network_param_mojom_traits.cc? I'm never really sure...

File services/network/public/mojom/network_context.mojom

Line 1745, Patchset 13: // TODO(dcheng): Why can this be optional?

Daniel Cheng . unresolved

... this one also came up in tests, though I'm not actually sure what it means to pass null here... any thoughts or feedback on improving this comment would be helpful.

Daniel Cheng

@mme...@chromium.org curious if you have any suggestions for a comment here

Open in Gerrit

Related details

Attention is currently required from:

• mmenke

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 21

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Ian Vollick <vol...@chromium.org>

Gerrit-CC: James Su <su...@chromium.org>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Lin, Wanming <wanmi...@intel.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Victor Tan <vict...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromotin...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: mmenke <mme...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 04:25:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Daniel Cheng (Gerrit)]

Attention needed from Andrea Orru, Avi Drissman and mmenke

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 21 (Latest):

Daniel Cheng . resolved

+avi can you stamp the IWYU fixes in //chrome?
+andreaorru can you review the IWYU fix in //extensions? Feel free to review anything else you want as well if you want, though mmenke@ already did the overall and detailed review of the //net and //services/network portions

Open in Gerrit

Related details

Attention is currently required from:

• Andrea Orru
• Avi Drissman
• mmenke

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 21

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Attention: Avi Drissman <a...@chromium.org>

Gerrit-Attention: Andrea Orru <andre...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 04:30:20 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Avi Drissman (Gerrit)]

Attention needed from Andrea Orru, Daniel Cheng and mmenke

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 21 (Latest):

Avi Drissman . resolved

chrome/ changes lg

Open in Gerrit

Related details

Attention is currently required from:

• Andrea Orru
• Daniel Cheng
• mmenke

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 21

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Ian Vollick <vol...@chromium.org>

Gerrit-CC: James Su <su...@chromium.org>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Lin, Wanming <wanmi...@intel.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Victor Tan <vict...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromotin...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: mmenke <mme...@chromium.org>

Gerrit-Attention: Andrea Orru <andre...@chromium.org>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 14:33:03 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[mmenke (Gerrit)]

Attention needed from Andrea Orru and Daniel Cheng

mmenke voted and added 4 comments

Votes added by mmenke

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 21 (Latest):

mmenke . resolved

Still LGTM

File services/network/public/cpp/ssl_info_mojom_traits_unittest.cc

Line 21, Patchset 13:TEST(SSLInfoMojoTraitsTest, SSLInfo) {

mmenke . resolved

Suggest having two tests, with the values set differently, sharing a comparisons helper. Can just use default values in the other test, and non-defaults in this one.

Daniel Cheng

I was being lazy so I had gemini-cli write the boilerplate.

I think ... it's OK? But there doesn't seem to be a good place for these sorts of things to live outside the tests so I just left it in the test.

mmenke

I'm not a big fan of matchers unless they get you quite a lot that you couldn't get without them, because they're so much more difficult to read than C++. That having said, I'm certainly not going to push against a CL that uses them.

File services/network/public/cpp/x509_certificate_mojom_traits.cc

Line 1, Patchset 13:// Copyright 2026 The Chromium Authors

mmenke . resolved

Note: I did not review this file, and am not currently planning to - feel this is a bit too far out of my balliwick (though entirely possible I'll change my mind).

Daniel Cheng

FWIW this is largely moved from network_param_mojom_traits.cc. Maybe the copyright header should match network_param_mojom_traits.cc? I'm never really sure...

mmenke

I'm not seeing any calls to CreateCryptoBuffer or CryptoBufferAsSpan in network_param_mojom_traits.cc or any traits file in all of Chrome, for that matter.

It looks like net_ipc_param_traits does have some removed code to read/write x509 certs, but it looks substantially different to me. Not suspecting a bug, but it requires more than just glancing at two methods and confirming they're the same. Anyhow, I have skipped reviewing this.

File services/network/public/mojom/network_context.mojom

Line 1745, Patchset 13: // TODO(dcheng): Why can this be optional?

Daniel Cheng . unresolved

... this one also came up in tests, though I'm not actually sure what it means to pass null here... any thoughts or feedback on improving this comment would be helpful.

Daniel Cheng

@mme...@chromium.org curious if you have any suggestions for a comment here

mmenke

So, the description is:

```
// Will flush cached client certificate for `host` if `certificate`
// doesn't match the corresponding cached certificate.
```

So passing in null presumably unconditionally clears the cached client cert for `host`, regardless or what client cert is cached for host. Disclaimer: I'm not familiar with this API, but that seems like what it would presumably mean?

Open in Gerrit

Related details

Attention is currently required from:

• Andrea Orru
• Daniel Cheng

Gerrit-Attention: Andrea Orru <andre...@chromium.org>

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 15:53:39 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Andrea Orru (Gerrit)]

Attention needed from Daniel Cheng

Andrea Orru voted and added 1 comment

Votes added by Andrea Orru

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 21 (Latest):

Andrea Orru . resolved

extensions/ (and general change) lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Apr 2026 20:38:19 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Daniel Cheng added 2 comments

File services/network/public/cpp/x509_certificate_mojom_traits.cc

Line 1, Patchset 13:// Copyright 2026 The Chromium Authors

mmenke . resolved

Note: I did not review this file, and am not currently planning to - feel this is a bit too far out of my balliwick (though entirely possible I'll change my mind).

Daniel Cheng

FWIW this is largely moved from network_param_mojom_traits.cc. Maybe the copyright header should match network_param_mojom_traits.cc? I'm never really sure...

mmenke

I'm not seeing any calls to CreateCryptoBuffer or CryptoBufferAsSpan in network_param_mojom_traits.cc or any traits file in all of Chrome, for that matter.

It looks like net_ipc_param_traits does have some removed code to read/write x509 certs, but it looks substantially different to me. Not suspecting a bug, but it requires more than just glancing at two methods and confirming they're the same. Anyhow, I have skipped reviewing this.

Daniel Cheng

... ok I looked into this a bit more. I got confused at an earlier stage due to the large size of the diffs after the initial gemini pass.

So this logic is mostly inlined from [`Persist()`](https://source.chromium.org/chromium/chromium/src/+/main:net/cert/x509_certificate.cc;l=325;drc=0a4317210c4de343411da25ccf8145d3091b3007), but we can't use that helper directly here. I did simplify it a bit, but internally, it's all stored in `cert_buffers_`, where the first element is the cert represented by the object, and all subsequent elements are intermediates. I changed the .mojom definition to make this a bit clearer, since the cert itself is always mandatory.

For serialization, I also changed it to use `cert_span()` instead of `net::x509_util::CryptoBufferAsSpan(cert->cert_buffer())`; there does not appear to be any such helper for intermediates.

For deserialization, it's similarly inspired by [`X509Certificate::CreateFromPickleUnsafeOptions()`](https://source.chromium.org/chromium/chromium/src/+/main:net/cert/x509_certificate.cc;l=215;drc=56ce19c7e5b06543b57ccdf2436cd419051969a4). I also updated it to produce fewer copies by using a std::vector<std::string_view> and a different overload, and re-added the comment that was not preserved when the code moved. This also means the bssl magic is better encapsulated inside X509Certificate. Thank you for highlighting this, and sorry for missing this earlier.

File services/network/public/mojom/network_context.mojom

Line 1745, Patchset 13: // TODO(dcheng): Why can this be optional?

Daniel Cheng . resolved

... this one also came up in tests, though I'm not actually sure what it means to pass null here... any thoughts or feedback on improving this comment would be helpful.

Daniel Cheng

@mme...@chromium.org curious if you have any suggestions for a comment here

mmenke

So, the description is:

```
// Will flush cached client certificate for `host` if `certificate`
// doesn't match the corresponding cached certificate.
```

So passing in null presumably unconditionally clears the cached client cert for `host`, regardless or what client cert is cached for host. Disclaimer: I'm not familiar with this API, but that seems like what it would presumably mean?

Daniel Cheng

Good enough for me, thanks!

(This roughly matches my guess/understanding, but I wasn't 100% sure either. I'll just delete the TODO in that case)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 23

Gerrit-Comment-Date: Tue, 14 Apr 2026 05:42:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Daniel Cheng (Gerrit)]

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Tue, 14 Apr 2026 06:49:17 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)]

chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes

Unreviewed changes

21 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: services/network/public/mojom/network_context.mojom
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: services/network/public/cpp/x509_certificate_mojom_traits.cc
Insertions: 24, Deletions: 20.

The diff is too large to show. Please review the diff.
```
```
The name of the file: services/network/public/mojom/x509_certificate.mojom
Insertions: 4, Deletions: 3.

The diff is too large to show. Please review the diff.
```
```
The name of the file: services/network/public/cpp/x509_certificate_mojom_traits.h
Insertions: 6, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

Remove use deprecated [Native] types in network_param.mojom

This ends up being large change since it is easiest to convert an entire
tree of `[Native]` types at once, as it's a awkward to mix and match
`[Native]` and non-`[Native]` types without introducing temporary
`[Native]` types to bridge the transition. The opaque nature of
`[Native]` types also means that there were types that Mojo didn't even
know about at all, further increasing the size of the change.

To avoid making network_param.mojom a dumping ground of arbitrary types,
define the new types in distinct .mojom files, using a simple heuristic:
if the C++ types are defined in a single header, the Mojo types should
be defined in a single .mojom file as well. Several types previously
defined in network_param.mojom are also moved out to match this
heuristic.

The typemap definitions are also reorganized and split into smaller
blocks; in theory, this should allow more granular dependencies, though
this CL does not take full advantage of this since all the trait
definitions are built as one source set still. Additional cleanups:
- normalize how .cc trait sources are defined in the GN rules–the
  typemap definitions no longer use `trait_sources` and depend on the
  `source_set` that includes all the trait sources
- normalize where trait declarations and definitions live: the traits
  for X509Certificate are now in x509_certificate_mojom_traits.{cc,h}
  rather than being split across x509_certificate_mojom_traits.h and
  network_param_mojom_traits.cc.

Many typemaps also need to become shared typemaps now. This is necessary
because `URLLoaderCompletionStatus` transitively depends on `SSLInfo`,
which was previously a `[Native]` type. Unfortunately, this results in a
large compile size increase which is unavoidable: `[Native]` types are
entirely opaque to Mojo and as such, very little generated code was
needed to support them. Teaching Mojo about these types results in a lot
more generated code.

`HttpResponseHeaders` now has an internal, shared serialization helper,
since serializing to a pickle first and then serializing to Mojo is an
additional wasted copy. This helper is used by the original `Persist()`
method, as well as the new `SerializeForMojoIpc()` method. It would be
possible to do even better here, i.e. by teaching Mojo how to serialize
a segmented string, but that is left for a future followup if additional
efficiency is needed.

Since `HttpResponseHeaders` and `X509Certificate` are no longer opaque
types, nullability checks are now enforced by Mojo deserialization: this
revealed several bugs (in `CertVerifierService`, `NetworkContext`, and
`URLResponseHead`) where fields/parameters are not marked as nullable
despite comments indicating it could be null.

Finally, though it's not strictly necessary, make `HttpResponseHeaders`
a shared typemap as well. The raw form of `HttpResponseHeaders` is hard
to hold correctly, and it's safer to use the `net::HttpResponseHeaders`
to handle it.

Bug: 393179188

Bypass-Check-License: moved files

Compile-Size: unavoidable; see CL description for more details

Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7724381

Reviewed-by: Andrea Orru <andre...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Avi Drissman <a...@chromium.org>

Reviewed-by: mmenke <mme...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1614268}

Files:

• M chrome/browser/ui/web_applications/test/isolated_web_app_test_utils.cc
• M chrome/browser/ui/webui/chrome_url_data_manager_browsertest.cc
• M components/remote_cocoa/common/native_widget_ns_window.mojom
• M content/common/common_param_traits_unittest.cc
• M extensions/shell/browser/shell_extensions_browser_client.cc
• M mojo/public/tools/bindings/checks/mojom_attributes_check.py
• M net/cert/cert_verify_result.h
• M net/cert/ct_policy_status.h
• M net/http/http_response_headers.cc
• M net/http/http_response_headers.h
• M net/http/http_response_headers_unittest.cc
• M services/network/public/cpp/BUILD.gn
• A services/network/public/cpp/auth_mojom_traits.cc
• A services/network/public/cpp/auth_mojom_traits.h
• A services/network/public/cpp/cert_verify_result_mojom_traits.cc
• A services/network/public/cpp/cert_verify_result_mojom_traits.h
• A services/network/public/cpp/ct_policy_status_mojom_traits.cc
• A services/network/public/cpp/ct_policy_status_mojom_traits.h
• D services/network/public/cpp/digitally_signed_mojom_traits.cc
• D services/network/public/cpp/digitally_signed_mojom_traits.h
• M services/network/public/cpp/hash_value_mojom_traits.h
• A services/network/public/cpp/http_response_headers_mojom_traits.cc
• A services/network/public/cpp/http_response_headers_mojom_traits.h
• A services/network/public/cpp/http_response_headers_mojom_traits_unittest.cc
• M services/network/public/cpp/net_ipc_param_traits.cc
• M services/network/public/cpp/net_ipc_param_traits.h
• M services/network/public/cpp/network_param_mojom_traits.cc
• M services/network/public/cpp/network_param_mojom_traits.h
• A services/network/public/cpp/ocsp_verify_result_mojom_traits.cc
• A services/network/public/cpp/ocsp_verify_result_mojom_traits.h
• M services/network/public/cpp/resource_request.h
• A services/network/public/cpp/sct_status_flags_mojom_traits.cc
• A services/network/public/cpp/sct_status_flags_mojom_traits.h
• A services/network/public/cpp/signed_certificate_timestamp_and_status_mojom_traits.cc
• A services/network/public/cpp/signed_certificate_timestamp_and_status_mojom_traits.h
• A services/network/public/cpp/signed_certificate_timestamp_mojom_traits.cc
• A services/network/public/cpp/signed_certificate_timestamp_mojom_traits.h
• R services/network/public/cpp/signed_certificate_timestamp_mojom_traits_unittest.cc
• A services/network/public/cpp/ssl_info_mojom_traits.cc
• A services/network/public/cpp/ssl_info_mojom_traits.h
• A services/network/public/cpp/ssl_info_mojom_traits_unittest.cc
• M services/network/public/cpp/url_loader_completion_status_mojom_traits.cc
• M services/network/public/cpp/url_loader_completion_status_mojom_traits.h
• A services/network/public/cpp/x509_certificate_mojom_traits.cc
• A services/network/public/cpp/x509_certificate_mojom_traits.h
• M services/network/public/mojom/BUILD.gn
• A services/network/public/mojom/auth.mojom
• M services/network/public/mojom/cert_verifier_service.mojom
• A services/network/public/mojom/cert_verify_result.mojom
• A services/network/public/mojom/ct_policy_status.mojom
• M services/network/public/mojom/devtools_observer.mojom
• D services/network/public/mojom/digitally_signed.mojom
• A services/network/public/mojom/http_response_headers.mojom
• M services/network/public/mojom/network_context.mojom
• M services/network/public/mojom/network_param.mojom
• M services/network/public/mojom/network_service.mojom
• M services/network/public/mojom/network_service_test.mojom
• M services/network/public/mojom/network_types.mojom
• M services/network/public/mojom/oblivious_http_request.mojom
• A services/network/public/mojom/ocsp_verify_result.mojom
• A services/network/public/mojom/sct_status_flags.mojom
• A services/network/public/mojom/signed_certificate_timestamp.mojom
• A services/network/public/mojom/signed_certificate_timestamp_and_status.mojom
• A services/network/public/mojom/ssl_info.mojom
• M services/network/public/mojom/tcp_socket.mojom
• M services/network/public/mojom/url_loader_completion_status.mojom
• M services/network/public/mojom/url_loader_network_service_observer.mojom
• M services/network/public/mojom/url_request.mojom
• M services/network/public/mojom/url_response_head.mojom
• M services/network/public/mojom/web_transport.mojom
• M services/network/public/mojom/websocket.mojom
• A services/network/public/mojom/x509_certificate.mojom
• M services/network/shared_storage/shared_storage_request_helper.cc
• M services/network/shared_storage/shared_storage_request_helper.h
• M third_party/blink/public/mojom/fetch/fetch_api_response.mojom
• A third_party/blink/renderer/modules/webtransport/DEPS
• M third_party/blink/renderer/modules/webtransport/test_utils.cc
• M third_party/blink/renderer/modules/webtransport/web_transport.cc
• M third_party/blink/renderer/modules/webtransport/web_transport.h
• M third_party/blink/renderer/modules/webtransport/web_transport_test.cc
• M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py

Change size: XL

Delta: 81 files changed, 2181 insertions(+), 798 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Avi Drissman, +1 by mmenke, +1 by Andrea Orru

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I29aca81ae67488ab9421418b77a721d89a2f312f

Gerrit-Change-Number: 7724381

Gerrit-PatchSet: 24

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Andrea Orru <andre...@chromium.org>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: chromiu...@luci-project-accounts.iam.gserviceaccount.com <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Henrique Ferreiro <hfer...@igalia.com>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Ian Vollick <vol...@chromium.org>

Gerrit-CC: James Su <su...@chromium.org>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Lin, Wanming <wanmi...@intel.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Mike Taylor <mike...@chromium.org>

Gerrit-CC: Permissions Reviews <permissio...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Sarah Krakowiak <skra...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Victor Tan <vict...@chromium.org>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

[luci-bisection@appspot.gserviceaccount.com (Gerrit)]

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6359254454763520

Sample build with failed test: https://ci.chromium.org/b/8684561873987853713
Affected test(s):
[://\:blink_web_tests!webtest::virtual/stable/fast/dom/Window#open-invalid-url.html](https://ci.chromium.org/ui/test/chromium/:%2F%2F%5C:blink_web_tests%21webtest::virtual%2Fstable%2Ffast%2Fdom%2FWindow%23open-invalid-url.html?q=VHash%3Afe35cfb6dbc13663)
[://content/test\:content_unittests!gtest::NavigationURLLoaderImplTest#RedirectDuringURLLoader](https://ci.chromium.org/ui/test/chromium/:%2F%2Fcontent%2Ftest%5C:content_unittests%21gtest::NavigationURLLoaderImplTest%23RedirectDuringURLLoader?q=VHash%3Ac3bb378dfca1afa3)
A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6359254454763520&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7724381&type=BUG

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-CC: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Comment-Date: Tue, 14 Apr 2026 09:34:53 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Michael Ershov (Gerrit)]

Michael Ershov has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: revert