Add devicePixelRatio to Viewport trace event [chromium/src : main]
0 views
Skip to first unread message
Paul Irish (Gerrit)
Jul 2, 2024, 8:56:16 PMJul 2
to Adriana Ixba, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Adriana Ixba
Paul Irish voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Adriana Ixba
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adriana Ixba (Gerrit)
Jul 3, 2024, 4:39:11 PMJul 3
to Paul Irish, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Paul Irish
Adriana Ixba added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Jul 9, 2024, 2:35:26 PM (13 days ago) Jul 9
to Michal Mocny, Chromium LUCI CQ, Adriana Ixba, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Michal Mocny
Paul Irish voted![]( "Open in Gerrit")
Attention is currently required from:
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Jul 9, 2024, 3:26:09 PM (13 days ago) Jul 9
to Paul Irish, Chromium LUCI CQ, Adriana Ixba, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Paul Irish
Michal Mocny voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michal Mocny
| Code-Review | +1 |
1 comment
File third_party/blink/web_tests/http/tests/inspector-protocol/tracing/metadata-expected.txt
Line 113, Patchset 3 (Latest):
dpr: numberMichal Mocny . unresolved
The code diff tool makes it look like the other lines have tabs and this has spaces.
Not a blocker, just curious if the diff tool is wrong or if this should change to march style?
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Jul 9, 2024, 3:57:49 PM (13 days ago) Jul 9
to Michal Mocny, Chromium LUCI CQ, Adriana Ixba, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Paul Irish voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Irish
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File third_party/blink/web_tests/http/tests/inspector-protocol/tracing/metadata-expected.txt
The code diff tool makes it look like the other lines have tabs and this has spaces.
Not a blocker, just curious if the diff tool is wrong or if this should change to march style?
Paul Irish
nah i did it manually this time (for reasons) instead of relying on --reset-results.
learned my lesson!
thx for flagging :)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 9, 2024, 4:43:13 PM (13 days ago) Jul 9
to Paul Irish, Michal Mocny, Adriana Ixba, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/web_tests/http/tests/inspector-protocol/tracing/metadata-expected.txt
Insertions: 1, Deletions: 1.
@@ -110,7 +110,7 @@
Object: {
args: {
data: {
- dpr: number
+ dpr: number
viewport_rect: [
number,
number,
```
Change information
Commit message:
Add devicePixelRatio to Viewport trace event
Bug: 331429158
Change-Id: I6a5b9671a26db1e10cfb23175036a292f5bf39fa
Auto-Submit: Paul Irish <paul...@chromium.org>
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Paul Irish <paul...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1325117}
Files:
- M third_party/blink/renderer/core/paint/timing/paint_timing_visualizer.cc
- M third_party/blink/web_tests/http/tests/inspector-protocol/tracing/metadata-expected.txt
Change size: XS
Delta: 2 files changed, 2 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michal Mocny
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages