Make min check in eventIsInBounds exclusive [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Connor Clark (Gerrit)
Sep 23, 2025, 3:07:33 PM (2 days ago) Sep 23
to Paul Irish, Jack Franklin, devtools-rev...@chromium.org
Attention needed from Paul Irish
Connor Clark voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Sep 23, 2025, 3:35:05 PM (2 days ago) Sep 23
to Connor Clark, Devtools-frontend LUCI CQ, Jack Franklin, devtools-rev...@chromium.org
Attention needed from Connor Clark
Paul Irish voted and added 1 comment![]( "Open in Gerrit")
Votes added by Paul Irish
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Connor Clark
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Sep 23, 2025, 4:14:30 PM (2 days ago) Sep 23
to Connor Clark, Paul Irish, Jack Franklin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Make min check in eventIsInBounds exclusive
I found a bug that resulted in `AICallTree.fromEvent` selecting a
different event for the "rootNode.event" than the input selected task.
Rarely, a super tiny event is associated with the call tree generated
from a task, rather than the expected long RunTask event. That made the
Performance AI agent wrongly use the short event when describing this
work.
It turns out that there was another task just before the one of interest
whose ts + dur exactly equalled the ts of the task the function cared
about. So it got included in the "overlapping events" array, and since
it occurs earlier than the actual long task, it was used as the root
node's event.
Now that we know a task can begin in the same microsecond as the
previous task ended, it seems correct to modify the min check in
eventIsInBounds from inclusive to exclusive.
Bug: none
Change-Id: Ib0119e132df8c6cff38f3444fe0c13c9d2df1c59
Auto-Submit: Connor Clark <cja...@chromium.org>
Reviewed-by: Paul Irish <paul...@chromium.org>
Commit-Queue: Connor Clark <cja...@chromium.org>
Commit-Queue: Paul Irish <paul...@chromium.org>
Files:
- M front_end/models/trace/helpers/Timing.test.ts
- M front_end/models/trace/helpers/Timing.ts
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Irish
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages