Reland "[a11y][carousel] Update AX tree on scroll marker tab change" [chromium/src : main]

0 views
Skip to first unread message

Morten Stenshorne (Gerrit)

unread,
5:07 AM (7 hours ago) 5:07 AM
to Daniil Sakhapov, AyeAye, Chromium LUCI CQ, Lucas Radaelli, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, kyungjunle...@google.com, josiah...@chromium.org, blink-re...@chromium.org, dtseng...@chromium.org, devtools-re...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, abigailbk...@google.com, lucasrada...@google.com, blink-...@chromium.org, nektar...@chromium.org
Attention needed from Daniil Sakhapov and Lucas Radaelli

Morten Stenshorne voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniil Sakhapov
  • Lucas Radaelli
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f72212d88c6703cf60e515f2632bcdc83b3b450
Gerrit-Change-Number: 7560172
Gerrit-PatchSet: 2
Gerrit-Owner: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Reviewer: Lucas Radaelli <lucasr...@google.com>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Daniil Sakhapov <sakh...@chromium.org>
Gerrit-Attention: Lucas Radaelli <lucasr...@google.com>
Gerrit-Comment-Date: Tue, 10 Feb 2026 10:07:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Daniil Sakhapov (Gerrit)

unread,
7:16 AM (5 hours ago) 7:16 AM
to Morten Stenshorne, AyeAye, Chromium LUCI CQ, Lucas Radaelli, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, kyungjunle...@google.com, josiah...@chromium.org, blink-re...@chromium.org, dtseng...@chromium.org, devtools-re...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, abigailbk...@google.com, lucasrada...@google.com, blink-...@chromium.org, nektar...@chromium.org
Attention needed from Lucas Radaelli

Daniil Sakhapov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Lucas Radaelli
Gerrit-Attention: Lucas Radaelli <lucasr...@google.com>
Gerrit-Comment-Date: Tue, 10 Feb 2026 12:16:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
7:21 AM (5 hours ago) 7:21 AM
to Daniil Sakhapov, Morten Stenshorne, AyeAye, Lucas Radaelli, chromium...@chromium.org, (Julie)Jeongeun Kim, Akihiro Ota, Kevin Babbitt, kyungjunle...@google.com, josiah...@chromium.org, blink-re...@chromium.org, dtseng...@chromium.org, devtools-re...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, francisjp...@google.com, abigailbk...@google.com, lucasrada...@google.com, blink-...@chromium.org, nektar...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Reland "[a11y][carousel] Update AX tree on scroll marker tab change"

This is a reland of commit 3ab0eeea7e8988885c204b35ae9afda6a892275f

The revert happened to IDs in the test not being stable, now it's fixed.

Original change's description:
> [a11y][carousel] Update AX tree on scroll marker tab change
>
> When the active ::scroll-marker changes, we need to update AX tree, as
> content from inactive tabs isn't included, so we need to recalculate it.
>
> This CL also disables adding children for a node that is inside inactive
> tab, as otherwise it leads to reparenting errors.
>
> Bug: 423568126
> Change-Id: Ice4915c2bd7f44255c89ad5197a19cf2c8daca3b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7511428
> Reviewed-by: Lucas Radaelli <lucasr...@google.com>
> Reviewed-by: Morten Stenshorne <mste...@chromium.org>
> Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1580987}
Bug: 423568126
Change-Id: I4f72212d88c6703cf60e515f2632bcdc83b3b450
Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
Reviewed-by: Morten Stenshorne <mste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1582421}
Files:
  • M third_party/blink/renderer/core/accessibility/ax_object_cache.h
  • M third_party/blink/renderer/core/dom/scroll_marker_pseudo_element.cc
  • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
  • M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.cc
  • M third_party/blink/renderer/modules/accessibility/ax_object_cache_impl.h
  • A third_party/blink/web_tests/http/tests/inspector-protocol/accessibility/accessibility-nodes-updated-retrieves-children-expected.txt
  • A third_party/blink/web_tests/http/tests/inspector-protocol/accessibility/accessibility-nodes-updated-retrieves-children.js
  • A third_party/blink/web_tests/http/tests/inspector-protocol/resources/carousel.html
Change size: L
Delta: 8 files changed, 296 insertions(+), 24 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Morten Stenshorne
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f72212d88c6703cf60e515f2632bcdc83b3b450
Gerrit-Change-Number: 7560172
Gerrit-PatchSet: 3
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages