Revert "[styles-widget] Make StylePropertiesSection self-update" [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Kim-Anh Tran (Gerrit)

unread,
4:00 AM (4 hours ago) 4:00 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe

Kim-Anh Tran added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kim-Anh Tran . resolved

Hi Philip, this is the revert, PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I7e8baf4d98e7852719bbda2f6572fb7212e543cf
Gerrit-Change-Number: 7691245
Gerrit-PatchSet: 3
Gerrit-Owner: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 08:00:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
5:01 AM (3 hours ago) 5:01 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Kim-Anh Tran

Philip Pfaffe voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kim-Anh Tran
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I7e8baf4d98e7852719bbda2f6572fb7212e543cf
Gerrit-Change-Number: 7691245
Gerrit-PatchSet: 3
Gerrit-Owner: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Mar 2026 09:01:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kim-Anh Tran (Gerrit)

unread,
6:05 AM (2 hours ago) 6:05 AM
to Philip Pfaffe, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Kim-Anh Tran voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I7e8baf4d98e7852719bbda2f6572fb7212e543cf
Gerrit-Change-Number: 7691245
Gerrit-PatchSet: 3
Gerrit-Owner: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 24 Mar 2026 10:04:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
6:08 AM (2 hours ago) 6:08 AM
to Kim-Anh Tran, Philip Pfaffe, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Revert "[styles-widget] Make StylePropertiesSection self-update"

Having StylePropertiesSection update itself while containers
occasionally re-render (by rebuilding everything) may lead to
races.

This reverts commit e5815f7fbd156de16185286df48a8fed885aae0a.
Bug: 475842775
Change-Id: I7e8baf4d98e7852719bbda2f6572fb7212e543cf
Commit-Queue: Kim-Anh Tran <kim...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
  • M front_end/panels/elements/StandaloneStylesContainer.ts
  • M front_end/panels/elements/StylePropertiesSection.test.ts
  • M front_end/panels/elements/StylePropertiesSection.ts
  • M front_end/panels/elements/StylesContainer.ts
  • M front_end/panels/elements/StylesSidebarPane.ts
  • M test/e2e/elements/flexbox-editor.test.ts
  • M test/e2e/elements/grid-editor.test.ts
  • M test/e2e/elements/grid-lanes-editor.test.ts
  • M test/e2e/helpers/elements-helpers.ts
Change size: M
Delta: 9 files changed, 48 insertions(+), 156 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Pfaffe
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I7e8baf4d98e7852719bbda2f6572fb7212e543cf
Gerrit-Change-Number: 7691245
Gerrit-PatchSet: 4
Gerrit-Owner: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages