Refactor: Move GrantSiteAccess to ExtensionsToolbarViewModel [chromium/src : main]
0 views
Skip to first unread message
Eva Su (Gerrit)
Apr 10, 2026, 2:36:43 PM (5 days ago) Apr 10
to Emilia Paz, Chromium LUCI CQ, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
Eva Su voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Apr 13, 2026, 1:33:29 AM (2 days ago) Apr 13
to Eva Su, Chromium LUCI CQ, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Eva Su
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Eva Su
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eva Su (Gerrit)
Apr 13, 2026, 1:33:56 PM (2 days ago) Apr 13
to chromiu...@luci-project-accounts.iam.gserviceaccount.com, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Eva Su voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromium-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Apr 13, 2026, 3:47:55 PM (2 days ago) Apr 13
to Eva Su, Emilia Paz, Mirko Bonadei, Jerome Jiang, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, cblume...@chromium.org, jz...@chromium.org, penghuan...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, chrome-intell...@chromium.org, net-r...@chromium.org, mar...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
chromiu...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Refactor: Move GrantSiteAccess to ExtensionsToolbarViewModel
Moves GrantSiteAccess logic from ExtensionsToolbarAndroid and ExtensionsRequestAccessButton to ExtensionsToolbarViewModel, so that it can be shared and used by all delegates.
Bug: 499007513
Change-Id: I982a9b6f4c93b450cbafed74c28f9dc1cf942fa3
Commit-Queue: Eva Su <ev...@chromium.org>
Reviewed-by: Emilia Paz <emil...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1613913}
Files:
- M chrome/browser/ui/android/extensions/extensions_toolbar_android.cc
- M chrome/browser/ui/android/extensions/extensions_toolbar_android.h
- M chrome/browser/ui/extensions/extensions_toolbar_view_model.cc
- M chrome/browser/ui/extensions/extensions_toolbar_view_model.h
- M chrome/browser/ui/views/extensions/extensions_request_access_button.cc
- M chrome/browser/ui/views/extensions/extensions_request_access_button.h
Change size: M
Delta: 6 files changed, 34 insertions(+), 48 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emilia Paz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages