[visual_logging] Enforce kebab case for new jslog contexts. [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Benedikt Meurer (Gerrit)
Sep 23, 2025, 7:57:44 AM (yesterday) Sep 23
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Benedikt Meurer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Benedikt Meurer
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Benedikt Meurer . resolved
Hey Nik, can you take a look please?
Related details
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Sep 23, 2025, 10:37:40 AM (yesterday) Sep 23
to Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer
Nikolay Vitkov added 3 comments![]( "Open in Gerrit")
File PRESUBMIT.py
Line 467, Patchset 3 (Latest):
r"^([a-z0-9]+(?:-[a-z0-9]+)*\.)*[a-z0-9]+(?:-[a-z0-9]+)*$")Nikolay Vitkov . unresolved
As you said this was taken from a file can you leave a comment with which file it was?
Line 474, Patchset 3 (Latest):
for _, line in f.ChangedContents():Nikolay Vitkov . unresolved
Let's add a pointer comment that here we are reading the lines that changed explicitly.
Line 493, Patchset 3 (Latest):
output_api.PresubmitResultLocation(file_path=local_path)Nikolay Vitkov . resolved
Love to see more uses of locations!
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Sep 23, 2025, 10:37:44 AM (yesterday) Sep 23
to Benedikt Meurer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer
Nikolay Vitkov voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Sep 23, 2025, 10:40:50 AM (24 hours ago) Sep 23
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Benedikt Meurer voted and added 2 comments![]( "Open in Gerrit")
Votes added by Benedikt Meurer
| Auto-Submit | +1 |
| Commit-Queue | +2 |
2 comments
File PRESUBMIT.py
Line 467, Patchset 3:
r"^([a-z0-9]+(?:-[a-z0-9]+)*\.)*[a-z0-9]+(?:-[a-z0-9]+)*$")Nikolay Vitkov . resolved
As you said this was taken from a file can you leave a comment with which file it was?
Benedikt Meurer
Done
Let's add a pointer comment that here we are reading the lines that changed explicitly.
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Sep 23, 2025, 11:26:11 AM (23 hours ago) Sep 23
to Benedikt Meurer, Nikolay Vitkov, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: PRESUBMIT.py
Insertions: 9, Deletions: 0.
@@ -463,6 +463,14 @@
def CheckKnownContextValues(input_api, output_api):
+ """Ensure all additions to `KnownContextValues.ts` following the naming convention.
+
+ This check ensures that all new cases added to the enum in `KnownContextValues.ts`
+ follow the extended Kebab Case naming convention. Specifically it doesn't look at
+ unchanged lines, because there are various existing values that cannot be changed
+ (easily).
+ """
+ # This regexp matches the one we use in `StringUtilities.isExtendedKebabCase()`.
kebab_case_re = re.compile(
r"^([a-z0-9]+(?:-[a-z0-9]+)*\.)*[a-z0-9]+(?:-[a-z0-9]+)*$")
local_path = input_api.os_path.join('front_end', 'ui', 'visual_logging',
@@ -471,6 +479,7 @@
for f in filter(
lambda x: (x.LocalPath() == local_path and x.Action() == 'M'),
input_api.AffectedFiles()):
+ # Loop only through the changed lines of the affected file.
for _, line in f.ChangedContents():
match = re.search(r"\s+'(.+)',", line)
if match:
```
Change information
Commit message:
[visual_logging] Enforce kebab case for new jslog contexts.
For any new value added to the `KnownContextValues.ts` file, ensure it
follows the extended Kebab Case naming convention.
Fixed: 446818115
Change-Id: I6e50cbb4403de3d40d903c9cd59c6d010bd8fbef
Auto-Submit: Benedikt Meurer <bme...@chromium.org>
Reviewed-by: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Benedikt Meurer <bme...@chromium.org>
Files:
- M PRESUBMIT.py
Change size: S
Delta: 1 file changed, 45 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nikolay Vitkov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages