Make "Don't show again" accessible for ONLY keyboard users [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Samiya Caur (Gerrit)

unread,
9:57 AM (3 hours ago) 9:57 AM
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Samiya Caur voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Id5f3154b9df56cff550b5b4d88ccd190812cabaf
Gerrit-Change-Number: 7563049
Gerrit-PatchSet: 1
Gerrit-Owner: Samiya Caur <sam...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Feb 2026 14:57:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
9:59 AM (3 hours ago) 9:59 AM
to Samiya Caur, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Samiya Caur

Jack Franklin added 1 comment

File front_end/panels/common/AiCodeCompletionTeaser.ts
Line 143, Patchset 1 (Latest): <span role="button" class="ai-code-completion-teaser-dismiss"
Jack Franklin . unresolved

if there isn't an explicit reason these are spans, we should consider if we can use a <button> element where I think we would get all of this by default without so much extra code.

wdyt?

Open in Gerrit

Related details

Attention is currently required from:
  • Samiya Caur
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Id5f3154b9df56cff550b5b4d88ccd190812cabaf
    Gerrit-Change-Number: 7563049
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samiya Caur <sam...@chromium.org>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Samiya Caur <sam...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 14:59:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Samiya Caur (Gerrit)

    unread,
    10:06 AM (2 hours ago) 10:06 AM
    to Devtools-frontend LUCI CQ, Jack Franklin, devtools-rev...@chromium.org
    Attention needed from Jack Franklin

    Samiya Caur added 1 comment

    File front_end/panels/common/AiCodeCompletionTeaser.ts
    Line 143, Patchset 1 (Latest): <span role="button" class="ai-code-completion-teaser-dismiss"
    Jack Franklin . unresolved

    if there isn't an explicit reason these are spans, we should consider if we can use a <button> element where I think we would get all of this by default without so much extra code.

    wdyt?

    Samiya Caur

    Hey Jack, I remember this had come up during the initial implementation. I believe b/444419226#comment4 was the reason for using `span` with role `button`

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jack Franklin
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Id5f3154b9df56cff550b5b4d88ccd190812cabaf
    Gerrit-Change-Number: 7563049
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samiya Caur <sam...@chromium.org>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 15:06:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jack Franklin <jacktf...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jack Franklin (Gerrit)

    unread,
    10:18 AM (2 hours ago) 10:18 AM
    to Samiya Caur, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
    Attention needed from Samiya Caur

    Jack Franklin voted and added 2 comments

    Votes added by Jack Franklin

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Jack Franklin . resolved

    lgtm

    File front_end/panels/common/AiCodeCompletionTeaser.ts
    Line 143, Patchset 1 (Latest): <span role="button" class="ai-code-completion-teaser-dismiss"
    Jack Franklin . resolved

    if there isn't an explicit reason these are spans, we should consider if we can use a <button> element where I think we would get all of this by default without so much extra code.

    wdyt?

    Samiya Caur

    Hey Jack, I remember this had come up during the initial implementation. I believe b/444419226#comment4 was the reason for using `span` with role `button`

    Jack Franklin

    Thanks! Let's leave this for now then and not get too sidetracked. ty!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Samiya Caur
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Id5f3154b9df56cff550b5b4d88ccd190812cabaf
    Gerrit-Change-Number: 7563049
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samiya Caur <sam...@chromium.org>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Samiya Caur <sam...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 15:18:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Samiya Caur <sam...@chromium.org>
    Comment-In-Reply-To: Jack Franklin <jacktf...@chromium.org>
    satisfied_requirement
    open
    diffy

    Samiya Caur (Gerrit)

    unread,
    10:18 AM (2 hours ago) 10:18 AM
    to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

    Samiya Caur voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Id5f3154b9df56cff550b5b4d88ccd190812cabaf
    Gerrit-Change-Number: 7563049
    Gerrit-PatchSet: 1
    Gerrit-Owner: Samiya Caur <sam...@chromium.org>
    Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
    Gerrit-Reviewer: Samiya Caur <sam...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Comment-Date: Tue, 10 Feb 2026 15:18:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Devtools-frontend LUCI CQ (Gerrit)

    unread,
    10:54 AM (2 hours ago) 10:54 AM
    to Samiya Caur, Jack Franklin, devtools-rev...@chromium.org

    Devtools-frontend LUCI CQ submitted the change

    Change information

    Commit message:
    Make "Don't show again" accessible for ONLY keyboard users
    Bug: 481723904
    Change-Id: Id5f3154b9df56cff550b5b4d88ccd190812cabaf
    Auto-Submit: Samiya Caur <sam...@chromium.org>
    Commit-Queue: Samiya Caur <sam...@chromium.org>
    Reviewed-by: Jack Franklin <jacktf...@chromium.org>
    Files:
    • M front_end/panels/common/AiCodeCompletionTeaser.ts
    • M front_end/panels/common/aiCodeCompletionTeaser.css
    Change size: S
    Delta: 2 files changed, 17 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Jack Franklin
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Id5f3154b9df56cff550b5b4d88ccd190812cabaf
    Gerrit-Change-Number: 7563049
    Gerrit-PatchSet: 2
    Gerrit-Owner: Samiya Caur <sam...@chromium.org>
    Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages