Convert deviceSelectItem ToolbarMenuButton into ToolbarComboBox [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Danil Somsikov (Gerrit)

unread,
Jan 16, 2026, 3:23:36 AM (4 days ago) Jan 16
to Philip Pfaffe, AyeAye, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe

Danil Somsikov voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Philip Pfaffe
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Ia960255abd03ae76e5d581e8dde48f0846ec7c7f
Gerrit-Change-Number: 7485624
Gerrit-PatchSet: 3
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 08:23:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Pfaffe (Gerrit)

unread,
Jan 19, 2026, 3:41:00 AM (yesterday) Jan 19
to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Philip Pfaffe added 2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Philip Pfaffe . unresolved

The UI looks a little strange compared to the other dropdowns in the mobile emulation toolbar, it has a different border and the separators look different. Any chance we can make that look the same?

File front_end/panels/emulation/DeviceModeToolbar.ts
Line 601, Patchset 3 (Latest): this.emulatedDevicesList.revealCustomSetting.bind(this.emulatedDevicesList)();
Philip Pfaffe . unresolved

Just call directly.

Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia960255abd03ae76e5d581e8dde48f0846ec7c7f
    Gerrit-Change-Number: 7485624
    Gerrit-PatchSet: 3
    Gerrit-Owner: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Danil Somsikov <d...@chromium.org>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 08:40:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Danil Somsikov (Gerrit)

    unread,
    Jan 19, 2026, 8:31:05 AM (22 hours ago) Jan 19
    to Devtools-frontend LUCI CQ, Philip Pfaffe, AyeAye, devtools-rev...@chromium.org
    Attention needed from Philip Pfaffe

    Danil Somsikov added 2 comments

    Patchset-level comments
    Philip Pfaffe . unresolved

    The UI looks a little strange compared to the other dropdowns in the mobile emulation toolbar, it has a different border and the separators look different. Any chance we can make that look the same?

    Danil Somsikov

    Which OS?

    File front_end/panels/emulation/DeviceModeToolbar.ts
    Line 601, Patchset 3: this.emulatedDevicesList.revealCustomSetting.bind(this.emulatedDevicesList)();
    Philip Pfaffe . resolved

    Just call directly.

    Danil Somsikov

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Philip Pfaffe
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia960255abd03ae76e5d581e8dde48f0846ec7c7f
    Gerrit-Change-Number: 7485624
    Gerrit-PatchSet: 5
    Gerrit-Owner: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 13:31:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Philip Pfaffe <pfa...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Pfaffe (Gerrit)

    unread,
    Jan 19, 2026, 8:32:07 AM (22 hours ago) Jan 19
    to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
    Attention needed from Danil Somsikov

    Philip Pfaffe added 1 comment

    Patchset-level comments
    Philip Pfaffe . unresolved

    The UI looks a little strange compared to the other dropdowns in the mobile emulation toolbar, it has a different border and the separators look different. Any chance we can make that look the same?

    Danil Somsikov

    Which OS?

    Philip Pfaffe

    Linux.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danil Somsikov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia960255abd03ae76e5d581e8dde48f0846ec7c7f
    Gerrit-Change-Number: 7485624
    Gerrit-PatchSet: 5
    Gerrit-Owner: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Danil Somsikov <d...@chromium.org>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 13:32:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Philip Pfaffe <pfa...@chromium.org>
    Comment-In-Reply-To: Danil Somsikov <d...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Pfaffe (Gerrit)

    unread,
    2:31 AM (4 hours ago) 2:31 AM
    to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
    Attention needed from Danil Somsikov

    Philip Pfaffe added 1 comment

    Patchset-level comments
    Philip Pfaffe . unresolved

    The UI looks a little strange compared to the other dropdowns in the mobile emulation toolbar, it has a different border and the separators look different. Any chance we can make that look the same?

    Danil Somsikov

    Which OS?

    Philip Pfaffe

    Linux.

    Philip Pfaffe

    So if this is the native UI I'm fine with it. There's still an unfortunate disconnect between this and the other drop downs, hopefully we can close the gab quick enough so that it doesn't really impact users too much.

    Something's off with the patchsets.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Danil Somsikov
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: devtools/devtools-frontend
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia960255abd03ae76e5d581e8dde48f0846ec7c7f
    Gerrit-Change-Number: 7485624
    Gerrit-PatchSet: 6
    Gerrit-Owner: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
    Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>
    Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Attention: Danil Somsikov <d...@chromium.org>
    Gerrit-Comment-Date: Tue, 20 Jan 2026 07:31:51 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages