Move oauth_consumer_id in c/signin/public/base [chromium/src : main]

0 views
Skip to first unread message

Tanmoy Mollik (Gerrit)

unread,
Nov 3, 2025, 9:59:44 AM (3 days ago) Nov 3
to Boris Sazonov, Mitsuru Oshima, Sylvain Defresne, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
Attention needed from Boris Sazonov and Sylvain Defresne

Tanmoy Mollik voted and added 6 comments

Votes added by Tanmoy Mollik

Commit-Queue+1

6 comments

File chrome/browser/BUILD.gn
Line 1371, Patchset 18: "signin/chrome_oauth_consumer_registry.cc",
Sylvain Defresne . resolved

It looks like this is unrelated to moving the files.

Please extract this to a separate CL.

Tanmoy Mollik

Done

File chrome/browser/signin/chrome_oauth_consumer_registry.h
Line 12, Patchset 18:class ChromeOAuthConsumerRegistry : public OAuthConsumerRegistry {
Sylvain Defresne . resolved

It looks like this is unrelated to moving the files.

Please extract this to a separate CL.

Tanmoy Mollik

Done

File chrome/browser/signin/chrome_oauth_consumer_registry.cc
Line 11, Patchset 18:OAuthConsumer ChromeOAuthConsumerRegistry::GetOAuthConsumerFromIdInternal(
Sylvain Defresne . resolved

It looks like this is unrelated to moving the files.

Please extract this to a separate CL.

Tanmoy Mollik

Done

File chrome/browser/signin/chrome_signin_client.h
Line 84, Patchset 18: signin::OAuthConsumer GetOAuthConsumerFromId(
Sylvain Defresne . resolved

It looks like this is unrelated to moving the files.

Please extract this to a separate CL.

Tanmoy Mollik

Done

File chrome/browser/signin/chrome_signin_client.cc
Line 200, Patchset 18: oauth_consumer_registry_(signin::ChromeOAuthConsumerRegistry()) {
Sylvain Defresne . resolved

It looks like this is unrelated to moving the files.

Please extract this to a separate CL.

Tanmoy Mollik

Done

File chromeos/ash/components/boca/babelorca/oauth_token_fetcher.cc
Line 108, Patchset 18: << static_cast<int>(oauth_consumer_id_)
Sylvain Defresne . unresolved

It looks like this is unrelated to moving the files.

Please extract this to a separate CL.

Tanmoy Mollik

This method will no longer be available publically. If i move it in a different cl then I will have to add Mitsuru again for review. To avoid back and forth I would like to keep this change in this cl if it's okay with you.

Open in Gerrit

Related details

Attention is currently required from:
  • Boris Sazonov
  • Sylvain Defresne
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idaddbfc913e16bd62486cd7aa8b79b28a1c1637f
Gerrit-Change-Number: 7046430
Gerrit-PatchSet: 20
Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
Gerrit-Attention: Boris Sazonov <bsaz...@chromium.org>
Gerrit-Comment-Date: Mon, 03 Nov 2025 14:59:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sylvain Defresne <sdef...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Boris Sazonov (Gerrit)

unread,
Nov 4, 2025, 8:30:23 AM (2 days ago) Nov 4
to Tanmoy Mollik, Boris Sazonov, Mitsuru Oshima, Sylvain Defresne, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
Attention needed from Sylvain Defresne and Tanmoy Mollik

Boris Sazonov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sylvain Defresne
  • Tanmoy Mollik
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idaddbfc913e16bd62486cd7aa8b79b28a1c1637f
    Gerrit-Change-Number: 7046430
    Gerrit-PatchSet: 21
    Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 13:23:03 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sylvain Defresne (Gerrit)

    unread,
    Nov 4, 2025, 8:31:54 AM (2 days ago) Nov 4
    to Tanmoy Mollik, Boris Sazonov, Mitsuru Oshima, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
    Attention needed from Tanmoy Mollik

    Sylvain Defresne added 1 comment

    File chromeos/ash/components/boca/babelorca/oauth_token_fetcher.cc
    Line 108, Patchset 18: << static_cast<int>(oauth_consumer_id_)
    Sylvain Defresne . unresolved

    It looks like this is unrelated to moving the files.

    Please extract this to a separate CL.

    Tanmoy Mollik

    This method will no longer be available publically. If i move it in a different cl then I will have to add Mitsuru again for review. To avoid back and forth I would like to keep this change in this cl if it's okay with you.

    Sylvain Defresne

    I don't understand.

    Moving files around shouldn't change visibility of a method/function.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tanmoy Mollik
    Gerrit-Comment-Date: Tue, 04 Nov 2025 13:31:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Tanmoy Mollik <triplo...@google.com>
    Comment-In-Reply-To: Sylvain Defresne <sdef...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tanmoy Mollik (Gerrit)

    unread,
    Nov 4, 2025, 8:56:27 AM (2 days ago) Nov 4
    to Boris Sazonov, Mitsuru Oshima, Sylvain Defresne, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
    Attention needed from Sylvain Defresne

    Tanmoy Mollik added 1 comment

    File chromeos/ash/components/boca/babelorca/oauth_token_fetcher.cc
    Line 108, Patchset 18: << static_cast<int>(oauth_consumer_id_)
    Sylvain Defresne . unresolved

    It looks like this is unrelated to moving the files.

    Please extract this to a separate CL.

    Tanmoy Mollik

    This method will no longer be available publically. If i move it in a different cl then I will have to add Mitsuru again for review. To avoid back and forth I would like to keep this change in this cl if it's okay with you.

    Sylvain Defresne

    I don't understand.

    Moving files around shouldn't change visibility of a method/function.

    Tanmoy Mollik

    I meant in the following cl it will no longer be available. I have moved the subclasses and signin code changes to a different cl like you requested. It will no longer need review from you or Mitsuru. If i move this file change to the other cl as well then I will have to add back mitsuru again.

    The method was never intended to used outside signin/* code either. I think it was added by mistake. It will not longer be possible to use that method after the next cl.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sylvain Defresne
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idaddbfc913e16bd62486cd7aa8b79b28a1c1637f
    Gerrit-Change-Number: 7046430
    Gerrit-PatchSet: 21
    Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Comment-Date: Tue, 04 Nov 2025 13:56:12 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sylvain Defresne (Gerrit)

    unread,
    Nov 5, 2025, 9:01:54 AM (21 hours ago) Nov 5
    to Tanmoy Mollik, Boris Sazonov, Mitsuru Oshima, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
    Attention needed from Mitsuru Oshima and Tanmoy Mollik

    Sylvain Defresne voted and added 2 comments

    Votes added by Sylvain Defresne

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 21 (Latest):
    Sylvain Defresne . resolved

    lgtm

    File chromeos/ash/components/boca/babelorca/oauth_token_fetcher.cc
    Line 108, Patchset 18: << static_cast<int>(oauth_consumer_id_)
    Sylvain Defresne . resolved

    It looks like this is unrelated to moving the files.

    Please extract this to a separate CL.

    Tanmoy Mollik

    This method will no longer be available publically. If i move it in a different cl then I will have to add Mitsuru again for review. To avoid back and forth I would like to keep this change in this cl if it's okay with you.

    Sylvain Defresne

    I don't understand.

    Moving files around shouldn't change visibility of a method/function.

    Tanmoy Mollik

    I meant in the following cl it will no longer be available. I have moved the subclasses and signin code changes to a different cl like you requested. It will no longer need review from you or Mitsuru. If i move this file change to the other cl as well then I will have to add back mitsuru again.

    The method was never intended to used outside signin/* code either. I think it was added by mistake. It will not longer be possible to use that method after the next cl.

    Sylvain Defresne

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mitsuru Oshima
    • Tanmoy Mollik
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idaddbfc913e16bd62486cd7aa8b79b28a1c1637f
    Gerrit-Change-Number: 7046430
    Gerrit-PatchSet: 21
    Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Attention: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Comment-Date: Wed, 05 Nov 2025 14:01:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sylvain Defresne (Gerrit)

    unread,
    Nov 5, 2025, 9:02:38 AM (21 hours ago) Nov 5
    to Tanmoy Mollik, Boris Sazonov, Mitsuru Oshima, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
    Attention needed from Mitsuru Oshima and Tanmoy Mollik

    Sylvain Defresne voted and added 1 comment

    Votes added by Sylvain Defresne

    Code-Review+0

    1 comment

    Patchset-level comments
    Sylvain Defresne . resolved

    Tough you still need mitsuru +1 since you lost it at some point.

    Gerrit-Comment-Date: Wed, 05 Nov 2025 14:02:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mitsuru Oshima (Gerrit)

    unread,
    Nov 5, 2025, 7:47:45 PM (10 hours ago) Nov 5
    to Tanmoy Mollik, Sylvain Defresne, Boris Sazonov, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
    Attention needed from Tanmoy Mollik

    Mitsuru Oshima added 1 comment

    File chromeos/ash/components/boca/babelorca/oauth_token_fetcher.cc
    Line 108, Patchset 18 (Parent): << GetOAuthConsumerFromId(oauth_consumer_id_).GetName()
    Mitsuru Oshima . unresolved

    This changes the output. Is this temporary?

    Boris Sazonov

    I don't think so. Do you have any concerns about changing this log message? It's still pretty easy to understand which consumer has triggered the error.

    Mitsuru Oshima

    This was added for troubleshooting in case there is an issue, so you should make sure that owners are okay with this.

    Please add reviewer from chromeos/ash/components/boca/OWNERS. I can stamp once you've got +1.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tanmoy Mollik
    Gerrit-Comment-Date: Thu, 06 Nov 2025 00:47:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Boris Sazonov <bsaz...@chromium.org>
    Comment-In-Reply-To: Mitsuru Oshima <osh...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tanmoy Mollik (Gerrit)

    unread,
    3:21 AM (3 hours ago) 3:21 AM
    to April Zhou, Sylvain Defresne, Boris Sazonov, Mitsuru Oshima, Peter Beverloo, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, ios-web-view...@google.com, marq+...@chromium.org, droger+w...@chromium.org, extension...@chromium.org, oshima...@chromium.org, croissant-...@chromium.org, chromium-a...@chromium.org, zackha...@chromium.org, vasilii+watchlis...@chromium.org, armalhotra+a...@google.com, siyua+aut...@chromium.org, vakh+safe_br...@chromium.org, chrome-intelligence-te...@google.com, gcasto+w...@chromium.org, shgar+aut...@google.com, andysjl...@chromium.org, xinghui...@chromium.org, devtools...@chromium.org, osaul+aut...@google.com, druber...@chromium.org, browser-comp...@chromium.org, vinnypersky+...@google.com, nwoked...@chromium.org, siashah+au...@chromium.org, chrome-intell...@chromium.org, asvitkine...@chromium.org
    Attention needed from April Zhou

    Tanmoy Mollik added 1 comment

    Patchset-level comments
    Tanmoy Mollik . resolved

    Hi April, please take a look at chromeos/ash/components/boca/babelroca/* files.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • April Zhou
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Idaddbfc913e16bd62486cd7aa8b79b28a1c1637f
    Gerrit-Change-Number: 7046430
    Gerrit-PatchSet: 21
    Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Reviewer: April Zhou <apri...@google.com>
    Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
    Gerrit-Reviewer: Mitsuru Oshima <osh...@chromium.org>
    Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
    Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: April Zhou <apri...@google.com>
    Gerrit-Comment-Date: Thu, 06 Nov 2025 08:21:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages