Updating TabStripModel observer methods for consistency [chromium/src : main]

0 views
Skip to first unread message

David Pennington (Gerrit)

unread,
11:19 AM (12 hours ago) 11:19 AM
to Eshwar Stalin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, dibyapal+wa...@chromium.org, philli...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org, aashna...@google.com, asvitki...@chromium.org, boujan...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, dewitt...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jophba...@chromium.org, kenok...@google.com, kmg+...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, phoglun...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org
Attention needed from Eshwar Stalin

David Pennington added 3 comments

File chrome/browser/ui/tabs/tab_strip_model.cc
Line 1226, Patchset 9 (Parent): observer.SetTabNeedsAttentionAt(index, attention);
David Pennington . unresolved

SetTabNeedsAttentionAt can mean no longer needs attention, if changing the name maybe we can update to show that the attention is potentially not needed anymore.

Line 1236, Patchset 9 (Latest): observer.OnTabGroupNeedsAttention(group, attention);
David Pennington . unresolved

ditto above

File chrome/browser/ui/tabs/tab_strip_model_observer.cc
Line 376, Patchset 9 (Latest): int index) {}
David Pennington . unresolved

optional: move all the functions back to where they were before so we keep the blame history.

Open in Gerrit

Related details

Attention is currently required from:
  • Eshwar Stalin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3b3cf44f02ed6036282adb132fcfe204853d8a13
Gerrit-Change-Number: 7350719
Gerrit-PatchSet: 9
Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
Gerrit-Comment-Date: Tue, 30 Dec 2025 16:18:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Pennington (Gerrit)

unread,
11:19 AM (12 hours ago) 11:19 AM
to Eshwar Stalin, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, dibyapal+wa...@chromium.org, philli...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org, aashna...@google.com, asvitki...@chromium.org, boujan...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, dewitt...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jophba...@chromium.org, kenok...@google.com, kmg+...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, phoglun...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org
Attention needed from Eshwar Stalin

David Pennington voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eshwar Stalin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3b3cf44f02ed6036282adb132fcfe204853d8a13
Gerrit-Change-Number: 7350719
Gerrit-PatchSet: 9
Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Eshwar Stalin <est...@chromium.org>
Gerrit-Comment-Date: Tue, 30 Dec 2025 16:19:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eshwar Stalin (Gerrit)

unread,
5:58 PM (6 hours ago) 5:58 PM
to David Pennington, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, dibyapal+wa...@chromium.org, philli...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org, aashna...@google.com, asvitki...@chromium.org, boujan...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, dewitt...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jophba...@chromium.org, kenok...@google.com, kmg+...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, phoglun...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org

Eshwar Stalin added 3 comments

File chrome/browser/ui/tabs/tab_strip_model.cc
Line 1226, Patchset 9 (Parent): observer.SetTabNeedsAttentionAt(index, attention);
David Pennington . resolved

SetTabNeedsAttentionAt can mean no longer needs attention, if changing the name maybe we can update to show that the attention is potentially not needed anymore.

Eshwar Stalin

Done

Line 1236, Patchset 9: observer.OnTabGroupNeedsAttention(group, attention);
David Pennington . resolved

ditto above

Eshwar Stalin

Done

File chrome/browser/ui/tabs/tab_strip_model_observer.cc
Line 376, Patchset 9: int index) {}
David Pennington . resolved

optional: move all the functions back to where they were before so we keep the blame history.

Eshwar Stalin

I think keeping related things together is better (even if we lose the blame history), so will keep it as is.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3b3cf44f02ed6036282adb132fcfe204853d8a13
    Gerrit-Change-Number: 7350719
    Gerrit-PatchSet: 10
    Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Comment-Date: Tue, 30 Dec 2025 22:58:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Pennington <dpen...@chromium.org>
    satisfied_requirement
    open
    diffy

    Eshwar Stalin (Gerrit)

    unread,
    6:01 PM (6 hours ago) 6:01 PM
    to David Pennington, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, dibyapal+wa...@chromium.org, philli...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org, aashna...@google.com, asvitki...@chromium.org, boujan...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, dewitt...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jophba...@chromium.org, kenok...@google.com, kmg+...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, phoglun...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org

    Eshwar Stalin voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Tue, 30 Dec 2025 23:01:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    6:57 PM (5 hours ago) 6:57 PM
    to Eshwar Stalin, David Pennington, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, dibyapal+wa...@chromium.org, philli...@chromium.org, loyso...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, mgiuca...@chromium.org, webap...@microsoft.com, zelin+watch-we...@chromium.org, aashna...@google.com, asvitki...@chromium.org, boujan...@google.com, chfreme...@chromium.org, chrome-gr...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, chrstn...@google.com, dewitt...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, jasonrobe...@google.com, jdonnel...@chromium.org, jophba...@chromium.org, kenok...@google.com, kmg+...@google.com, mac-r...@chromium.org, mfoltz+wa...@chromium.org, mfoltz+wa...@chromium.org, omnibox-...@chromium.org, performance-m...@chromium.org, phoglun...@chromium.org, rayanka...@chromium.org, rmcelra...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    9 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
    Insertions: 3, Deletions: 3.

    @@ -912,12 +912,12 @@
       }
     }
     
    -void BrowserTabStripController::OnTabNeedsAttentionAt(int index,
    -                                                      bool attention) {
    +void BrowserTabStripController::OnTabNeedsAttentionChanged(int index,
    +                                                           bool attention) {
       tabstrip_->SetTabNeedsAttention(index, attention);
     }
     
    -void BrowserTabStripController::OnTabGroupNeedsAttention(
    +void BrowserTabStripController::OnTabGroupNeedsAttentionChanged(
         const tab_groups::TabGroupId& group,
         bool attention) {
       tabstrip_->SetTabGroupNeedsAttention(group, attention);
    ```
    ```
    The name of the file: chrome/browser/ui/tabs/tab_strip_model.cc
    Insertions: 2, Deletions: 2.

    @@ -1223,7 +1223,7 @@
       CHECK(ContainsIndex(index));
     
       for (auto& observer : observers_) {
    -    observer.OnTabNeedsAttentionAt(index, attention);
    +    observer.OnTabNeedsAttentionChanged(index, attention);
       }
     }
     
    @@ -1233,7 +1233,7 @@
       CHECK(group_model_->ContainsTabGroup(group));
     
       for (auto& observer : observers_) {
    -    observer.OnTabGroupNeedsAttention(group, attention);
    +    observer.OnTabGroupNeedsAttentionChanged(group, attention);
       }
     }
     
    ```
    ```
    The name of the file: chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
    Insertions: 3, Deletions: 3.

    @@ -156,9 +156,9 @@
                                   std::optional<tab_groups::TabGroupId> new_group,
                                   tabs::TabInterface* tab,
                                   int index) override;
    -  void OnTabNeedsAttentionAt(int index, bool attention) override;
    -  void OnTabGroupNeedsAttention(const tab_groups::TabGroupId& group,
    -                                bool attention) override;
    +  void OnTabNeedsAttentionChanged(int index, bool attention) override;
    +  void OnTabGroupNeedsAttentionChanged(const tab_groups::TabGroupId& group,
    +                                       bool attention) override;
       void OnSplitTabChanged(const SplitTabChange& change) override;
       void OnTabGroupFocusChanged(
           std::optional<tab_groups::TabGroupId> new_group_id,
    ```
    ```
    The name of the file: chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc
    Insertions: 3, Deletions: 2.

    @@ -510,8 +510,9 @@
       UpdateBrowserControlsStateShown(new_active_contents, /*animate=*/true);
     }
     
    -void TopControlsSlideControllerChromeOS::OnTabNeedsAttentionAt(int index,
    -                                                               bool attention) {
    +void TopControlsSlideControllerChromeOS::OnTabNeedsAttentionChanged(
    +    int index,
    +    bool attention) {
       UpdateBrowserControlsStateShown(/*web_contents=*/nullptr, /*animate=*/true);
     }
     
    ```
    ```
    The name of the file: chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h
    Insertions: 1, Deletions: 1.

    @@ -65,7 +65,7 @@
           TabStripModel* tab_strip_model,
           const TabStripModelChange& change,
           const TabStripSelectionChange& selection) override;
    -  void OnTabNeedsAttentionAt(int index, bool attention) override;
    +  void OnTabNeedsAttentionChanged(int index, bool attention) override;
     
       // display::DisplayObserver:
       void OnDisplayMetricsChanged(const display::Display& display,
    ```
    ```
    The name of the file: chrome/browser/ui/tabs/tab_strip_model_observer.cc
    Insertions: 3, Deletions: 2.

    @@ -366,7 +366,8 @@
     void TabStripModelObserver::OnTabBlockedStateChanged(tabs::TabInterface* tab,
                                                          int index) {}
     
    -void TabStripModelObserver::OnTabNeedsAttentionAt(int index, bool attention) {}
    +void TabStripModelObserver::OnTabNeedsAttentionChanged(int index,
    +                                                       bool attention) {}
     
     void TabStripModelObserver::TabGroupedStateChanged(
         TabStripModel* tab_strip_model,
    @@ -381,7 +382,7 @@
         std::optional<tab_groups::TabGroupId> new_focused_group_id,
         std::optional<tab_groups::TabGroupId> old_focused_group_id) {}
     
    -void TabStripModelObserver::OnTabGroupNeedsAttention(
    +void TabStripModelObserver::OnTabGroupNeedsAttentionChanged(
         const tab_groups::TabGroupId& group,
         bool attention) {}
     
    ```
    ```
    The name of the file: chrome/browser/ui/tabs/tab_strip_model_observer.h
    Insertions: 6, Deletions: 5.

    @@ -565,7 +565,7 @@
       // The specified tab at `index` requires the display of a UI indication to the
       // user that it needs their attention. The UI indication is set iff
       // `attention` is true.
    -  virtual void OnTabNeedsAttentionAt(int index, bool attention);
    +  virtual void OnTabNeedsAttentionChanged(int index, bool attention);
     
       // Called when the tab at `index` is added to the group with id `new_group` or
       // removed from a group with id `old_group`.
    @@ -587,10 +587,11 @@
           std::optional<tab_groups::TabGroupId> new_focused_group_id,
           std::optional<tab_groups::TabGroupId> old_focused_group_id);
     
    -  // Similar to SetTabNeedsAttentionAt but for Tab Groups. The UI indication is
    -  // set iff `attention` is true.
    -  virtual void OnTabGroupNeedsAttention(const tab_groups::TabGroupId& group,
    -                                        bool attention);
    +  // Similar to OnTabNeedsAttentionChanged but for Tab Groups. The UI indication
    +  // is set iff `attention` is true.
    +  virtual void OnTabGroupNeedsAttentionChanged(
    +      const tab_groups::TabGroupId& group,
    +      bool attention);
     
       // Notfies us when a Tab Group is added to the Tab Group Model.
       virtual void OnTabGroupAdded(const tab_groups::TabGroupId& group_id);
    ```

    Change information

    Commit message:
    Updating TabStripModel observer methods for consistency

    Renaming some of the functions for consistency. Also switching some of
    the functions from using content::WebContents to tabs::TabInterface to better align with the long term direction.
    Change-Id: I3b3cf44f02ed6036282adb132fcfe204853d8a13
    Commit-Queue: Eshwar Stalin <est...@chromium.org>
    Reviewed-by: David Pennington <dpen...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1563530}
    Files:
    • M chrome/browser/actor/ui/actor_ui_tab_controller_browsertest.cc
    • M chrome/browser/ash/boca/on_task/on_task_locked_session_window_tracker.cc
    • M chrome/browser/ash/boca/on_task/on_task_locked_session_window_tracker.h
    • M chrome/browser/content_index/content_index_browsertest.cc
    • M chrome/browser/devtools/global_confirm_info_bar.cc
    • M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
    • M chrome/browser/extensions/api/tabs/tabs_event_router.cc
    • M chrome/browser/extensions/api/tabs/tabs_event_router.h
    • M chrome/browser/glic/host/context/glic_pinned_tab_manager.cc
    • M chrome/browser/glic/host/context/glic_pinned_tab_manager.h
    • M chrome/browser/media/cast_mirroring_service_host_browsertest.cc
    • M chrome/browser/media/webrtc/webrtc_desktop_capture_browsertest.cc
    • M chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.cc
    • M chrome/browser/metrics/desktop_session_duration/audible_contents_tracker.h
    • M chrome/browser/performance_manager/decorators/helpers/page_live_state_decorator_helper.cc
    • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.cc
    • M chrome/browser/resource_coordinator/tab_lifecycle_unit_source.h
    • M chrome/browser/ui/ash/wm/snap_group_browsertest.cc
    • M chrome/browser/ui/ash/wm/tab_cluster_ui_client.cc
    • M chrome/browser/ui/ash/wm/tab_cluster_ui_client.h
    • M chrome/browser/ui/browser.cc
    • M chrome/browser/ui/browser.h
    • M chrome/browser/ui/browser_command_controller.cc
    • M chrome/browser/ui/browser_command_controller.h
    • M chrome/browser/ui/cocoa/tab_menu_bridge.h
    • M chrome/browser/ui/cocoa/tab_menu_bridge.mm
    • M chrome/browser/ui/tabs/tab_strip_api/events/tab_strip_event_recorder.cc
    • M chrome/browser/ui/tabs/tab_strip_api/events/tab_strip_event_recorder.h
    • M chrome/browser/ui/tabs/tab_strip_model.cc
    • M chrome/browser/ui/tabs/tab_strip_model.h
    • M chrome/browser/ui/tabs/tab_strip_model_browsertest.cc
    • M chrome/browser/ui/tabs/tab_strip_model_observer.cc
    • M chrome/browser/ui/tabs/tab_strip_model_observer.h
    • M chrome/browser/ui/tabs/tab_strip_model_unittest.cc
    • M chrome/browser/ui/views/extensions/extensions_menu_view.cc
    • M chrome/browser/ui/views/extensions/extensions_menu_view.h
    • M chrome/browser/ui/views/extensions/extensions_request_access_button.cc
    • M chrome/browser/ui/views/extensions/extensions_request_access_button.h
    • M chrome/browser/ui/views/extensions/extensions_toolbar_container_view_controller.cc
    • M chrome/browser/ui/views/extensions/extensions_toolbar_container_view_controller.h
    • M chrome/browser/ui/views/frame/browser_view.cc
    • M chrome/browser/ui/views/frame/browser_view.h
    • M chrome/browser/ui/views/frame/multi_contents_view_mini_toolbar.cc
    • M chrome/browser/ui/views/frame/multi_contents_view_mini_toolbar.h
    • M chrome/browser/ui/views/frame/scrim_view_controller.cc
    • M chrome/browser/ui/views/frame/scrim_view_controller.h
    • M chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.cc
    • M chrome/browser/ui/views/frame/top_controls_slide_controller_chromeos.h
    • M chrome/browser/ui/views/location_bar/custom_tab_bar_view.cc
    • M chrome/browser/ui/views/location_bar/custom_tab_bar_view.h
    • M chrome/browser/ui/views/location_bar/custom_tab_bar_view_browsertest.cc
    • M chrome/browser/ui/views/side_panel/reading_list/read_later_side_panel_web_view.cc
    • M chrome/browser/ui/views/side_panel/reading_list/read_later_side_panel_web_view.h
    • M chrome/browser/ui/views/tab_sharing/tab_sharing_ui_views.cc
    • M chrome/browser/ui/views/tab_sharing/tab_sharing_ui_views.h
    • M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
    • M chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
    • M chrome/browser/ui/views/tabs/vertical/root_tab_collection_node.cc
    • M chrome/browser/ui/views/tabs/vertical/root_tab_collection_node.h
    • M chrome/browser/ui/web_applications/web_app_ui_manager_impl.cc
    • M chrome/browser/ui/web_applications/web_app_ui_manager_impl.h
    • M chrome/browser/ui/webui/tab_search/tab_search_page_handler.cc
    • M chrome/browser/ui/webui/tab_search/tab_search_page_handler.h
    • M chrome/browser/ui/webui/tab_strip/tab_strip_page_handler.cc
    • M chrome/browser/ui/webui/tab_strip/tab_strip_page_handler.h
    • M chrome/browser/ui/webui/tab_strip_internals/tab_strip_internals_observer.cc
    • M chrome/browser/ui/webui/tab_strip_internals/tab_strip_internals_observer.h
    Change size: L
    Delta: 67 files changed, 387 insertions(+), 425 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by David Pennington
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3b3cf44f02ed6036282adb132fcfe204853d8a13
    Gerrit-Change-Number: 7350719
    Gerrit-PatchSet: 11
    Gerrit-Owner: Eshwar Stalin <est...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Pennington <dpen...@chromium.org>
    Gerrit-Reviewer: Eshwar Stalin <est...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages