Remove default arguments on virtual functions in WebContents [chromium/src : main]

0 views
Skip to first unread message

Avi Drissman (Gerrit)

unread,
Jul 2, 2024, 2:11:47 PMJul 2
to Avi Drissman, findit...@appspot.gserviceaccount.com, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, Rijubrata Bhaumik, android-web...@chromium.org, alexmo...@chromium.org, blundell+...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dominickn+wat...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, pdf-r...@chromium.org
Attention needed from Jayson Adams

Avi Drissman voted and added 1 comment

Votes added by Avi Drissman

Auto-Submit+1
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Avi Drissman . resolved

Jayson, a mechanical cleanup to conform to the style guide. OO because it is purely mechanical and a change to the API.

Open in Gerrit

Related details

Attention is currently required from:
  • Jayson Adams
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I029839f7652dadaa486afee072fe8e3b623a8ee7
Gerrit-Change-Number: 5665092
Gerrit-PatchSet: 3
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Jayson Adams <shr...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Jayson Adams <shr...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 18:11:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jayson Adams (Gerrit)

unread,
Jul 2, 2024, 5:21:05 PMJul 2
to Avi Drissman, findit...@appspot.gserviceaccount.com, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, Rijubrata Bhaumik, android-web...@chromium.org, alexmo...@chromium.org, blundell+...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dominickn+wat...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, pdf-r...@chromium.org
Attention needed from Avi Drissman

Jayson Adams voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Avi Drissman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I029839f7652dadaa486afee072fe8e3b623a8ee7
Gerrit-Change-Number: 5665092
Gerrit-PatchSet: 3
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Jayson Adams <shr...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Avi Drissman <a...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 21:20:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 2, 2024, 5:24:53 PMJul 2
to Avi Drissman, findit...@appspot.gserviceaccount.com, AyeAye, chromium...@chromium.org, devtools...@chromium.org, Permissions Reviews, Rijubrata Bhaumik, android-web...@chromium.org, alexmo...@chromium.org, blundell+...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, dominickn+wat...@chromium.org, dtraino...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org, pdf-r...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Remove default arguments on virtual functions in WebContents

Default arguments on virtual functions are banned by the style guide.
Remove them and update all callers to provide them.
Bug: none
Change-Id: I029839f7652dadaa486afee072fe8e3b623a8ee7
Reviewed-by: Jayson Adams <shr...@chromium.org>
Auto-Submit: Avi Drissman <a...@chromium.org>
Owners-Override: Avi Drissman <a...@chromium.org>
Commit-Queue: Jayson Adams <shr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322419}
Files:
  • M android_webview/browser/find_helper.cc
  • M chrome/browser/devtools/devtools_window.cc
  • M chrome/browser/file_system_access/chrome_file_system_access_permission_context.cc
  • M chrome/browser/long_screenshots/long_screenshots_tab_service.cc
  • M chrome/browser/paint_preview/paint_preview_browsertest.cc
  • M chrome/browser/paint_preview/services/paint_preview_tab_service.cc
  • M chrome/browser/pdf/pdf_find_request_manager_browsertest.cc
  • M chrome/browser/renderer_context_menu/render_view_context_menu.cc
  • M chrome/browser/ui/browser.cc
  • M chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
  • M chrome/browser/ui/exclusive_access/fullscreen_controller_state_unittest.cc
  • M chrome/browser/ui/thumbnails/thumbnail_tab_helper.cc
  • M chrome/browser/ui/views/permissions/chip/chip_controller.cc
  • M chrome/browser/ui/views/permissions/permission_prompt_bubble.cc
  • M components/find_in_page/find_tab_helper.cc
  • M components/paint_preview/browser/paint_preview_base_service.cc
  • M content/browser/devtools/protocol/emulation_handler.cc
  • M content/browser/download/mhtml_generation_browsertest.cc
  • M content/browser/file_system_access/file_system_access_manager_impl.cc
  • M content/browser/find_request_manager_browsertest.cc
  • M content/browser/media/capture/web_contents_frame_tracker.cc
  • M content/browser/media/forwarding_audio_stream_factory.cc
  • M content/browser/web_contents/web_contents_impl.cc
  • M content/browser/web_contents/web_contents_impl.h
  • M content/browser/web_contents/web_contents_impl_browsertest.cc
  • M content/browser/web_contents/web_contents_impl_unittest.cc
  • M content/public/browser/web_contents.h
Change size: M
Delta: 27 files changed, 126 insertions(+), 106 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I029839f7652dadaa486afee072fe8e3b623a8ee7
Gerrit-Change-Number: 5665092
Gerrit-PatchSet: 4
Gerrit-Owner: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages