Update Context Selection Agent preamble [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Nikolay Vitkov (Gerrit)
12:51 PM (2 hours ago) 12:51 PM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Nikolay Vitkov voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
12:55 PM (2 hours ago) 12:55 PM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Jack Franklin added 2 comments![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 2 (Latest):
The proved a better requery of the model.Jack Franklin . unresolved
nit: a couple of typos - "the proved" and "requery" ?
File front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
Line 57, Patchset 2 (Latest):
* The only available are type \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.Jack Franklin . unresolved
The only available types are?
Related details
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
12:55 PM (2 hours ago) 12:55 PM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Jack Franklin . resolved
lgtm - please ensure it is updated on the server side, th!
Related details
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
12:56 PM (2 hours ago) 12:56 PM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov
Jack Franklin added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jack Franklin . resolved
lgtm - please ensure it is updated on the server side, th!
Jack Franklin
thanks*! 😊
Related details
Attention is currently required from:
- Nikolay Vitkov
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
1:01 PM (2 hours ago) 1:01 PM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Nikolay Vitkov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nikolay Vitkov
| Auto-Submit | +1 |
| Commit-Queue | +2 |
2 comments
Commit Message
nit: a couple of typos - "the proved" and "requery" ?
Nikolay Vitkov
Done
File front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
Line 57, Patchset 2:
* The only available are type \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.Jack Franklin . resolved
The only available types are?
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
1:02 PM (2 hours ago) 1:02 PM
to Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Jack Franklin . resolved
Jack Franklinlgtm - please ensure it is updated on the server side, th!
thanks*! 😊
Nikolay Vitkov
Yes there is a separate bug so I don't forget 😂
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
1:58 PM (1 hour ago) 1:58 PM
to Nikolay Vitkov, Jack Franklin, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
Insertions: 1, Deletions: 1.
@@ -54,7 +54,7 @@
* **CRITICAL** NEVER output text before a function call. Always do a function call first.
* **CRITICAL** You are a debugging assistant in DevTools. NEVER provide answers to questions of unrelated topics such as legal advice, financial advice, personal opinions, medical advice, religion, race, politics, sexuality, gender, or any other non web-development topics. Answer "Sorry, I can't answer that. I'm best at questions about debugging web pages." to such questions.
* **CRITICAL** When referring to DevTools resource output a markdown link to the object using the format \`[<text>](#<type>-<ID>)\`.
-* The only available are type \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.
+* The only available types are \`#req\` for network request and \`#file\` for source files. Only use ID inside the link, never ask about user selecting by ID.
`;
/**
```
Change information
Commit message:
Update Context Selection Agent preamble
This makes the model more likely to try different function calls before giving up and giving a generic answer.
It also makes is less likely to link non linkable resources like panels [Network](#panels-network).
Fixed: 485827504
Change-Id: I3dd005b26573953ef92d62ebc284094ee3dec2db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7628382
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Files:
- M front_end/models/ai_assistance/agents/ContextSelectionAgent.ts
Change size: XS
Delta: 1 file changed, 5 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jack Franklin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages