Implement new starter badge triggers [devtools/devtools-frontend : main]
Natallia Harshunova (Gerrit)
Natallia Harshunova voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Ergün Erdoğmuş
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Ergün Erdoğmuş added 5 comments![]( "Open in Gerrit")
"../breakpoints/*",After moving the recording of setting a breakpoint to `DebuggerPlugin`, we don't need this visibility change anymore. (and we don't need the BUILD.gn change in `models/breakpoints/BUILD.gn` as well)
See the comment: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6973510/comment/cd117db8_8ffe3bc8/
BadgeAction.RECORDER_PANEL_START_CLICKED,(Very nit): Let's unify the naming of these enums:
- `BREAKPOINT_ADDED`
- `CONSOLE_PROMPT_EXECUTED`
- `PERFORMANCE_RECORDING_STARTED`
- `NETWORK_SPEED_THROTTLED`
- `RECORDER_RECORDING_STARTED`
WDYT?
Badges.UserBadges.instance().recordAction(Badges.BadgeAction.ADD_BREAKPOINT);Let's move this action recording to the `DebuggerPlugin.setBreakpoint` method. This aligns the recording with the explicit user action from the UI and maintains better separation of concerns.
We want to record this action when the user explicitly sets a breakpoint and `setBreakpoint` of the model is used in different places as well (e.g. restoring breakpoints after refresh)
Badges.UserBadges.instance().recordAction(Badges.BadgeAction.THROTTLING_NETWORK_SPEED);Let's not record this action on the "View" layer but record it in the `onSelect` method definition in `performUpdate`.
The reason is, we want "DEFAULT_VIEW" to only concern itself with the rendering. All kinds of business logic (e.g. what happens in the system after something is clicked) is handled outside of the view.
'console-prompt-executed',We don't need to add these values to here since they are not part of the VE logging system.
Related details
- Natallia Harshunova
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Natallia Harshunova (Gerrit)
Natallia Harshunova voted and added 5 comments![]( "Open in Gerrit")
Votes added by Natallia Harshunova
| Commit-Queue | +1 |
5 comments
After moving the recording of setting a breakpoint to `DebuggerPlugin`, we don't need this visibility change anymore. (and we don't need the BUILD.gn change in `models/breakpoints/BUILD.gn` as well)
See the comment: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6973510/comment/cd117db8_8ffe3bc8/
Done
(Very nit): Let's unify the naming of these enums:
- `BREAKPOINT_ADDED`
- `CONSOLE_PROMPT_EXECUTED`
- `PERFORMANCE_RECORDING_STARTED`
- `NETWORK_SPEED_THROTTLED`
- `RECORDER_RECORDING_STARTED`
WDYT?
Done
Badges.UserBadges.instance().recordAction(Badges.BadgeAction.ADD_BREAKPOINT);Let's move this action recording to the `DebuggerPlugin.setBreakpoint` method. This aligns the recording with the explicit user action from the UI and maintains better separation of concerns.
We want to record this action when the user explicitly sets a breakpoint and `setBreakpoint` of the model is used in different places as well (e.g. restoring breakpoints after refresh)
Done
Badges.UserBadges.instance().recordAction(Badges.BadgeAction.THROTTLING_NETWORK_SPEED);Let's not record this action on the "View" layer but record it in the `onSelect` method definition in `performUpdate`.
The reason is, we want "DEFAULT_VIEW" to only concern itself with the rendering. All kinds of business logic (e.g. what happens in the system after something is clicked) is handled outside of the view.
Done
We don't need to add these values to here since they are not part of the VE logging system.
- Ergün Erdoğmuş
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ergün Erdoğmuş (Gerrit)
Ergün Erdoğmuş voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ergün Erdoğmuş
| Code-Review | +1 |
2 comments
Badges.UserBadges.instance().recordAction(Badges.BadgeAction.CONSOLE_PROMPT_EXECUTED);Let's move this right below ` Host.userMetrics.actionTaken(Host.UserMetrics.Action.CommandEvaluatedInConsolePanel);` WDYT?
Related details
- Natallia Harshunova
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Natallia Harshunova (Gerrit)
Natallia Harshunova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Natallia Harshunova
| Commit-Queue | +1 |
1 comment
Badges.UserBadges.instance().recordAction(Badges.BadgeAction.CONSOLE_PROMPT_EXECUTED);Let's move this right below ` Host.userMetrics.actionTaken(Host.UserMetrics.Action.CommandEvaluatedInConsolePanel);` WDYT?
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Natallia Harshunova (Gerrit)
Natallia Harshunova voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: front_end/panels/console/ConsolePrompt.ts
Insertions: 1, Deletions: 1.
@@ -475,6 +475,7 @@
void this.evaluateCommandInConsole(executionContext, message, expression, useCommandLineAPI);
if (ConsolePanel.instance().isShowing()) {
Host.userMetrics.actionTaken(Host.UserMetrics.Action.CommandEvaluatedInConsolePanel);
+ Badges.UserBadges.instance().recordAction(Badges.BadgeAction.CONSOLE_PROMPT_EXECUTED);
}
}
}
@@ -492,7 +493,6 @@
await executionContext.target()
.model(SDK.ConsoleModel.ConsoleModel)
?.evaluateCommandInConsole(executionContext, message, expression, useCommandLineAPI);
- Badges.UserBadges.instance().recordAction(Badges.BadgeAction.CONSOLE_PROMPT_EXECUTED);
}
private async substituteNames(expression: string, mapping: Map<string, string|null>): Promise<string> {
```
Change information
Implement new starter badge triggers
This CL implements five new starter badge triggers designed to guide
new users through key DevTools features.
The new triggers are for:
* Setting a breakpoint in the Sources panel.
* Executing a command in the Console.
* Starting a recording in the Performance panel.
* Throttling network speed in the Network panel.
* Starting a new recording in the Recorder panel.
- M front_end/models/badges/Badge.ts
- M front_end/models/badges/StarterBadge.ts
- M front_end/panels/console/ConsolePrompt.ts
- M front_end/panels/mobile_throttling/BUILD.gn
- M front_end/panels/mobile_throttling/NetworkThrottlingSelector.ts
- M front_end/panels/recorder/components/CreateRecordingView.ts
- M front_end/panels/sources/DebuggerPlugin.ts
- M front_end/panels/timeline/TimelinePanel.ts
Code-Review: +1 by Ergün Erdoğmuş
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |