Improve typing of DevTools experiments [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Wolfgang Beyer (Gerrit)
Jan 19, 2026, 10:35:44 AM (20 hours ago) Jan 19
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Wolfgang Beyer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Wolfgang Beyer
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
2:11 AM (4 hours ago) 2:11 AM
to Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Wolfgang Beyer
Alex Rudenko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Rudenko
| Code-Review | +1 |
1 comment
File front_end/ui/visual_logging/KnownContextValues.ts
Line 3537, Patchset 5 (Latest):
'show-option-to-expose-internals-in-heap-snapshot',Alex Rudenko . unresolved
is it going to affect ve logging?
Related details
Attention is currently required from:
- Wolfgang Beyer
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
3:44 AM (2 hours ago) 3:44 AM
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Wolfgang Beyer added 1 comment![]( "Open in Gerrit")
File front_end/ui/visual_logging/KnownContextValues.ts
Line 3537, Patchset 5 (Latest):
'show-option-to-expose-internals-in-heap-snapshot',Alex Rudenko . unresolved
is it going to affect ve logging?
Wolfgang Beyer
Good question, by fixing the typo in the experiment name, the name of the VE event will also change and create a discontinuity in the corresponding data. This is not the case for UMA tracking of experiments, where the corrected string is mapped to the same numeric value as before.
I'm leaning towards the opinion that fixing the typo is worth the small discontinuity in VE data, but I wouldn't have a problem with keeping the name as it is, since that's orthogonal to the rest of the CL.
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
4:37 AM (2 hours ago) 4:37 AM
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Wolfgang Beyer voted and added 1 comment![]( "Open in Gerrit")
Votes added by Wolfgang Beyer
| Auto-Submit | +1 |
| Commit-Queue | +2 |
1 comment
File front_end/ui/visual_logging/KnownContextValues.ts
Wolfgang Beyeris it going to affect ve logging?
Good question, by fixing the typo in the experiment name, the name of the VE event will also change and create a discontinuity in the corresponding data. This is not the case for UMA tracking of experiments, where the corrected string is mapped to the same numeric value as before.
I'm leaning towards the opinion that fixing the typo is worth the small discontinuity in VE data, but I wouldn't have a problem with keeping the name as it is, since that's orthogonal to the rest of the CL.
Wolfgang Beyer
Done
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
5:08 AM (1 hour ago) 5:08 AM
to Wolfgang Beyer, Alex Rudenko, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Improve typing of DevTools experiments
Bug: 464173047
Change-Id: Iec26b9e20954274eca190b410557921fbef270ab
Auto-Submit: Wolfgang Beyer <wo...@chromium.org>
Commit-Queue: Wolfgang Beyer <wo...@chromium.org>
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Files:
- M front_end/core/host/UserMetrics.ts
- M front_end/core/root/Runtime.test.ts
- M front_end/core/root/Runtime.ts
- M front_end/core/sdk/CSSProperty.ts
- M front_end/core/sdk/CookieModel.ts
- M front_end/core/sdk/DOMModel.ts
- M front_end/core/sdk/OverlayModel.ts
- M front_end/entrypoints/main/MainImpl.ts
- M front_end/models/issues_manager/ContrastCheckTrigger.ts
- M front_end/models/source_map_scopes/NamesResolver.test.ts
- M front_end/panels/accessibility/AccessibilitySidebarView.ts
- M front_end/panels/application/FrameDetailsView.ts
- M front_end/panels/application/components/ReportsGrid.ts
- M front_end/panels/css_overview/CSSOverviewCompletedView.ts
- M front_end/panels/css_overview/CSSOverviewModel.ts
- M front_end/panels/elements/ElementsPanel.test.ts
- M front_end/panels/elements/ElementsPanel.ts
- M front_end/panels/elements/StylePropertiesSection.ts
- M front_end/panels/elements/StylePropertyTreeElement.ts
- M front_end/panels/profiler/HeapProfileView.ts
- M front_end/panels/profiler/HeapSnapshotView.ts
- M front_end/panels/sources/NavigatorView.ts
- M front_end/panels/sources/SourcesPanel.ts
- M front_end/panels/timeline/CompatibilityTracksAppender.ts
- M front_end/panels/timeline/ThreadAppender.ts
- M front_end/panels/timeline/TimelineController.ts
- M front_end/panels/timeline/TimelinePanel.ts
- M front_end/panels/timeline/track_appenders/ThreadAppender.test.ts
- M front_end/testing/RuntimeHelpers.ts
- M front_end/ui/components/panel_feedback/PreviewToggle.test.ts
- M front_end/ui/components/panel_feedback/PreviewToggle.ts
- M front_end/ui/components/settings/SettingCheckbox.test.ts
- M front_end/ui/components/settings/SettingDeprecationWarning.test.ts
- M front_end/ui/legacy/components/color_picker/ContrastDetails.ts
- M front_end/ui/legacy/components/color_picker/ContrastOverlay.ts
- M front_end/ui/visual_logging/KnownContextValues.ts
- M test/e2e/memory/memory.test.ts
Change size: L
Delta: 37 files changed, 152 insertions(+), 118 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages