[ts_library_split] Add tsconfig.json compiler configuration sub-target [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
5:31 AM (4 hours ago) 5:31 AM
to devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, Philip Pfaffe, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
5:43 AM (4 hours ago) 5:43 AM
to Simon Zünd, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Philip Pfaffe voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philip Pfaffe
| Code-Review | +1 |
1 comment
File scripts/build/typescript/ts_library_split.gni
Line 234, Patchset 1 (Latest):
# Sub-target 3: Generate tsconfig.json via GN generated_filePhilip Pfaffe . unresolved
also not a very useful comment
Related details
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
5:53 AM (4 hours ago) 5:53 AM
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Simon Zünd voted and added 1 comment![]( "Open in Gerrit")
Votes added by Simon Zünd
| Commit-Queue | +2 |
1 comment
File scripts/build/typescript/ts_library_split.gni
Line 234, Patchset 1:
# Sub-target 3: Generate tsconfig.json via GN generated_filePhilip Pfaffe . resolved
also not a very useful comment
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
6:25 AM (3 hours ago) 6:25 AM
to Simon Zünd, Philip Pfaffe, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: scripts/build/typescript/ts_library_split.gni
Insertions: 2, Deletions: 1.
@@ -231,7 +231,8 @@
}
}
- # Sub-target 3: Generate tsconfig.json via GN generated_file
+ # Sub-target 3: Generate tsconfig.json used by sub-target 4 for
+ # actual type-checking and JS transpilation.
generated_file(_tsconfig_target) {
outputs = [ _tsconfig_file ]
output_conversion = "json"
```
Change information
Commit message:
[ts_library_split] Add tsconfig.json compiler configuration sub-target
Adds Sub-target 3 (${target_name}_tsconfig) generating ${target_name}-tsconfig.json
via GN generated_file containing disableSourceOfProjectReferenceRedirect and
locally scoped rootDir.
R=pfa...@chromium.org
TAG=agy
CONV=8700c1d3-4690-496f-abb1-8ea8524aea8b
Bug: 547522497
Change-Id: I5ae075508f1225df71699aaec6f588efa653f843
Commit-Queue: Simon Zünd <szu...@chromium.org>
Reviewed-by: Philip Pfaffe <pfa...@chromium.org>
Files:
- M scripts/build/typescript/ts_library_split.gni
Change size: M
Delta: 1 file changed, 56 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages