Support legacy UI.ReportView in the imperative API lint rule [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Danil Somsikov (Gerrit)

unread,
4:46 AM (4 hours ago) 4:46 AM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Danil Somsikov voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2ca4e7c2c4f08741f6efd461251ac5830e26d0a7
Gerrit-Change-Number: 7205977
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 09:46:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nikolay Vitkov (Gerrit)

unread,
4:58 AM (4 hours ago) 4:58 AM
to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Nikolay Vitkov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2ca4e7c2c4f08741f6efd461251ac5830e26d0a7
Gerrit-Change-Number: 7205977
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 09:58:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Danil Somsikov (Gerrit)

unread,
5:41 AM (3 hours ago) 5:41 AM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org

Danil Somsikov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2ca4e7c2c4f08741f6efd461251ac5830e26d0a7
Gerrit-Change-Number: 7205977
Gerrit-PatchSet: 2
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 10:41:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
6:03 AM (3 hours ago) 6:03 AM
to Danil Somsikov, Nikolay Vitkov, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Support legacy UI.ReportView in the imperative API lint rule
Bug: 407749531
Change-Id: I2ca4e7c2c4f08741f6efd461251ac5830e26d0a7
Commit-Queue: Danil Somsikov <d...@chromium.org>
Auto-Submit: Danil Somsikov <d...@chromium.org>
Reviewed-by: Nikolay Vitkov <nvi...@chromium.org>
Files:
  • M scripts/eslint_rules/lib/no-imperative-dom-api.ts
  • M scripts/eslint_rules/lib/no-imperative-dom-api/dom-api.ts
  • A scripts/eslint_rules/lib/no-imperative-dom-api/report-view.ts
  • M scripts/eslint_rules/tests/no-imperative-dom-api.test.ts
Change size: M
Delta: 4 files changed, 200 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Nikolay Vitkov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I2ca4e7c2c4f08741f6efd461251ac5830e26d0a7
Gerrit-Change-Number: 7205977
Gerrit-PatchSet: 3
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages