[node] Fix node_app entrypoint [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
Nov 4, 2025, 1:48:43 AM (3 days ago) Nov 4
to Devtools-frontend LUCI CQ, Benedikt Meurer, devtools-rev...@chromium.org
Attention needed from Benedikt Meurer
Simon Zünd voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Benedikt Meurer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Nov 4, 2025, 2:15:25 AM (3 days ago) Nov 4
to Simon Zünd, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Simon Zünd
Benedikt Meurer voted![]( "Open in Gerrit")
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Nov 4, 2025, 2:17:02 AM (3 days ago) Nov 4
to Simon Zünd, Benedikt Meurer, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[node] Fix node_app entrypoint
The CL https://crrev.com/c/7061850 weakend the condition on how we
can create root targets. It missed the fact that node_app for Node.js
creates child targets with no session IDs.
We fix this by not passing in a parent target. We must not use the
connection from the parent anyway, and instead use the NodeConnection.
R=bme...@chromium.org
Fixed: 457549946
Change-Id: I1e72cb2f0708fa8b2c361cc58101dc21119cd145
Commit-Queue: Benedikt Meurer <bme...@chromium.org>
Auto-Submit: Simon Zünd <szu...@chromium.org>
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Files:
- M front_end/entrypoints/node_app/NodeMain.ts
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Benedikt Meurer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages