[tracing] Add perfetto stubs and remove #if directives [v8/v8 : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Oct 10, 2025, 2:49:37 PMĀ (3 days ago)Ā Oct 10
to Camillo Bruni, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Camillo Bruni

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Camillo Bruni
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: v8/v8
Gerrit-Branch: main
Gerrit-Change-Id: Ib4bf7ea79f6348e59a870b474746f0ba80acd08b
Gerrit-Change-Number: 7030546
Gerrit-PatchSet: 2
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
Gerrit-CC: Fadi Meawad <fme...@chromium.org>
Gerrit-CC: Hannes Payer <hpa...@chromium.org>
Gerrit-Attention: Camillo Bruni <cbr...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 18:49:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Camillo Bruni (Gerrit)

unread,
Oct 13, 2025, 3:44:14 AMĀ (23 hours ago)Ā Oct 13
to Etienne Pierre-Doray, V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
Attention needed from Etienne Pierre-Doray

Camillo Bruni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib4bf7ea79f6348e59a870b474746f0ba80acd08b
    Gerrit-Change-Number: 7030546
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Oct 2025 07:43:51 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Oct 13, 2025, 8:58:07 AMĀ (17 hours ago)Ā Oct 13
    to Michael Lippautz, Camillo Bruni, V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Michael Lippautz

    Etienne Pierre-Doray added 1 comment

    Patchset-level comments
    Etienne Pierre-Doray . resolved

    +mlippautz@ for OWNER approval

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Michael Lippautz
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib4bf7ea79f6348e59a870b474746f0ba80acd08b
    Gerrit-Change-Number: 7030546
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Oct 2025 12:58:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Michael Lippautz (Gerrit)

    unread,
    Oct 13, 2025, 9:42:48 AMĀ (17 hours ago)Ā Oct 13
    to Etienne Pierre-Doray, Camillo Bruni, V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com
    Attention needed from Etienne Pierre-Doray

    Michael Lippautz voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib4bf7ea79f6348e59a870b474746f0ba80acd08b
    Gerrit-Change-Number: 7030546
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Mon, 13 Oct 2025 13:42:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Oct 13, 2025, 8:09:13 PMĀ (6 hours ago)Ā Oct 13
    to Michael Lippautz, Camillo Bruni, V8 LUCI CQ, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com

    Etienne Pierre-Doray voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib4bf7ea79f6348e59a870b474746f0ba80acd08b
    Gerrit-Change-Number: 7030546
    Gerrit-PatchSet: 2
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Fadi Meawad <fme...@chromium.org>
    Gerrit-CC: Hannes Payer <hpa...@chromium.org>
    Gerrit-Comment-Date: Tue, 14 Oct 2025 00:09:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    V8 LUCI CQ (Gerrit)

    unread,
    Oct 13, 2025, 8:46:05 PMĀ (6 hours ago)Ā Oct 13
    to Etienne Pierre-Doray, Michael Lippautz, Camillo Bruni, Fadi Meawad, Hannes Payer, alph+...@chromium.org, cbruni...@chromium.org, devtools-...@chromium.org, lpy+v8...@chromium.org, mlippau...@chromium.org, v8-re...@googlegroups.com

    V8 LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Add perfetto stubs and remove #if directives

    This CL adds perfetto stubs for common class and macros (not exhaustive)
    and removes now unnecessary #if directives.
    Change-Id: Ib4bf7ea79f6348e59a870b474746f0ba80acd08b
    Reviewed-by: Camillo Bruni <cbr...@chromium.org>
    Reviewed-by: Michael Lippautz <mlip...@chromium.org>
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103096}
    Files:
    • M src/heap/gc-tracer.cc
    • M src/heap/gc-tracer.h
    • M src/heap/heap.cc
    • M src/heap/heap.h
    • M src/tracing/trace-event-no-perfetto.h
    Change size: M
    Delta: 5 files changed, 99 insertions(+), 26 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Michael Lippautz, +1 by Camillo Bruni
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: v8/v8
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib4bf7ea79f6348e59a870b474746f0ba80acd08b
    Gerrit-Change-Number: 7030546
    Gerrit-PatchSet: 3
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Camillo Bruni <cbr...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages