[Console Insight Teaser] Add action for generating full insight [devtools/devtools-frontend : main]

[Alex Rudenko (Gerrit)]

Attention needed from Wolfgang Beyer

Alex Rudenko voted and added 2 comments

Votes added by Alex Rudenko

Code-Review

+1

2 comments

File front_end/panels/console/ConsoleInsightTeaser.test.ts

Line 82, Patchset 2 (Latest): getAction.restore();

Alex Rudenko . unresolved

IIRC sinon will restore all stubs in afterEarch so we do need to do it manually?

File front_end/panels/console/ConsoleInsightTeaser.ts

Line 92, Patchset 2 (Latest): <devtools-button

Alex Rudenko . unresolved

let's use the non .data= version, i.e., pass each attribute separately

Open in Gerrit

Related details

Attention is currently required from:

• Wolfgang Beyer

Submit Requirements:

• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: devtools/devtools-frontend

Gerrit-Branch: main

Gerrit-Change-Id: Ide348d99fca515c379d5862c2913c109dcb0b606

Gerrit-Change-Number: 7036457

Gerrit-PatchSet: 2

Gerrit-Owner: Wolfgang Beyer <wo...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Wolfgang Beyer <wo...@chromium.org>

Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Wolfgang Beyer <wo...@chromium.org>

Gerrit-Comment-Date: Mon, 13 Oct 2025 18:22:17 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes