DevTools: Implement Smart Card EstablishContext & Release Emulation [chromium/src : main]

0 views

Skip to first unread message

Andrey Kosyakov (Gerrit)

unread,

Dec 22, 2025, 7:43:26 PM (8 days ago) Dec 22

to Paulina Gacek, Zgroza (Luke) Klimek, Patryk Chodur, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org

Attention needed from Patryk Chodur, Paulina Gacek and Zgroza (Luke) Klimek

Andrey Kosyakov added 2 comments

File content/browser/devtools/protocol/smart_card_emulation_handler.cc

Line 93, Patchset 12 (Latest): return SmartCardError::kUnknown;

Andrey Kosyakov . unresolved

Passing value other then in enum should be treated as an error, we typically make the return type of these function to be `base::Expected<SmartCardError, protocol::Response>`, so it can return either a good value or an error code that would be sent to client.

Line 376, Patchset 12 (Latest): return DispatchResponse::ServerError("Request not found");

Andrey Kosyakov . unresolved

nit: here and below, this kind of errors is typically a client error than server's, so `DispatchResonse::InvalidParams(...)`

Open in Gerrit

Related details

Attention is currently required from:

Patryk Chodur
Paulina Gacek
Zgroza (Luke) Klimek

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Paulina Gacek (Gerrit)

unread,

Dec 29, 2025, 12:08:05 PM (yesterday) Dec 29

to Zgroza (Luke) Klimek, Patryk Chodur, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org

Attention needed from Patryk Chodur and Zgroza (Luke) Klimek

Paulina Gacek added 2 comments

File content/browser/devtools/protocol/smart_card_emulation_handler.cc

Line 93, Patchset 12: return SmartCardError::kUnknown;

Andrey Kosyakov . resolved

Passing value other then in enum should be treated as an error, we typically make the return type of these function to be `base::Expected<SmartCardError, protocol::Response>`, so it can return either a good value or an error code that would be sent to client.

Paulina Gacek

Done

Line 376, Patchset 12: return DispatchResponse::ServerError("Request not found");