Remove dead code and remove skipped tests [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Jul 3, 2026, 9:29:23 AM (yesterday) Jul 3
to Jack Franklin, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alex Rudenko voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
Jul 3, 2026, 9:34:27 AM (yesterday) Jul 3
to Alex Rudenko, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Alex Rudenko
Jack Franklin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jack Franklin
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Alex Rudenko
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Jul 3, 2026, 9:38:11 AM (yesterday) Jul 3
to Jack Franklin, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Alex Rudenko voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
Jul 3, 2026, 10:01:42 AM (yesterday) Jul 3
to Alex Rudenko, Jack Franklin, devtools-rev...@chromium.org
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove dead code and remove skipped tests
The code does not do anything right now so this CL is removing it and
the related skipped test in favor of crbug.com/41363012.
Bug: 41363012
Change-Id: I4568e9bd553e1adb4c1e8c123a2ac82382ab0bd7
Auto-Submit: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Alex Rudenko <alexr...@chromium.org>
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Files:
- M front_end/models/trace/handlers/ScreenshotsHandler.test.ts
- M front_end/models/trace/handlers/ScreenshotsHandler.ts
Change size: M
Delta: 2 files changed, 14 insertions(+), 86 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jack Franklin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages