Refactor AiAssistanceModel exports [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alex Rudenko (Gerrit)
Oct 13, 2025, 2:11:52 PM (12 hours ago) Oct 13
to Wolfgang Beyer, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Wolfgang Beyer
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Wolfgang Beyer
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
Oct 13, 2025, 2:12:44 PM (12 hours ago) Oct 13
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Wolfgang Beyer voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wolfgang Beyer (Gerrit)
Oct 13, 2025, 2:46:27 PM (12 hours ago) Oct 13
to Alex Rudenko, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Wolfgang Beyer voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Oct 13, 2025, 7:01:22 PM (7 hours ago) Oct 13
to Wolfgang Beyer, Alex Rudenko, devtools-rev...@chromium.org
Devtools-frontend LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: front_end/panels/timeline/components/insights/BaseInsightComponent.test.ts
Insertions: 2, Deletions: 2.
@@ -352,7 +352,7 @@
it('sets the context when the user clicks the button', async () => {
// @ts-expect-error: don't need real data.
- const focus = new AIAssistance.AgentFocus({});
+ const focus = new AIAssistance.AIContext.AgentFocus({});
updateHostConfig({
aidaAvailability: {
enabled: true,
@@ -393,7 +393,7 @@
frameId: '123',
} as const;
// @ts-expect-error: don't need real data.
- const focus = new AIAssistance.AgentFocus({parsedTrace: true, insight: mockInsight});
+ const focus = new AIAssistance.AIContext.AgentFocus({parsedTrace: true, insight: mockInsight});
UI.Context.Context.instance().setFlavor(AIAssistance.AIContext.AgentFocus, focus);
const component = await renderComponent({insightHasAISupport: true});
component.agentFocus = focus;
```
Change information
Commit message:
Refactor AiAssistanceModel exports
To prevent name collisions when exporting `Events` from multiple
classes.
Bug: 451537112
Change-Id: Ibc1d8e06fa64896131cd21fd06bb2064c80b7e84
Reviewed-by: Alex Rudenko <alexr...@chromium.org>
Commit-Queue: Wolfgang Beyer <wo...@chromium.org>
Files:
- M front_end/entrypoints/main/MainImpl.test.ts
- M front_end/entrypoints/main/MainImpl.ts
- M front_end/models/ai_assistance/AgentProject.test.ts
- M front_end/models/ai_assistance/AiHistoryStorage.test.ts
- M front_end/models/ai_assistance/BuiltInAi.test.ts
- M front_end/models/ai_assistance/ChangeManager.test.ts
- M front_end/models/ai_assistance/ConversationHandler.test.ts
- M front_end/models/ai_assistance/EvaluateAction.test.ts
- M front_end/models/ai_assistance/ExtensionScope.test.ts
- M front_end/models/ai_assistance/agents/AiAgent.test.ts
- M front_end/models/ai_assistance/agents/FileAgent.test.ts
- M front_end/models/ai_assistance/agents/NetworkAgent.test.ts
- M front_end/models/ai_assistance/agents/PatchAgent.test.ts
- M front_end/models/ai_assistance/agents/PerformanceAgent.test.ts
- M front_end/models/ai_assistance/agents/PerformanceAnnotationsAgent.test.ts
- M front_end/models/ai_assistance/agents/StylingAgent.test.ts
- M front_end/models/ai_assistance/ai_assistance.ts
- M front_end/models/ai_assistance/data_formatters/FileFormatter.test.ts
- M front_end/models/ai_assistance/data_formatters/NetworkRequestFormatter.test.ts
- M front_end/models/ai_assistance/data_formatters/PerformanceInsightFormatter.test.ts
- M front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.test.ts
- M front_end/models/ai_assistance/data_formatters/UnitFormatters.test.ts
- M front_end/models/ai_assistance/performance/AICallTree.test.ts
- M front_end/models/ai_assistance/performance/AIQueries.test.ts
- M front_end/panels/ai_assistance/AiAssistancePanel.test.ts
- M front_end/panels/ai_assistance/AiAssistancePanel.ts
- M front_end/panels/ai_assistance/PatchWidget.test.ts
- M front_end/panels/ai_assistance/PatchWidget.ts
- M front_end/panels/ai_assistance/components/ChatView.test.ts
- M front_end/panels/ai_assistance/components/ChatView.ts
- M front_end/panels/console/ConsoleViewMessage.ts
- M front_end/panels/console/PromptBuilder.ts
- M front_end/panels/settings/AISettingsTab.test.ts
- M front_end/panels/settings/AISettingsTab.ts
- M front_end/panels/timeline/TimelineFlameChartDataProvider.ts
- M front_end/panels/timeline/TimelineFlameChartView.test.ts
- M front_end/panels/timeline/TimelineFlameChartView.ts
- M front_end/panels/timeline/TimelinePanel.test.ts
- M front_end/panels/timeline/TimelinePanel.ts
- M front_end/panels/timeline/components/SidebarSingleInsightSet.ts
- M front_end/panels/timeline/components/insights/BaseInsightComponent.test.ts
- M front_end/panels/timeline/components/insights/BaseInsightComponent.ts
- M front_end/panels/timeline/overlays/OverlaysImpl.test.ts
- M front_end/panels/timeline/overlays/OverlaysImpl.ts
- M front_end/panels/timeline/overlays/components/EntryLabelOverlay.ts
Change size: XL
Delta: 45 files changed, 890 insertions(+), 802 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alex Rudenko
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages