Keren Zhu (Gerrit)

unread,

Feb 9, 2026, 9:04:26 PMFeb 9

to Jeffrey Yu, Chromium LUCI CQ, AyeAye, devtools...@chromium.org

Attention needed from Jeffrey Yu

Keren Zhu voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Jeffrey Yu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jeffrey Yu (Gerrit)

unread,

Feb 9, 2026, 9:06:07 PMFeb 9

to Colin Blundell, Keren Zhu, Chromium LUCI CQ, AyeAye, devtools...@chromium.org

Attention needed from Colin Blundell

Jeffrey Yu voted Auto-Submit+1

Auto-Submit

+1

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Feb 10, 2026, 3:24:24 AMFeb 10

to Jeffrey Yu, Colin Blundell, Keren Zhu, Chromium LUCI CQ, AyeAye, devtools...@chromium.org

Attention needed from Jeffrey Yu

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Jeffrey Yu

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 10, 2026, 3:44:24 AMFeb 10

to Jeffrey Yu, Colin Blundell, Keren Zhu, AyeAye, devtools...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Replace `std::unordered_set` with `absl::flat_hash_set`.

Also use string_view instead of string to avoid string copies.

Updating test and debug code (at lower priority) to round out the
migration, and update test code to match current Chromium recommended
best practices.

Bug: 473916362

Change-Id: I7ec87575c0bdb3a5188d68fd81dfeb9feb07eeb3

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7560373

Commit-Queue: Colin Blundell <blun...@chromium.org>

Auto-Submit: Jeffrey Yu <yu...@chromium.org>

Reviewed-by: Keren Zhu <kere...@chromium.org>

Reviewed-by: Colin Blundell <blun...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1582355}

Files:

M components/ui_devtools/views/page_agent_views.cc

Change size: S

Delta: 1 file changed, 18 insertions(+), 14 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Keren Zhu, +1 by Colin Blundell

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Replace `std::unordered_set` with `absl::flat_hash_set`. [chromium/src : main]

Keren Zhu (Gerrit)

Keren Zhu voted Code-Review+1

Related details

Jeffrey Yu (Gerrit)

Jeffrey Yu voted Auto-Submit+1

Related details

Colin Blundell (Gerrit)

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information