Add accessible label to override header button [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Sylvester Elorm Coch (Gerrit)

unread,
Dec 23, 2025, 3:29:20 AM (3 days ago) Dec 23
to Mathias Bynens, devtools-rev...@chromium.org

Sylvester Elorm Coch added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sylvester Elorm Coch . resolved

@mat...@chromium.org could you ptal, thanks!

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: If678d18c8e4a3c107204094b81fabd6270410b9a
Gerrit-Change-Number: 7304152
Gerrit-PatchSet: 2
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Mathias Bynens <mat...@chromium.org>
Gerrit-Comment-Date: Tue, 23 Dec 2025 08:29:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Mathias Bynens (Gerrit)

unread,
Dec 24, 2025, 4:23:21 AM (2 days ago) Dec 24
to Sylvester Elorm Coch, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch

Mathias Bynens voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sylvester Elorm Coch
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: If678d18c8e4a3c107204094b81fabd6270410b9a
Gerrit-Change-Number: 7304152
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Mathias Bynens <mat...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 09:23:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sylvester Elorm Coch (Gerrit)

unread,
Dec 24, 2025, 11:34:05 AM (2 days ago) Dec 24
to Mathias Bynens, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Sylvester Elorm Coch voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: If678d18c8e4a3c107204094b81fabd6270410b9a
Gerrit-Change-Number: 7304152
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Mathias Bynens <mat...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Wed, 24 Dec 2025 16:34:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Dec 24, 2025, 12:13:13 PM (2 days ago) Dec 24
to Sylvester Elorm Coch, Mathias Bynens, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Add accessible label to override header button

Issue:
Screen reader is not announcing the name for the 'Override Header' button located in the Header section of the Network tab.


Bug: 471095592
Change-Id: If678d18c8e4a3c107204094b81fabd6270410b9a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7304152
Commit-Queue: Sylvester Elorm Coch <elor...@microsoft.com>
Reviewed-by: Mathias Bynens <mat...@chromium.org>
Files:
  • M front_end/panels/network/components/HeaderSectionRow.ts
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mathias Bynens
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: If678d18c8e4a3c107204094b81fabd6270410b9a
Gerrit-Change-Number: 7304152
Gerrit-PatchSet: 4
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages