Guard AVIF decoding with enable_dav1d_decoder [chromium/src : main]

1 view
Skip to first unread message

Vignesh Venkat (Gerrit)

unread,
May 14, 2026, 5:08:39 PMMay 14
to chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org

Vignesh Venkat voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic7b84ae578f38aa9a9ee815761a5002125e20dda
Gerrit-Change-Number: 7850382
Gerrit-PatchSet: 1
Gerrit-Owner: Vignesh Venkat <vign...@google.com>
Gerrit-Reviewer: Vignesh Venkat <vign...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Thu, 14 May 2026 21:08:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vignesh Venkat (Gerrit)

unread,
May 14, 2026, 5:18:34 PMMay 14
to Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org

Vignesh Venkat voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic7b84ae578f38aa9a9ee815761a5002125e20dda
Gerrit-Change-Number: 7850382
Gerrit-PatchSet: 2
Gerrit-Owner: Vignesh Venkat <vign...@google.com>
Gerrit-Reviewer: Vignesh Venkat <vign...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Thu, 14 May 2026 21:18:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Wan-Teh Chang (Gerrit)

unread,
May 14, 2026, 6:40:42 PMMay 14
to Vignesh Venkat, Wan-Teh Chang, Rakina Zata Amni, Nico Weber, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org
Attention needed from Nico Weber, Rakina Zata Amni, Vignesh Venkat and mmenke

Wan-Teh Chang voted and added 1 comment

Votes added by Wan-Teh Chang

Code-Review+1

1 comment

Commit Message
Line 7, Patchset 2 (Latest):Guard AVIF decoding with enable_dav1d_decoder
Wan-Teh Chang . unresolved

I think the code would be clearer if we add `enable_avif_decoder` and `ENABLE_AVIF_DECODER` and use them (instead of `enable_dav1d_decoder` and `ENABLE_DAV1D_DECODER`) with AVIF.

Would that work?

Open in Gerrit

Related details

Attention is currently required from:
  • Nico Weber
  • Rakina Zata Amni
  • Vignesh Venkat
  • mmenke
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic7b84ae578f38aa9a9ee815761a5002125e20dda
    Gerrit-Change-Number: 7850382
    Gerrit-PatchSet: 2
    Gerrit-Owner: Vignesh Venkat <vign...@google.com>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Vignesh Venkat <vign...@google.com>
    Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
    Gerrit-CC: Dale Curtis <dalec...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: mmenke <mme...@chromium.org>
    Gerrit-Attention: Vignesh Venkat <vign...@google.com>
    Gerrit-Attention: mmenke <mme...@chromium.org>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Comment-Date: Thu, 14 May 2026 22:40:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vignesh Venkat (Gerrit)

    unread,
    May 14, 2026, 6:44:14 PMMay 14
    to Wan-Teh Chang, Rakina Zata Amni, Nico Weber, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org
    Attention needed from Nico Weber, Rakina Zata Amni and mmenke

    Vignesh Venkat added 1 comment

    Commit Message
    Line 7, Patchset 2 (Latest):Guard AVIF decoding with enable_dav1d_decoder
    Wan-Teh Chang . resolved

    I think the code would be clearer if we add `enable_avif_decoder` and `ENABLE_AVIF_DECODER` and use them (instead of `enable_dav1d_decoder` and `ENABLE_DAV1D_DECODER`) with AVIF.

    Would that work?

    Vignesh Venkat

    technically, yes. but we will still need the enable_dav1d_decoder flag to control whether or not dav1d is being built. so if we are to add a `enable_avif_decoder` flag, it will simply be an alias to `enable_dav1d_decoder`.

    so it is simpler to just gate AVIF decoding on dav1d availability since there is no reason to disable avif when dav1d is available.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nico Weber
    • Rakina Zata Amni
    • mmenke
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic7b84ae578f38aa9a9ee815761a5002125e20dda
      Gerrit-Change-Number: 7850382
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vignesh Venkat <vign...@google.com>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Vignesh Venkat <vign...@google.com>
      Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
      Gerrit-CC: Dale Curtis <dalec...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: mmenke <mme...@chromium.org>
      Gerrit-Attention: mmenke <mme...@chromium.org>
      Gerrit-Attention: Nico Weber <tha...@chromium.org>
      Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Comment-Date: Thu, 14 May 2026 22:43:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Wan-Teh Chang <w...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rakina Zata Amni (Gerrit)

      unread,
      May 15, 2026, 1:49:22 AMMay 15
      to Vignesh Venkat, Wan-Teh Chang, Nico Weber, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org
      Attention needed from Nico Weber, Vignesh Venkat and mmenke

      Rakina Zata Amni voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Nico Weber
      • Vignesh Venkat
      • mmenke
      Gerrit-Attention: Vignesh Venkat <vign...@google.com>
      Gerrit-Attention: mmenke <mme...@chromium.org>
      Gerrit-Attention: Nico Weber <tha...@chromium.org>
      Gerrit-Comment-Date: Fri, 15 May 2026 05:48:55 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nico Weber (Gerrit)

      unread,
      May 15, 2026, 4:25:35 PMMay 15
      to Vignesh Venkat, Nico Weber, Rakina Zata Amni, Wan-Teh Chang, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org
      Attention needed from Vignesh Venkat and mmenke

      Nico Weber voted and added 1 comment

      Votes added by Nico Weber

      Code-Review+1

      1 comment

      Patchset-level comments
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Vignesh Venkat
      • mmenke
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic7b84ae578f38aa9a9ee815761a5002125e20dda
      Gerrit-Change-Number: 7850382
      Gerrit-PatchSet: 2
      Gerrit-Owner: Vignesh Venkat <vign...@google.com>
      Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Reviewer: Vignesh Venkat <vign...@google.com>
      Gerrit-Reviewer: Wan-Teh Chang <w...@google.com>
      Gerrit-CC: Dale Curtis <dalec...@chromium.org>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-CC: mmenke <mme...@chromium.org>
      Gerrit-Attention: Vignesh Venkat <vign...@google.com>
      Gerrit-Attention: mmenke <mme...@chromium.org>
      Gerrit-Comment-Date: Fri, 15 May 2026 20:25:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Vignesh Venkat (Gerrit)

      unread,
      May 15, 2026, 4:26:23 PMMay 15
      to Nico Weber, Rakina Zata Amni, Wan-Teh Chang, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org
      Attention needed from mmenke

      Vignesh Venkat voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • mmenke
      Gerrit-Attention: mmenke <mme...@chromium.org>
      Gerrit-Comment-Date: Fri, 15 May 2026 20:26:13 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      May 15, 2026, 4:30:22 PMMay 15
      to Vignesh Venkat, Nico Weber, Rakina Zata Amni, Wan-Teh Chang, Dale Curtis, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, cblume+im...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, mbarowsky+watc...@chromium.org, net-r...@chromium.org, security-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Guard AVIF decoding with enable_dav1d_decoder

      The existing guards use enable_av1_decoder which may or may not
      be dav1d depending on hardware AV1 support. Whereas AVIF decoding
      is always done via dav1d and thus guarding it with enable_av1_decoder
      is incorrect.
      Bug: 507576499
      Change-Id: Ic7b84ae578f38aa9a9ee815761a5002125e20dda
      Reviewed-by: Nico Weber <tha...@chromium.org>
      Reviewed-by: Wan-Teh Chang <w...@google.com>
      Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
      Commit-Queue: Vignesh Venkat <vign...@google.com>
      Cr-Commit-Position: refs/heads/main@{#1631517}
      Files:
      • M chrome/android/chrome_public_apk_tmpl.gni
      • M chrome/android/java/AndroidManifest.xml
      • M chrome/browser/net/chrome_accept_header_browsertest.cc
      • M content/browser/network/accept_header_browsertest.cc
      • M content/common/content_constants_internal.h
      • M third_party/blink/common/loader/network_utils.cc
      • M third_party/blink/common/mime_util/mime_util.cc
      • M third_party/blink/common/mime_util/mime_util_unittest.cc
      • M third_party/blink/renderer/core/inspector/inspector_emulation_agent_test.cc
      • M third_party/blink/renderer/modules/webcodecs/image_decoder_external_test.cc
      • M third_party/blink/renderer/platform/BUILD.gn
      • M third_party/blink/renderer/platform/graphics/bitmap_image_metrics.cc
      • M third_party/blink/renderer/platform/graphics/bitmap_image_test.cc
      • M third_party/blink/renderer/platform/image-decoders/BUILD.gn
      • M third_party/blink/renderer/platform/image-decoders/image_decoder.cc
      • M third_party/blink/renderer/platform/image-decoders/image_decoder_test.cc
      Change size: M
      Delta: 16 files changed, 53 insertions(+), 51 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Rakina Zata Amni, +1 by Wan-Teh Chang, +1 by Nico Weber
       Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      


       Gerrit-MessageType: merged 
      

       Gerrit-Project: chromium/src 
      

       Gerrit-Branch: main 
      

       Gerrit-Change-Id: Ic7b84ae578f38aa9a9ee815761a5002125e20dda 
      

       Gerrit-Change-Number: 7850382 
      

       Gerrit-PatchSet: 3 
      

       Gerrit-Owner: Vignesh Venkat <vign...@google.com> 
      

       Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
      

       Gerrit-Reviewer: Nico Weber <tha...@chromium.org> 
      

       Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org> 
      

       Gerrit-Reviewer: Vignesh Venkat <vign...@google.com> 
      

       Gerrit-Reviewer: Wan-Teh Chang <w...@google.com> 
      

      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages