Add trace_id param to tick-sample [v8/v8 : main]
0 views
Skip to first unread message
Andres Olivares (Gerrit)
Jan 20, 2025, 1:08:45 PMJan 20
to Benedikt Meurer, Simon Zünd, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Benedikt Meurer and Simon Zünd
Andres Olivares added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Andres Olivares . resolved
PTAL. I was able to use V8::CollectSample to reliably get a sample right before a trace event in v8, however doing in Blink didn't end up with the same results. As such I decided to give it a shot at passing an id to the manually collected sample as a more robust way to assign stack traces to trace events
Related details
Attention is currently required from:
- Benedikt Meurer
- Simon Zünd
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Jan 21, 2025, 1:18:06 AMJan 21
to Andres Olivares, Benedikt Meurer, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Andres Olivares and Benedikt Meurer
Simon Zünd voted and added 1 comment![]( "Open in Gerrit")
Votes added by Simon Zünd
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Andres Olivares
- Benedikt Meurer
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Benedikt Meurer (Gerrit)
Jan 21, 2025, 2:16:57 AMJan 21
to Andres Olivares, Simon Zünd, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Attention needed from Andres Olivares
Benedikt Meurer voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andres Olivares
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andres Olivares (Gerrit)
Jan 21, 2025, 10:18:22 AMJan 21
to Simon Zünd, V8 LUCI CQ, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
Andres Olivares voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
V8 LUCI CQ (Gerrit)
Jan 21, 2025, 2:05:00 PMJan 21
to Andres Olivares, Benedikt Meurer, Simon Zünd, cbruni...@chromium.org, devtools-...@chromium.org, v8-re...@googlegroups.com
V8 LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add trace_id param to tick-sample
It will be used to associate a trace event with a sample, when a sample
is taken via V8::CollectSample. This is a faster alternative to
collecting a stack trace and adding it to the trace event payload, since
this requires symbolizing the stack. Instead, V8::CollectSample only
collects the stack register data and leaves the symbolization to the
profiler thread running the SamplingEventsProcessor.
Note this change doesn't do anything with the trace id yet. A follow up CL will add this data to the traced CPU profile.
Bug: 390155857
Change-Id: Iffa492de02ee0cfb7fd1bb5daf5762b1309e6681
Reviewed-by: Simon Zünd <szu...@chromium.org>
Reviewed-by: Benedikt Meurer <bme...@chromium.org>
Commit-Queue: Andres Olivares <and...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#98237}
Files:
- M include/v8-profiler.h
- M src/api/api.cc
- M src/profiler/cpu-profiler.cc
- M src/profiler/cpu-profiler.h
- M src/profiler/tick-sample.cc
- M src/profiler/tick-sample.h
Change size: S
Delta: 6 files changed, 32 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Simon Zünd, +1 by Benedikt Meurer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages