[webmcp] Report GenericIssue when title/description is missing [chromium/src : main]

[Anders Hartvoll Ruud (Gerrit)]

Attention needed from Alex Rudenko and Philip Pfaffe

Anders Hartvoll Ruud added 2 comments

File third_party/blink/public/devtools_protocol/domains/Audits.pdl

Line 743, Patchset 1: type ModelContextToolIssueDetails extends object

Alex Rudenko . resolved

should we use GenericIssueDetails instead? cc @pfa...@chromium.org

Philip Pfaffe

I think this could be a GenericIssue, yes. It can already link to nodes and also attributes.

Anders Hartvoll Ruud

OK, that works for me; I'll take this back to WIP while getting that sorted.

Anders Hartvoll Ruud

OK, done.

File third_party/blink/public/mojom/devtools/inspector_issue.mojom

Line 374, Patchset 1:// A collection of optional fields that may store additional data depending
// on the issue code.

Anders Hartvoll Ruud . resolved

nit-to-self: Oops, this comment should stay above `InspectorIssueDetails` ...

Anders Hartvoll Ruud

Done

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Philip Pfaffe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 12:53:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Philip Pfaffe <pfa...@chromium.org>

Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>

Comment-In-Reply-To: Alex Rudenko <alexr...@chromium.org>

[Philip Pfaffe (Gerrit)]

Attention needed from Alex Rudenko and Anders Hartvoll Ruud

Philip Pfaffe voted and added 2 comments

Votes added by Philip Pfaffe

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Philip Pfaffe . resolved

Thanks!

File third_party/blink/web_tests/inspector-protocol/model-context/missing-parameter-title-description-issue.js

Line 19, Patchset 3 (Latest): window.navigator.modelContextTesting.listTools();

Philip Pfaffe . unresolved

Is this required?

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Anders Hartvoll Ruud

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 12:59:56 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Anders Hartvoll Ruud (Gerrit)]

Attention needed from Alex Rudenko and Philip Pfaffe

Anders Hartvoll Ruud added 1 comment

File third_party/blink/web_tests/inspector-protocol/model-context/missing-parameter-title-description-issue.js

Line 19, Patchset 3 (Latest): window.navigator.modelContextTesting.listTools();

Philip Pfaffe . unresolved

Is this required?

Anders Hartvoll Ruud

Currently, yes. Schemas of form-backed tools are computed on demand. It's not (directly) triggered by loading, or other document lifecycle stages.

Depending on this API is not _ideal_, however. I guess we'll soon be adding some devtools protocol support for listing tools. Should we land that first, and use that instead?

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Philip Pfaffe

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Philip Pfaffe <pfa...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 13:08:33 +0000

[Philip Pfaffe (Gerrit)]

Attention needed from Alex Rudenko and Anders Hartvoll Ruud

Philip Pfaffe added 1 comment

File third_party/blink/web_tests/inspector-protocol/model-context/missing-parameter-title-description-issue.js

Line 19, Patchset 3 (Latest): window.navigator.modelContextTesting.listTools();

Philip Pfaffe . unresolved

Is this required?

Anders Hartvoll Ruud

Currently, yes. Schemas of form-backed tools are computed on demand. It's not (directly) triggered by loading, or other document lifecycle stages.

Depending on this API is not _ideal_, however. I guess we'll soon be adding some devtools protocol support for listing tools. Should we land that first, and use that instead?

Philip Pfaffe

Thanks for clarifying, I'm fine landing with the API for now. We'll notice if it gets removed or changes signifantly :)

Open in Gerrit

Related details

Attention is currently required from:

• Alex Rudenko
• Anders Hartvoll Ruud

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 13:10:30 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Philip Pfaffe <pfa...@chromium.org>

[Alex Rudenko (Gerrit)]

Attention needed from Anders Hartvoll Ruud

Alex Rudenko voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Anders Hartvoll Ruud

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 13:11:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Anders Hartvoll Ruud (Gerrit)]

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

Commit-Queue

+2

1 comment

File third_party/blink/web_tests/inspector-protocol/model-context/missing-parameter-title-description-issue.js

Line 19, Patchset 3 (Latest): window.navigator.modelContextTesting.listTools();

Philip Pfaffe . resolved

Is this required?

Anders Hartvoll Ruud

Currently, yes. Schemas of form-backed tools are computed on demand. It's not (directly) triggered by loading, or other document lifecycle stages.

Depending on this API is not _ideal_, however. I guess we'll soon be adding some devtools protocol support for listing tools. Should we land that first, and use that instead?

Philip Pfaffe

Thanks for clarifying, I'm fine landing with the API for now. We'll notice if it gets removed or changes signifantly :)

Anders Hartvoll Ruud

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-Comment-Date: Tue, 03 Mar 2026 13:39:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[gwsq (Gerrit)]

Attention needed from Camille Lamy

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: cl...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): cl...@chromium.org

Reviewer source(s):
cl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Camille Lamy

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Camille Lamy <cl...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 13:46:49 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Camille Lamy (Gerrit)]

Attention needed from Anders Hartvoll Ruud

Camille Lamy voted and added 1 comment

Votes added by Camille Lamy

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Camille Lamy . resolved

IPC lgtm

Open in Gerrit

Related details

Attention is currently required from:

• Anders Hartvoll Ruud

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I2fc627e83e4acd2bc5e4e9de6979ff546a4e7de9

Gerrit-Change-Number: 7623662

Gerrit-PatchSet: 3

Gerrit-Owner: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>

Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>

Gerrit-Reviewer: Philip Pfaffe <pfa...@chromium.org>

Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: devtools...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Mar 2026 16:26:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes