TabModel#CreateTab() Accepts a TabLaunchType instead of a bool [chromium/src : main]

0 views
Skip to first unread message

Jack Thiesen (Gerrit)

unread,
Dec 22, 2025, 2:35:09 PM (4 days ago) Dec 22
to Linyu He, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, dullweb...@chromium.org, extension...@chromium.org, feature-v...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org
Attention needed from Jack Thiesen and Linyu He

Jack Thiesen voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Thiesen
  • Linyu He
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I011766ac31b9ba286abf0dc4d32c4f3fbd4ed633
Gerrit-Change-Number: 7298922
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Thiesen <jthi...@chromium.org>
Gerrit-Reviewer: Jack Thiesen <jthi...@chromium.org>
Gerrit-Reviewer: Linyu He <lin...@google.com>
Gerrit-Attention: Jack Thiesen <jthi...@chromium.org>
Gerrit-Attention: Linyu He <lin...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 19:35:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Linyu He (Gerrit)

unread,
Dec 23, 2025, 12:56:30 PM (3 days ago) Dec 23
to Jack Thiesen, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, dullweb...@chromium.org, extension...@chromium.org, feature-v...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org
Attention needed from Jack Thiesen

Linyu He voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Thiesen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I011766ac31b9ba286abf0dc4d32c4f3fbd4ed633
    Gerrit-Change-Number: 7298922
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jack Thiesen <jthi...@chromium.org>
    Gerrit-Reviewer: Jack Thiesen <jthi...@chromium.org>
    Gerrit-Reviewer: Linyu He <lin...@google.com>
    Gerrit-Attention: Jack Thiesen <jthi...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 17:56:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jack Thiesen (Gerrit)

    unread,
    Dec 23, 2025, 3:52:52 PM (3 days ago) Dec 23
    to Theresa Sullivan, Linyu He, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, asvitki...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, dullweb...@chromium.org, extension...@chromium.org, feature-v...@chromium.org, mfoltz+wa...@chromium.org, msrame...@chromium.org

    Jack Thiesen voted Owners-Override+1

    Owners-Override+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I011766ac31b9ba286abf0dc4d32c4f3fbd4ed633
    Gerrit-Change-Number: 7298922
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jack Thiesen <jthi...@chromium.org>
    Gerrit-Reviewer: Jack Thiesen <jthi...@chromium.org>
    Gerrit-Reviewer: Linyu He <lin...@google.com>
    Gerrit-CC: Theresa Sullivan <twell...@chromium.org>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 20:52:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages