Remove insets as they always defaulted [devtools/devtools-frontend : main]
Nikolay Vitkov (Gerrit)
Nikolay Vitkov voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
- Philip Pfaffe
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
Everywhere this was set to 0,0,0,0.Even if it is 0 in the current set of devices, is that universal? Why did we have inset support in the first place?
Related details
- Nikolay Vitkov
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
Everywhere this was set to 0,0,0,0.Even if it is 0 in the current set of devices, is that universal? Why did we have inset support in the first place?
This used to be part of the image that were inlayed on top of the image to imitate Android. Try emulation with Nexus 5 as example.
Related details
- Philip Pfaffe
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Philip Pfaffe added 1 comment![]( "Open in Gerrit")
Everywhere this was set to 0,0,0,0.Nikolay VitkovEven if it is 0 in the current set of devices, is that universal? Why did we have inset support in the first place?
This used to be part of the image that were inlayed on top of the image to imitate Android. Try emulation with Nexus 5 as example.
https://crbug.com/40718410 includes work on VK emulation. Maybe double check whether that was relying on these insets in any capacity or whether it's really purely based on safe-area-insets.
Related details
- Nikolay Vitkov
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guangyue Xu (Gerrit)
Guangyue Xu added 1 comment![]( "Open in Gerrit")
Everywhere this was set to 0,0,0,0.Nikolay VitkovEven if it is 0 in the current set of devices, is that universal? Why did we have inset support in the first place?
Philip PfaffeThis used to be part of the image that were inlayed on top of the image to imitate Android. Try emulation with Nexus 5 as example.
https://crbug.com/40718410 includes work on VK emulation. Maybe double check whether that was relying on these insets in any capacity or whether it's really purely based on safe-area-insets.
Confirmed — it's purely `safe-area-insets` / `cutout` / VK-geometry, never `mode.insets` (its only reader was `currentInsets()`, feeding the generic device-metrics override), so safe to remove for what's landed. Full breakdown in crbug.com/40718410#comment65.
Related details
- Nikolay Vitkov
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nikolay Vitkov (Gerrit)
Nikolay Vitkov added 1 comment![]( "Open in Gerrit")
Everywhere this was set to 0,0,0,0.Nikolay VitkovEven if it is 0 in the current set of devices, is that universal? Why did we have inset support in the first place?
Philip PfaffeThis used to be part of the image that were inlayed on top of the image to imitate Android. Try emulation with Nexus 5 as example.
Guangyue Xuhttps://crbug.com/40718410 includes work on VK emulation. Maybe double check whether that was relying on these insets in any capacity or whether it's really purely based on safe-area-insets.
Confirmed — it's purely `safe-area-insets` / `cutout` / VK-geometry, never `mode.insets` (its only reader was `currentInsets()`, feeding the generic device-metrics override), so safe to remove for what's landed. Full breakdown in crbug.com/40718410#comment65.
- Guangyue Xu
- Philip Pfaffe
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philip Pfaffe (Gerrit)
Philip Pfaffe voted![]( "Open in Gerrit")
- Guangyue Xu
- Nikolay Vitkov
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
devtools-frontend-scoped@luci-project-accounts.iam.gserviceaccount.com (Gerrit)
devtools-fro...@luci-project-accounts.iam.gserviceaccount.com submitted the change![]( "Open in Gerrit")
Change information
Remove insets as they always defaulted
Everywhere this was set to 0,0,0,0.
- M front_end/legacy_test_runner/device_mode_test_runner/device_mode_test_runner.js
- M front_end/models/emulation/DeviceModeModel.test.ts
- M front_end/models/emulation/DeviceModeModel.ts
- M front_end/models/emulation/EmulatedDevices.test.ts
- M front_end/models/emulation/EmulatedDevices.ts
- M front_end/panels/settings/emulation/DevicesSettingsTab.test.ts
- M front_end/panels/settings/emulation/DevicesSettingsTab.ts
Code-Review: +1 by Philip Pfaffe
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |