Migrate from AIDA to GCA API endpoints [chromium/src : main]
Alex Rudenko (Gerrit)
Alex Rudenko voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alex Rudenko
| Code-Review | -1 |
1 comment
I think we should add the GCA endpoints to the generic HTTP handler (as per b/436202118). We already tested that http handling works with the new API. The most of the work would be on the frontend to update data structures to send data in the new format.
Related details
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liviu Rau (Gerrit)
Liviu Rau added 1 comment![]( "Open in Gerrit")
AidaClient::Availability availability = AidaClient::CanUseAida(profile);AidaClient should be removed as a cleanup step after the migration. We will move the Availability logic to a new place at that time.
Related details
- Alex Rudenko
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko added 1 comment![]( "Open in Gerrit")
I think we should add the GCA endpoints to the generic HTTP handler (as per b/436202118). We already tested that http handling works with the new API. The most of the work would be on the frontend to update data structures to send data in the new format.
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liviu Rau (Gerrit)
Liviu Rau voted Commit-Queue+1![]( "Open in Gerrit")
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liviu Rau (Gerrit)
Liviu Rau voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Chrome Signin Team
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
Reviewer source(s):
bsaz...@chromium.org is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)
Related details
- Boris Sazonov
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: kin...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): kin...@chromium.org
Reviewer source(s):
kin...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
- Boris Sazonov
- Kinuko Yasuda
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
- Boris Sazonov
- Kinuko Yasuda
- Liviu Rau
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Boris Sazonov (Gerrit)
Boris Sazonov voted and added 3 comments![]( "Open in Gerrit")
Votes added by Boris Sazonov
| Code-Review | +1 |
3 comments
This change migrates DevTools AI assistance features from the AIDA API to the new Gemini Code Assist (GCA) API.
A new GcaServiceHandler is introduced to handle requests to the aicode.googleapis.com endpoint, and a feature flag kDevToolsUseGcaApi has been added to switch between the old AIDA and the new GCA backends. The change also includes adding new OAuth scopes and IDs for the GCA service.[Nit] Wrap to 72 characters.
case OAuthConsumerId::kDevtoolsAiCode:Please keep the same order as in the enum declaration (in other words - please move this to the end of the switch statement).
The current ordering does give some readability benefits, but these seem temporary and will likely go away after the old access point gets taken down.
Related details
- Kinuko Yasuda
- Liviu Rau
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling added 4 comments![]( "Open in Gerrit")
"for example, by typing in the console, using the AI chat panel, "Nit: Typing in the console alone doesn't trigger this request yet, it requires prior opt-in to the respective AI feature that then kicks in when tying in the console. Which isn't immediately obvious from the current "trigger" and "setting" description. Could that be made a bit clearer to avoid misunderstandings?
"(natural language or code), and settings related to the AI feature. "Nit: Setting? Settings cannot be sent - do you mean the data that is specified with the respective AI setting that the user opted in to?
user_data {Should this also include [stuff](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/privacy/traffic_annotation.proto?q=UserDataType) like ACCESS_TOKEN? (see line 36)
"and can be influenced by DevTools settings. Users must be signed "Nit: could this be clear which setting(s)? IIUC this request here is gated by the respective DevTools AI settings toggles - meaning if all are off this won't be sent.
Related details
- Kinuko Yasuda
- Liviu Rau
Liviu Rau (Gerrit)
Liviu Rau added 6 comments![]( "Open in Gerrit")
This change migrates DevTools AI assistance features from the AIDA API to the new Gemini Code Assist (GCA) API.
A new GcaServiceHandler is introduced to handle requests to the aicode.googleapis.com endpoint, and a feature flag kDevToolsUseGcaApi has been added to switch between the old AIDA and the new GCA backends. The change also includes adding new OAuth scopes and IDs for the GCA service.[Nit] Wrap to 72 characters.
Done
"for example, by typing in the console, using the AI chat panel, "Nit: Typing in the console alone doesn't trigger this request yet, it requires prior opt-in to the respective AI feature that then kicks in when tying in the console. Which isn't immediately obvious from the current "trigger" and "setting" description. Could that be made a bit clearer to avoid misunderstandings?
updated
"(natural language or code), and settings related to the AI feature. "Nit: Setting? Settings cannot be sent - do you mean the data that is specified with the respective AI setting that the user opted in to?
Rephrased.
Should this also include [stuff](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/privacy/traffic_annotation.proto?q=UserDataType) like ACCESS_TOKEN? (see line 36)
Added ACCESS_TOKEN.
"and can be influenced by DevTools settings. Users must be signed "Nit: could this be clear which setting(s)? IIUC this request here is gated by the respective DevTools AI settings toggles - meaning if all are off this won't be sent.
Rephrased.
Please keep the same order as in the enum declaration (in other words - please move this to the end of the switch statement).
The current ordering does give some readability benefits, but these seem temporary and will likely go away after the old access point gets taken down.
- Kinuko Yasuda
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling added 1 comment![]( "Open in Gerrit")
"for example, by typing in the console, using the AI chat panel, "Liviu RauNit: Typing in the console alone doesn't trigger this request yet, it requires prior opt-in to the respective AI feature that then kicks in when tying in the console. Which isn't immediately obvious from the current "trigger" and "setting" description. Could that be made a bit clearer to avoid misunderstandings?
updated
I don't see the respective changes in Gerrit yet, did you overlook to upload them?
Related details
- Kinuko Yasuda
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liviu Rau (Gerrit)
Liviu Rau added 1 comment![]( "Open in Gerrit")
"for example, by typing in the console, using the AI chat panel, "Liviu RauNit: Typing in the console alone doesn't trigger this request yet, it requires prior opt-in to the respective AI feature that then kicks in when tying in the console. Which isn't immediately obvious from the current "trigger" and "setting" description. Could that be made a bit clearer to avoid misunderstandings?
Rainhard Findlingupdated
I don't see the respective changes in Gerrit yet, did you overlook to upload them?
Ah, indeed. I blame Cider: the edit was there, but it reported it had nothing to upload. Strange.
Related details
- Alex Rudenko
- Boris Sazonov
- Kinuko Yasuda
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling added 4 comments![]( "Open in Gerrit")
"or triggering code completion requires prior opt-in."Nit: ", which requires..."
"(natural language or code), and settings related to the AI feature. "Liviu RauNit: Setting? Settings cannot be sent - do you mean the data that is specified with the respective AI setting that the user opted in to?
Rainhard FindlingRephrased.
Huh, I also don't see this change here - did Cider's upload miss it?
user_data {Liviu RauShould this also include [stuff](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/privacy/traffic_annotation.proto?q=UserDataType) like ACCESS_TOKEN? (see line 36)
Added ACCESS_TOKEN.
Same as above, don't see it here
"and can be influenced by DevTools settings. Users must be signed "Liviu RauNit: could this be clear which setting(s)? IIUC this request here is gated by the respective DevTools AI settings toggles - meaning if all are off this won't be sent.
Rainhard FindlingRephrased.
Same as above, don't see it here
Related details
- Alex Rudenko
- Boris Sazonov
- Kinuko Yasuda
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Boris Sazonov (Gerrit)
Boris Sazonov added 1 comment![]( "Open in Gerrit")
case OAuthConsumerId::kDevtoolsAiCode:Liviu RauPlease keep the same order as in the enum declaration (in other words - please move this to the end of the switch statement).
The current ordering does give some readability benefits, but these seem temporary and will likely go away after the old access point gets taken down.
Done
- Alex Rudenko
- Kinuko Yasuda
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liviu Rau (Gerrit)
Liviu Rau added 4 comments![]( "Open in Gerrit")
"or triggering code completion requires prior opt-in."Liviu RauNit: ", which requires..."
done
"(natural language or code), and settings related to the AI feature. "Liviu RauNit: Setting? Settings cannot be sent - do you mean the data that is specified with the respective AI setting that the user opted in to?
Rainhard FindlingRephrased.
Huh, I also don't see this change here - did Cider's upload miss it?
Hmm... I had "divergent changes" in my workspace. Struggled a bit with them and in the end I simply deleted the worspace.
user_data {Liviu RauShould this also include [stuff](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/privacy/traffic_annotation.proto?q=UserDataType) like ACCESS_TOKEN? (see line 36)
Rainhard FindlingAdded ACCESS_TOKEN.
Same as above, don't see it here
Done
"and can be influenced by DevTools settings. Users must be signed "Liviu RauNit: could this be clear which setting(s)? IIUC this request here is gated by the respective DevTools AI settings toggles - meaning if all are off this won't be sent.
Rainhard FindlingRephrased.
Same as above, don't see it here
- Alex Rudenko
- Kinuko Yasuda
- Rainhard Findling
Rainhard Findling (Gerrit)
Rainhard Findling voted and added 2 comments![]( "Open in Gerrit")
Votes added by Rainhard Findling
| Code-Review | +1 |
2 comments
network traffic annotation LGTM % nit
"(Console Insights, AI Assistance, and AI Code Completion). "Nit: add "e.g. ..." in front of the list, to ensure omitting a single feature, like Auto Annotations (https://screenshot.googleplex.com/9psBCmDJGpjFrYq) doesn't lead to misunderstandings.
Related details
- Alex Rudenko
- Kinuko Yasuda
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
- Kinuko Yasuda
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Liviu Rau (Gerrit)
Liviu Rau added 2 comments![]( "Open in Gerrit")
"(Console Insights, AI Assistance, and AI Code Completion). "Nit: add "e.g. ..." in front of the list, to ensure omitting a single feature, like Auto Annotations (https://screenshot.googleplex.com/9psBCmDJGpjFrYq) doesn't lead to misunderstandings.
Done
case OAuthConsumerId::kDevtoolsAiCode:Liviu RauPlease keep the same order as in the enum declaration (in other words - please move this to the end of the switch statement).
The current ordering does give some readability benefits, but these seem temporary and will likely go away after the old access point gets taken down.
Boris SazonovDone
Doesn't seem to be done, reopening.
- Alex Rudenko
- Boris Sazonov
- Kinuko Yasuda
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rainhard Findling (Gerrit)
Rainhard Findling voted and added 1 comment![]( "Open in Gerrit")
Votes added by Rainhard Findling
| Code-Review | +1 |
1 comment
network traffic annotations still LGTM
Related details
- Alex Rudenko
- Boris Sazonov
- Kinuko Yasuda
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kinuko Yasuda (Gerrit)
Kinuko Yasuda voted Code-Review+1![]( "Open in Gerrit")
- Alex Rudenko
- Boris Sazonov
- Liviu Rau
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
Alex Rudenko (Gerrit)
Alex Rudenko voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
- Boris Sazonov
- Kinuko Yasuda
- Liviu Rau
- Rainhard Findling
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |