[PATCH 4/4] Revert "compute pressure: Calculate ownContributionEstimate" [chromium/src : main]

1 view
Skip to first unread message

Reilly Grant (Gerrit)

unread,
May 20, 2026, 2:22:53 PM (4 days ago) May 20
to Wang, Wei4, Reilly Grant, Matt Reynolds, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Matt Reynolds and Wang, Wei4

Reilly Grant voted and added 1 comment

Votes added by Reilly Grant

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Reilly Grant . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Matt Reynolds
  • Wang, Wei4
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84fcc6da05b8c80272120ed6e822eedc56bd61e2
Gerrit-Change-Number: 7863882
Gerrit-PatchSet: 3
Gerrit-Owner: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Mandy, Arnaud <arnaud...@intel.com>
Gerrit-Attention: Wang, Wei4 <wei4...@intel.com>
Gerrit-Attention: Matt Reynolds <mattre...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 18:22:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Matt Reynolds (Gerrit)

unread,
May 20, 2026, 2:40:04 PM (4 days ago) May 20
to Wang, Wei4, Reilly Grant, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Wang, Wei4

Matt Reynolds added 1 comment

Patchset-level comments
Matt Reynolds . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Wang, Wei4
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84fcc6da05b8c80272120ed6e822eedc56bd61e2
Gerrit-Change-Number: 7863882
Gerrit-PatchSet: 3
Gerrit-Owner: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Wang, Wei4 <wei4...@intel.com>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Mandy, Arnaud <arnaud...@intel.com>
Gerrit-Attention: Wang, Wei4 <wei4...@intel.com>
Gerrit-Comment-Date: Wed, 20 May 2026 18:39:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
May 20, 2026, 8:05:28 PM (4 days ago) May 20
to Wang, Wei4, Chromium IPC Reviews, Yang Guo, Mike West, Reilly Grant, Matt Reynolds, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Mike West and Yang Guo

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): mk...@chromium.org

Note: IPC gwsq added no new reviewers; existing reviewers satisfied requirements!

Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Mike West
  • Yang Guo
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84fcc6da05b8c80272120ed6e822eedc56bd61e2
Gerrit-Change-Number: 7863882
Gerrit-PatchSet: 3
Gerrit-Owner: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Mandy, Arnaud <arnaud...@intel.com>
Gerrit-CC: gwsq
Gerrit-Attention: Yang Guo <yan...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Comment-Date: Thu, 21 May 2026 00:05:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yang Guo (Gerrit)

unread,
May 21, 2026, 4:08:05 AM (4 days ago) May 21
to Wang, Wei4, Chromium IPC Reviews, Mike West, Reilly Grant, Matt Reynolds, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Mike West and Wang, Wei4

Yang Guo voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Mike West
  • Wang, Wei4
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Wang, Wei4 <wei4...@intel.com>
Gerrit-Comment-Date: Thu, 21 May 2026 08:07:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mike West (Gerrit)

unread,
May 22, 2026, 3:33:06 AM (3 days ago) May 22
to Wang, Wei4, Yang Guo, Chromium IPC Reviews, Reilly Grant, Matt Reynolds, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Attention needed from Wang, Wei4

Mike West voted and added 1 comment

Votes added by Mike West

Code-Review+1

1 comment

Patchset-level comments
Mike West . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Wang, Wei4
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84fcc6da05b8c80272120ed6e822eedc56bd61e2
Gerrit-Change-Number: 7863882
Gerrit-PatchSet: 3
Gerrit-Owner: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Kenneth R Christiansen <kenneth.r.c...@intel.com>
Gerrit-CC: Mandy, Arnaud <arnaud...@intel.com>
Gerrit-CC: gwsq
Gerrit-Attention: Wang, Wei4 <wei4...@intel.com>
Gerrit-Comment-Date: Fri, 22 May 2026 07:32:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Wang, Wei4 (Gerrit)

unread,
May 22, 2026, 7:47:37 PM (2 days ago) May 22
to Mike West, Yang Guo, Chromium IPC Reviews, Reilly Grant, Matt Reynolds, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org

Wang, Wei4 voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Fri, 22 May 2026 23:47:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Wang, Wei4 (Gerrit)

unread,
May 23, 2026, 6:50:35 AM (yesterday) May 23
to Mike West, Yang Guo, Chromium IPC Reviews, Reilly Grant, Matt Reynolds, Chromium LUCI CQ, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org
Gerrit-Comment-Date: Sat, 23 May 2026 10:50:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 23, 2026, 7:14:11 AM (yesterday) May 23
to Wang, Wei4, Mike West, Yang Guo, Chromium IPC Reviews, Reilly Grant, Matt Reynolds, Mandy, Arnaud, chromium...@chromium.org, devtools...@chromium.org, Kenneth R Christiansen, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[PATCH 4/4] Revert "compute pressure: Calculate ownContributionEstimate"

This reverts commit c18b6b45fa249d8f36e56d481d08c4cd90f510ce.

This feature is creating information leak. There is no active
development on this feature anymore, therefore it was decided to
revert the patches related to this feature.
Bug: 513009005
Change-Id: I84fcc6da05b8c80272120ed6e822eedc56bd61e2
Reviewed-by: Yang Guo <yan...@chromium.org>
Reviewed-by: Reilly Grant <rei...@chromium.org>
Commit-Queue: Wang, Wei4 <wei4...@intel.com>
Reviewed-by: Mike West <mk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1635415}
Files:
  • M content/browser/compute_pressure/pressure_client_impl.cc
  • M content/browser/compute_pressure/pressure_service_base.h
  • M content/browser/compute_pressure/pressure_service_browsertest.cc
  • M content/browser/compute_pressure/pressure_service_for_dedicated_worker.cc
  • M content/browser/compute_pressure/pressure_service_for_dedicated_worker.h
  • M content/browser/compute_pressure/pressure_service_for_frame.cc
  • M content/browser/compute_pressure/pressure_service_for_frame.h
  • M content/browser/compute_pressure/pressure_service_for_frame_unittest.cc
  • M content/browser/compute_pressure/pressure_service_for_shared_worker.cc
  • M content/browser/compute_pressure/pressure_service_for_shared_worker.h
  • M content/browser/compute_pressure/pressure_service_for_worker_unittest.cc
  • M content/browser/compute_pressure/web_contents_pressure_manager_proxy.cc
  • M content/browser/compute_pressure/web_contents_pressure_manager_proxy.h
  • M content/browser/devtools/protocol/emulation_handler.cc
  • M content/web_test/browser/web_test_pressure_manager.cc
  • M content/web_test/browser/web_test_pressure_manager.h
  • M services/device/compute_pressure/cpu_probe_manager.cc
  • M services/device/compute_pressure/pressure_manager_impl.cc
  • M services/device/compute_pressure/pressure_manager_impl.h
  • M services/device/compute_pressure/pressure_manager_impl_unittest.cc
  • M services/device/compute_pressure/virtual_cpu_probe_manager.cc
  • M services/device/compute_pressure/virtual_cpu_probe_manager.h
  • M services/device/compute_pressure/virtual_probes_manager.cc
  • M services/device/compute_pressure/virtual_probes_manager.h
  • M services/device/public/cpp/test/scoped_pressure_manager_overrider.h
  • M services/device/public/mojom/pressure_manager.mojom
  • M services/device/public/mojom/pressure_update.mojom
  • M third_party/blink/public/mojom/compute_pressure/web_pressure_update.mojom
  • M third_party/blink/public/test/mojom/compute_pressure/web_pressure_manager_automation.test-mojom
  • M third_party/blink/renderer/modules/compute_pressure/pressure_observer_test.cc
  • M third_party/blink/renderer/modules/compute_pressure/testing/internals_compute_pressure.cc
  • M third_party/blink/renderer/modules/compute_pressure/testing/internals_compute_pressure.h
Change size: L
Delta: 32 files changed, 96 insertions(+), 259 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mike West, +1 by Yang Guo, +1 by Reilly Grant
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I84fcc6da05b8c80272120ed6e822eedc56bd61e2
Gerrit-Change-Number: 7863882
Gerrit-PatchSet: 4
Gerrit-Owner: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Matt Reynolds <mattre...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Wang, Wei4 <wei4...@intel.com>
Gerrit-Reviewer: Yang Guo <yan...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages