Ensure the links present in Event listeners tab are accessible with keyboard. [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Sylvester Elorm Coch (Gerrit)

unread,
Dec 26, 2025, 1:52:16 PM (4 days ago) Dec 26
to Ergün Erdoğmuş, devtools-rev...@chromium.org
Attention needed from Ergün Erdoğmuş

Sylvester Elorm Coch added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sylvester Elorm Coch . resolved

@erg...@chromium.org could you PTAL? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Ergün Erdoğmuş
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I68646afdfdf79abfc1023f3f3def6b39426fc4f9
Gerrit-Change-Number: 7313008
Gerrit-PatchSet: 2
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>
Gerrit-Attention: Ergün Erdoğmuş <erg...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Dec 2025 18:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
unsatisfied_requirement
open
diffy

Ergün Erdoğmuş (Gerrit)

unread,
Dec 29, 2025, 5:41:31 AM (yesterday) Dec 29
to Sylvester Elorm Coch, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Sylvester Elorm Coch

Ergün Erdoğmuş voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sylvester Elorm Coch
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I68646afdfdf79abfc1023f3f3def6b39426fc4f9
Gerrit-Change-Number: 7313008
Gerrit-PatchSet: 2
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Comment-Date: Mon, 29 Dec 2025 10:41:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sylvester Elorm Coch (Gerrit)

unread,
Dec 29, 2025, 10:50:50 AM (yesterday) Dec 29
to Ergün Erdoğmuş, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org

Sylvester Elorm Coch voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I68646afdfdf79abfc1023f3f3def6b39426fc4f9
Gerrit-Change-Number: 7313008
Gerrit-PatchSet: 2
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Ergün Erdoğmuş <erg...@chromium.org>
Gerrit-Reviewer: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Mon, 29 Dec 2025 15:50:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
Dec 29, 2025, 11:22:17 AM (yesterday) Dec 29
to Sylvester Elorm Coch, Ergün Erdoğmuş, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Ensure the links present in Event listeners tab are accessible with keyboard.

We add tabIndex to the links under the event listeners tab in the Elements Pane via including a tabStop option to linkifyRawLocation.
Bug: 471730914
Change-Id: I68646afdfdf79abfc1023f3f3def6b39426fc4f9
Reviewed-by: Ergün Erdoğmuş <erg...@chromium.org>
Commit-Queue: Sylvester Elorm Coch <elor...@microsoft.com>
Files:
  • M front_end/panels/event_listeners/EventListenersView.ts
  • M front_end/ui/legacy/components/utils/Linkifier.ts
Change size: XS
Delta: 2 files changed, 5 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ergün Erdoğmuş
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I68646afdfdf79abfc1023f3f3def6b39426fc4f9
Gerrit-Change-Number: 7313008
Gerrit-PatchSet: 3
Gerrit-Owner: Sylvester Elorm Coch <elor...@microsoft.com>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages