[AI] Add styling to the 3p/timeline summary widget [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Alina Varkki (Gerrit)
6:47 AM (1 hour ago) 6:47 AM
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alina Varkki voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alina Varkki
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jack Franklin (Gerrit)
7:00 AM (1 hour ago) 7:00 AM
to Alina Varkki, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Alina Varkki
Jack Franklin added 1 comment![]( "Open in Gerrit")
File front_end/panels/ai_assistance/components/ChatMessage.ts
Line 1380, Patchset 1 (Latest):
class="is-widget"Jack Franklin . unresolved
I think this is quite a generic and confusing name because technically all of these are widgets 😄
What about instead supporting `max-height=200px` or something ? And if the user passes that, we set the height & scroll.
Related details
Attention is currently required from:
- Alina Varkki
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alina Varkki (Gerrit)
8:11 AM (6 minutes ago) 8:11 AM
to Devtools-frontend LUCI CQ, Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin
Alina Varkki added 1 comment![]( "Open in Gerrit")
File front_end/panels/ai_assistance/components/ChatMessage.ts
Line 1380, Patchset 1 (Latest):
class="is-widget"Jack Franklin . unresolved
I think this is quite a generic and confusing name because technically all of these are widgets 😄
What about instead supporting `max-height=200px` or something ? And if the user passes that, we set the height & scroll.
Alina Varkki
sorry, I didn't get it. Do you mean we keep 'is-widget' flag, rename it and if it is true, set max-height?
Related details
Attention is currently required from:
- Jack Franklin
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages