[intl] add Intl.Locale.prototype get variants [v8/v8 : main]
Leszek Swirski (Gerrit)
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Leszek Swirskisorry, I have not add new feature to v8 for a while and forgot what I should do while I hit this kind of error. Is there some sh tool I should run to regeneratet some thing ?
This is a new error from a new validation we added -- you need to add your new flag and builtin to `Builtins::GetJSBuiltinState`, you can follow the pattern of other similar harmony builtins.
Related details
- Deepti Gandluri
- Frank Tang
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frank Tang (Gerrit)
Frank Tang added 1 comment![]( "Open in Gerrit")
Leszek Swirskisorry, I have not add new feature to v8 for a while and forgot what I should do while I hit this kind of error. Is there some sh tool I should run to regeneratet some thing ?
This is a new error from a new validation we added -- you need to add your new flag and builtin to `Builtins::GetJSBuiltinState`, you can follow the pattern of other similar harmony builtins.
- Deepti Gandluri
- Leszek Swirski
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frank Tang (Gerrit)
Frank Tang added 1 comment![]( "Open in Gerrit")
Do you know how should I fix the following issue?
It seems not solved by rerun ./tools/dev/gen-static-roots.py
Step _compile_ failed. Error logs are shown below:
[4976/7783] CXX clang_x64_v8_arm64/obj/v8_base_without_compiler/api.o
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF clang_x64_v8_arm64/obj/v8_base_without_compiler/api.o.d -D__STDC_CONSTANT_MA...(too long)
../../src/api/api.cc:628:35: error: static assertion failed due to requirement 'v8::internal::Internals::StaticReadOnlyRoot::kTheHoleValue == v8::internal::StaticReadOnlyRoot::kTheHoleValue'
628 | EXPORTED_STATIC_ROOTS_PTR_MAPPING(CHECK_STATIC_ROOT)
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
../../src/api/api.cc:620:3: note: expanded from macro 'EXPORTED_STATIC_ROOTS_PTR_MAPPING'
620 | V(TheHoleValue, i::StaticReadOnlyRoot::kTheHoleValue) \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/api/api.cc:627:17: note: expanded from macro 'CHECK_STATIC_ROOT'
627 | static_assert(Internals::StaticReadOnlyRoot::k##name == value);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...The message was too long...
Frank Tang (Gerrit)
Frank Tang added 1 comment![]( "Open in Gerrit")
Olivier: please help. I do not know how to fix this check. Any idea why my CL is broken here?
Related details
- Deepti Gandluri
- Leszek Swirski
- Olivier Flückiger
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leszek Swirski (Gerrit)
Leszek Swirski added 1 comment![]( "Open in Gerrit")
Olivier: please help. I do not know how to fix this check. Any idea why my CL is broken here?
you need to update the externally visible HoleValue in https://source.chromium.org/chromium/chromium/src/+/main:v8/include/v8-internal.h;l=1035;drc=d1eb7578dd9dc96706ce977167f603dcc0ded4dd to the new one in src/roots/static-roots-intl-nowasm.h
Related details
- Deepti Gandluri
- Frank Tang
- Olivier Flückiger
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frank Tang (Gerrit)
Frank Tang added 2 comments![]( "Open in Gerrit")
Leszek SwirskiOlivier: please help. I do not know how to fix this check. Any idea why my CL is broken here?
you need to update the externally visible HoleValue in https://source.chromium.org/chromium/chromium/src/+/main:v8/include/v8-internal.h;l=1035;drc=d1eb7578dd9dc96706ce977167f603dcc0ded4dd to the new one in src/roots/static-roots-intl-nowasm.h
- Deepti Gandluri
- Leszek Swirski
- Olivier Flückiger
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |