Linkify codespan to satisfy LLM [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Nikolay Vitkov (Gerrit)

unread,
12:58 PM (2 hours ago) 12:58 PM
to Jack Franklin, devtools-rev...@chromium.org
Attention needed from Jack Franklin

Nikolay Vitkov voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0d126636a0892216edecf68c41bfbdeb75d987a6
Gerrit-Change-Number: 7628383
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 17:58:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jack Franklin (Gerrit)

unread,
1:00 PM (2 hours ago) 1:00 PM
to Nikolay Vitkov, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Nikolay Vitkov

Jack Franklin voted and added 1 comment

Votes added by Jack Franklin

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jack Franklin . resolved

lgtm (need a test? up to you)

Open in Gerrit

Related details

Attention is currently required from:
  • Nikolay Vitkov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0d126636a0892216edecf68c41bfbdeb75d987a6
Gerrit-Change-Number: 7628383
Gerrit-PatchSet: 1
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Jack Franklin <jacktf...@chromium.org>
Gerrit-Reviewer: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 18:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
1:39 PM (1 hour ago) 1:39 PM
to Nikolay Vitkov, Jack Franklin, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Linkify codespan to satisfy LLM

I found that LLM really like doing `[text](link)` which breaks our
parser.
Bug: none
Change-Id: I0d126636a0892216edecf68c41bfbdeb75d987a6
Auto-Submit: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Nikolay Vitkov <nvi...@chromium.org>
Commit-Queue: Jack Franklin <jacktf...@chromium.org>
Reviewed-by: Jack Franklin <jacktf...@chromium.org>
Files:
  • M front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.test.ts
  • M front_end/panels/ai_assistance/components/MarkdownRendererWithCodeBlock.ts
Change size: M
Delta: 2 files changed, 59 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Jack Franklin
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I0d126636a0892216edecf68c41bfbdeb75d987a6
Gerrit-Change-Number: 7628383
Gerrit-PatchSet: 2
Gerrit-Owner: Nikolay Vitkov <nvi...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages