Add a 'automatic mode with DoH fallback' option to Secure DNS. [chromium/src : main]

0 views
Skip to first unread message

Kirubel Aklilu (Gerrit)

unread,
Oct 31, 2025, 11:54:58 AM (7 days ago) Oct 31
to David Schinazi, Andrew Williams, Awad Osman, Nikhil Nayunigari, Javier Castro, Peter Beverloo, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jonmann+wa...@chromium.org, chadduffin+w...@chromium.org, stevenjb+wa...@chromium.org, hsuregan+wa...@chromium.org, ejcaruso+wa...@chromium.org, khorimoto+w...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, rrsilva+wat...@google.com, asvitkine...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, net-r...@chromium.org, network-ser...@chromium.org, srahim...@chromium.org
Attention needed from David Schinazi

Kirubel Aklilu added 3 comments

Patchset-level comments
File-level comment, Patchset 25:
David Schinazi . resolved

I'm happy to LGTM the histograms but given that this is an important change we should get one of the primary reviewers from //net/OWNERS to LGTM as well to ensure that the Chrome Networking team is aware of the details

Kirubel Aklilu

Good point, I used the Gerrit UI and wasn't aware that you're a secondary reviewer. I'll send this CL their way on Monday when their working hours start again.

Commit Message
Line 26, Patchset 25:users who want to use DoH even if their provider doesn't support it.
David Schinazi . resolved

Can you update this CL description to mention which DoH server will be used if the DNS servers from the config don't support DoH?

Kirubel Aklilu

Done

File chrome/common/pref_names.h
Line 2900, Patchset 25:// fallback to DoH with a default provider instead of using insecure DNS.
David Schinazi . resolved

Can we mention which default provider is used in this comment?

Kirubel Aklilu

Done

Open in Gerrit

Related details

Attention is currently required from:
  • David Schinazi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0351619dd695e713f853d3ab594924cd02dca982
Gerrit-Change-Number: 7042523
Gerrit-PatchSet: 28
Gerrit-Owner: Kirubel Aklilu <kak...@chromium.org>
Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: David Schinazi <dsch...@chromium.org>
Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
Gerrit-CC: Awad Osman <aw...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Javier Castro <jaca...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Varun Khaneja <va...@chromium.org>
Gerrit-Attention: David Schinazi <dsch...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Oct 2025 15:54:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Schinazi <dsch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Kirubel Aklilu (Gerrit)

unread,
Nov 2, 2025, 6:42:58 PM (4 days ago) Nov 2
to Kenichi Ishibashi, David Schinazi, Andrew Williams, Awad Osman, Nikhil Nayunigari, Javier Castro, Peter Beverloo, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jonmann+wa...@chromium.org, chadduffin+w...@chromium.org, stevenjb+wa...@chromium.org, hsuregan+wa...@chromium.org, ejcaruso+wa...@chromium.org, khorimoto+w...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, rrsilva+wat...@google.com, asvitkine...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, net-r...@chromium.org, network-ser...@chromium.org, srahim...@chromium.org
Attention needed from Kenichi Ishibashi

Kirubel Aklilu added 1 comment

Patchset-level comments
File-level comment, Patchset 28 (Latest):
Kirubel Aklilu . resolved

bashi@ can you review the changes in:

  • chrome/browser/net
  • net/
  • services/network
Open in Gerrit

Related details

Attention is currently required from:
  • Kenichi Ishibashi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0351619dd695e713f853d3ab594924cd02dca982
Gerrit-Change-Number: 7042523
Gerrit-PatchSet: 28
Gerrit-Owner: Kirubel Aklilu <kak...@chromium.org>
Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
Gerrit-Reviewer: David Schinazi <dsch...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
Gerrit-CC: Awad Osman <aw...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Javier Castro <jaca...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Varun Khaneja <va...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Comment-Date: Sun, 02 Nov 2025 23:42:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenichi Ishibashi (Gerrit)

unread,
Nov 4, 2025, 12:28:14 AM (3 days ago) Nov 4
to Kirubel Aklilu, David Schinazi, Andrew Williams, Awad Osman, Nikhil Nayunigari, Javier Castro, Peter Beverloo, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jonmann+wa...@chromium.org, chadduffin+w...@chromium.org, stevenjb+wa...@chromium.org, hsuregan+wa...@chromium.org, ejcaruso+wa...@chromium.org, khorimoto+w...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, rrsilva+wat...@google.com, asvitkine...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, net-r...@chromium.org, network-ser...@chromium.org, srahim...@chromium.org
Attention needed from Kirubel Aklilu

Kenichi Ishibashi added 1 comment

Patchset-level comments
Kenichi Ishibashi . resolved

I looked at the design document. I want to understand more, especially implications and alternatives for adding more per-profile things in global instances such as HostResolverManager.

Open in Gerrit

Related details

Attention is currently required from:
  • Kirubel Aklilu
Gerrit-Attention: Kirubel Aklilu <kak...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Nov 2025 05:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenichi Ishibashi (Gerrit)

unread,
Nov 5, 2025, 7:22:48 PM (2 days ago) Nov 5
to Kirubel Aklilu, David Schinazi, Andrew Williams, Awad Osman, Nikhil Nayunigari, Javier Castro, Peter Beverloo, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, jonmann+wa...@chromium.org, chadduffin+w...@chromium.org, stevenjb+wa...@chromium.org, hsuregan+wa...@chromium.org, ejcaruso+wa...@chromium.org, khorimoto+w...@chromium.org, jackshira+w...@google.com, jiajunz+wa...@google.com, rrsilva+wat...@google.com, asvitkine...@chromium.org, bnc+...@chromium.org, croissant-...@chromium.org, cros-setti...@google.com, net-r...@chromium.org, network-ser...@chromium.org, srahim...@chromium.org
Attention needed from Kirubel Aklilu

Kenichi Ishibashi added 2 comments

Patchset-level comments
Kenichi Ishibashi . resolved

Overall looks great! I suggest to split this large CL into separate ones, for example, one for adding kAddAutomaticWithDohFallbackMode and one for pref stuff in chrome/browser.

File net/dns/dns_client.cc
Line 74, Patchset 28 (Latest): return;
Kenichi Ishibashi . unresolved

Don't we need to record histograms at lines 142-145?

Open in Gerrit

Related details

Attention is currently required from:
  • Kirubel Aklilu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0351619dd695e713f853d3ab594924cd02dca982
    Gerrit-Change-Number: 7042523
    Gerrit-PatchSet: 28
    Gerrit-Owner: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Reviewer: Andrew Williams <awi...@chromium.org>
    Gerrit-Reviewer: David Schinazi <dsch...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-CC: Awad Osman <aw...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Javier Castro <jaca...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Varun Khaneja <va...@chromium.org>
    Gerrit-Attention: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Comment-Date: Thu, 06 Nov 2025 00:22:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages