Return early in the `checkPendingEventExpectation` to avoid timeouts. [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Danil Somsikov (Gerrit)

unread,
Mar 2, 2026, 6:57:37 AM (yesterday) Mar 2
to Liviu Rau, AyeAye, devtools-rev...@chromium.org
Attention needed from Liviu Rau

Danil Somsikov voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Liviu Rau
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I58fbb74b2c7733eccadd8fad0090f018367541f3
Gerrit-Change-Number: 7622857
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>
Gerrit-Attention: Liviu Rau <livi...@chromium.org>
Gerrit-Comment-Date: Mon, 02 Mar 2026 11:57:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Danil Somsikov (Gerrit)

unread,
5:36 AM (9 hours ago) 5:36 AM
to Devtools-frontend LUCI CQ, Liviu Rau, AyeAye, devtools-rev...@chromium.org
Attention needed from Liviu Rau

Danil Somsikov voted and added 1 comment

Votes added by Danil Somsikov

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Danil Somsikov . resolved

Friendly ping:)

Open in Gerrit

Related details

Attention is currently required from:
  • Liviu Rau
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I58fbb74b2c7733eccadd8fad0090f018367541f3
Gerrit-Change-Number: 7622857
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Liviu Rau <livi...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 10:36:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Liviu Rau (Gerrit)

unread,
10:30 AM (4 hours ago) 10:30 AM
to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Liviu Rau voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I58fbb74b2c7733eccadd8fad0090f018367541f3
Gerrit-Change-Number: 7622857
Gerrit-PatchSet: 1
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Liviu Rau <livi...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Mar 2026 15:30:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
11:22 AM (3 hours ago) 11:22 AM
to Danil Somsikov, Liviu Rau, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Change information

Commit message:
Return early in the `checkPendingEventExpectation` to avoid timeouts.
Bug: 477570386
Change-Id: I58fbb74b2c7733eccadd8fad0090f018367541f3
Commit-Queue: Liviu Rau <livi...@chromium.org>
Auto-Submit: Danil Somsikov <d...@chromium.org>
Reviewed-by: Liviu Rau <livi...@chromium.org>
Files:
  • M front_end/ui/visual_logging/Debugging.ts
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Liviu Rau
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I58fbb74b2c7733eccadd8fad0090f018367541f3
Gerrit-Change-Number: 7622857
Gerrit-PatchSet: 2
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages