[Extensions] Promisify chrome.devtools.panels namespace [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Justin Lulejian (Gerrit)
1:13 PM (3 hours ago) 1:13 PM
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Justin Lulejian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Justin Lulejian . resolved
Hi Philip! This is the chrome.devtools.panels part of the promisification.
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Lulejian (Gerrit)
1:13 PM (3 hours ago) 1:13 PM
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Justin Lulejian voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Lulejian (Gerrit)
1:15 PM (2 hours ago) 1:15 PM
to Philip Pfaffe, devtools-fro...@luci-project-accounts.iam.gserviceaccount.com, devtools-rev...@chromium.org
Attention needed from Philip Pfaffe
Justin Lulejian added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Justin Lulejian . unresolved
I believe this should complete the promisification of the chrome.devtools API, however if I've missed any method or sub-method please point them out and I'll cover them in a follow-up CL. If there aren't any feel free to resolve this comment as a confirmation.
Related details
Attention is currently required from:
- Philip Pfaffe
Submit Requirements:
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages