Support NavigateToDevtoolsPanel test on Android [chromium/src : main]

0 views

Skip to first unread message

Hidehiko Abe (Gerrit)

unread,

Mar 23, 2026, 9:41:07 PM (9 hours ago) Mar 23

to James Cook, chromium...@chromium.org, devtools...@chromium.org

Attention needed from James Cook

Hidehiko Abe added 3 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Hidehiko Abe . resolved

PTAL.

File chrome/browser/devtools/devtools_browsertest.cc

Line 390, Patchset 1 (Latest): base::BindLambdaForTesting([this]() { window_ = nullptr; }));

Hidehiko Abe . resolved

note: to avoid UAF.

Line 414, Patchset 1 (Latest): BrowserWindowInterface* browser_window_interface() {

Hidehiko Abe . unresolved

borrowed from ExtensionBrowserTest. Should we have test utilities somewhere to share the impl?
Also,
Q: do we have reasons why we have a alias of NavigateToURL? Maybe we should just use chrome_test_utils::NavigateToURL directly?

Open in Gerrit

Related details

Attention is currently required from:

James Cook

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages