Add the new "Layerize" devtools timeline event (chromium side) [chromium/src : main]

Philip Rogers (Gerrit)

unread,

Dec 20, 2022, 2:38:31 PM12/20/22

to Yang Guo, Paul Irish, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, Jack Franklin

Attention is currently required from: Paul Irish, Yang Guo.

Philip Rogers would like Yang Guo and Paul Irish to review this change.

View Change

Add the new "Layerize" devtools timeline event (chromium side)

Layerize is the step of the rendering pipeline where we decide which
layers to create [1]. It is the second most expensive step in the
pipeline [2] which is why it is important to not have it show a blank
space on the devtools timeline. This event is also actionable using the
"Layers" panel, or other knowledge of what "creates a layer".

This is a followup to a front-end patch:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4117136

This patch implements the code to emit the new layerize event. This is
recorded alongside the UMA event that the team uses to track
performance of this function (that UMA metric is unfortunately called
CompositingCommit).

[1] https://developer.chrome.com/articles/renderingng-architecture/
[2] https://uma.googleplex.com/p/chrome/timeline_v2?sid=d57f93f88aad2b81484351dca9cd716f

Bug: 1191032
Change-Id: If834ac65d55482fe7406652a97d5c17a6f7973e8
---
M third_party/blink/renderer/core/frame/local_frame_view.cc
M third_party/blink/renderer/core/inspector/inspector_trace_events.cc
M third_party/blink/renderer/core/inspector/inspector_trace_events.h
A third_party/blink/web_tests/http/tests/devtools/tracing/timeline-paint/timeline-layerize-expected.txt
A third_party/blink/web_tests/http/tests/devtools/tracing/timeline-paint/timeline-layerize.js
5 files changed, 90 insertions(+), 0 deletions(-)

To view, visit change 4118117. To unsubscribe, or for help writing mail filters, visit settings.

Philip Rogers (Gerrit)

unread,

Dec 20, 2022, 2:41:26 PM12/20/22

to blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, Paul Irish, Yang Guo, Jack Franklin, Chromium LUCI CQ, David Bokan, chromium...@chromium.org

Attention is currently required from: Paul Irish, Yang Guo.

View Change

1 comment:

Patchset:
- Patch Set #2:
  Paul or Yang, would either of you be good reviewers for this and the front-end patch (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4117136)?

To view, visit change 4118117. To unsubscribe, or for help writing mail filters, visit settings.

Philip Rogers (Gerrit)

unread,

Dec 22, 2022, 1:32:08 PM12/22/22

to Xianzhu Wang, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org

Attention is currently required from: Xianzhu Wang.

Philip Rogers would like Xianzhu Wang to review this change.

View Change

Add the new "Layerize" devtools timeline event (chromium side)

Layerize is the step of the rendering pipeline where we decide which
layers to create [1]. It is the second most expensive step in the
pipeline [2] which is why it is important to not have it show a blank
space on the devtools timeline. This event is also actionable using the
"Layers" panel, or other knowledge of what "creates a layer".

This is a followup to a front-end patch:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4117136

This patch implements the code to emit the new layerize event. This is
recorded alongside the UMA event that the team uses to track
performance of this function (that UMA metric is unfortunately called
CompositingCommit).

[1] https://developer.chrome.com/articles/renderingng-architecture/
[2] https://uma.googleplex.com/p/chrome/timeline_v2?sid=d57f93f88aad2b81484351dca9cd716f

Bug: 1191032

Change-Id: If232c0c10d57a5393e7428ea84eaed7257d69765


---
M third_party/blink/renderer/core/frame/local_frame_view.cc
M third_party/blink/renderer/core/inspector/inspector_trace_events.cc
M third_party/blink/renderer/core/inspector/inspector_trace_events.h

3 files changed, 40 insertions(+), 0 deletions(-)

To view, visit change 4118927. To unsubscribe, or for help writing mail filters, visit settings.

Philip Rogers (Gerrit)

unread,

Dec 22, 2022, 1:34:48 PM12/22/22

to blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, Xianzhu Wang, David Bokan, chromium...@chromium.org

Attention is currently required from: Xianzhu Wang.

Patch set 3:Commit-Queue +1

View Change

To view, visit change 4118927. To unsubscribe, or for help writing mail filters, visit settings.

Xianzhu Wang (Gerrit)

unread,

Dec 22, 2022, 1:36:08 PM12/22/22

to Philip Rogers, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, Chromium LUCI CQ, David Bokan, chromium...@chromium.org

Attention is currently required from: Philip Rogers.

Patch set 3:Code-Review +1

View Change

To view, visit change 4118927. To unsubscribe, or for help writing mail filters, visit settings.

Philip Rogers (Gerrit)

unread,

Dec 22, 2022, 3:16:40 PM12/22/22

to blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, Xianzhu Wang, Chromium LUCI CQ, David Bokan, chromium...@chromium.org

Attention is currently required from: Philip Rogers.

Patch set 3:Commit-Queue +2

View Change

To view, visit change 4118927. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Dec 22, 2022, 3:31:23 PM12/22/22

to Philip Rogers, blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, Xianzhu Wang, David Bokan, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Xianzhu Wang: Looks good to me
  Philip Rogers: Commit

Add the new "Layerize" devtools timeline event (chromium side)

Layerize is the step of the rendering pipeline where we decide which
layers to create [1]. It is the second most expensive step in the
pipeline [2] which is why it is important to not have it show a blank
space on the devtools timeline. This event is also actionable using the
"Layers" panel, or other knowledge of what "creates a layer".

This is a followup to a front-end patch:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4117136

This patch implements the code to emit the new layerize event. This is
recorded alongside the UMA event that the team uses to track
performance of this function (that UMA metric is unfortunately called
CompositingCommit).

[1] https://developer.chrome.com/articles/renderingng-architecture/
[2] https://uma.googleplex.com/p/chrome/timeline_v2?sid=d57f93f88aad2b81484351dca9cd716f

Bug: 1191032
Change-Id: If232c0c10d57a5393e7428ea84eaed7257d69765

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4118927
Reviewed-by: Xianzhu Wang <wangx...@chromium.org>
Commit-Queue: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1086503}


---
M third_party/blink/renderer/core/frame/local_frame_view.cc
M third_party/blink/renderer/core/inspector/inspector_trace_events.cc
M third_party/blink/renderer/core/inspector/inspector_trace_events.h

3 files changed, 44 insertions(+), 0 deletions(-)

To view, visit change 4118927. To unsubscribe, or for help writing mail filters, visit settings.

Philip Rogers (Gerrit)

unread,

Dec 26, 2022, 11:11:45 AM12/26/22

to blink-revi...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, devtools...@chromium.org, Paul Irish, Yang Guo, Jack Franklin, Chromium LUCI CQ, David Bokan, chromium...@chromium.org

Philip Rogers abandoned this change.

View Change

Abandoned

To view, visit change 4118117. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward