Fix attaching to worklet twice [chromium/src : main]
0 views
Skip to first unread message
Andrey Kosyakov (Gerrit)
Dec 22, 2025, 11:10:26 PM (3 days ago) Dec 22
to Peter Kvitek, Maksim Sadym, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Maksim Sadym and Peter Kvitek
Andrey Kosyakov added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/inspector/worker_inspector_controller.cc
Line 138, Patchset 1 (Latest):
inspector_agents_.insert(session, inspector_agent);Andrey Kosyakov . resolved
Right now we do not dispatch `Inspector.workerLoaded`, but we'll add this as a follow-up for consistency wrt workers.
Related details
Attention is currently required from:
- Maksim Sadym
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Maksim Sadym (Gerrit)
Dec 23, 2025, 8:34:48 AM (3 days ago) Dec 23
to Andrey Kosyakov, Peter Kvitek, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrey Kosyakov and Peter Kvitek
Maksim Sadym voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Andrey Kosyakov
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Dec 23, 2025, 4:02:53 PM (3 days ago) Dec 23
to Maksim Sadym, Peter Kvitek, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Peter Kvitek
Andrey Kosyakov voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Peter Kvitek
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 23, 2025, 4:07:15 PM (3 days ago) Dec 23
to Andrey Kosyakov, Maksim Sadym, Peter Kvitek, AyeAye, chromium...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix attaching to worklet twice
Fixed: 469479959
Change-Id: Ibe49b1f30b1c55c68dcd4f8202fa848f168e12b6
Reviewed-by: Maksim Sadym <sa...@chromium.org>
Commit-Queue: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1562313}
Files:
- M third_party/blink/renderer/core/inspector/inspector_inspector_agent.cc
- M third_party/blink/renderer/core/inspector/inspector_inspector_agent.h
- M third_party/blink/renderer/core/inspector/worker_inspector_controller.cc
- A third_party/blink/web_tests/http/tests/inspector-protocol/two-sessions-one-worklet-expected.txt
- A third_party/blink/web_tests/http/tests/inspector-protocol/two-sessions-one-worklet.js
Change size: M
Delta: 5 files changed, 50 insertions(+), 13 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Maksim Sadym
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages