[lighthouse] Use CDPConnection instead of parallel connection [devtools/devtools-frontend : main]
0 views
Skip to first unread message
Simon Zünd (Gerrit)
Nov 3, 2025, 9:32:28 AM (2 days ago) Nov 3
to Connor Clark, Paul Irish, AyeAye, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org, lighthouse-en...@google.com
Attention needed from Connor Clark and Paul Irish
Simon Zünd added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Simon Zünd . resolved
Polished the CL and I think this is good to land. Today we already switched over the "Recording player" in the recorder panel. So LH is the last user of the "parallel connection" thing. PTAL and let me know what you think.
Related details
Attention is currently required from:
- Connor Clark
- Paul Irish
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Connor Clark (Gerrit)
Nov 3, 2025, 4:19:09 PM (2 days ago) Nov 3
to Simon Zünd, Paul Irish, AyeAye, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org, lighthouse-en...@google.com
Attention needed from Paul Irish and Simon Zünd
Connor Clark voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Paul Irish
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Paul Irish (Gerrit)
Nov 3, 2025, 5:43:28 PM (2 days ago) Nov 3
to Simon Zünd, Connor Clark, AyeAye, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org, lighthouse-en...@google.com
Attention needed from Simon Zünd
Paul Irish voted and added 2 comments![]( "Open in Gerrit")
Votes added by Paul Irish
| Code-Review | +1 |
2 comments
Patchset-level comments
Paul Irish . resolved
Thanks for sorting this out!
File front_end/panels/lighthouse/LighthouseProtocolService.ts
Line 44, Patchset 7 (Latest):
* - All messages over the CDPConnection speak pure CDP.Paul Irish . resolved
appreciate these updates! :)
Related details
Attention is currently required from:
- Simon Zünd
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simon Zünd (Gerrit)
Nov 4, 2025, 12:09:16 AM (yesterday) Nov 4
to Paul Irish, Connor Clark, AyeAye, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org, lighthouse-en...@google.com
Simon Zünd voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devtools-frontend LUCI CQ (Gerrit)
Nov 4, 2025, 12:11:46 AM (yesterday) Nov 4
to Simon Zünd, Paul Irish, Connor Clark, AyeAye, devtools-rev...@chromium.org, lighthouse-en...@google.com
Devtools-frontend LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[lighthouse] Use CDPConnection instead of parallel connection
Both on the frontend-side and the worker-side, this CL updates
Lighthouse to use the new CDPConnection.
On the frontend-side, we create a new CDP session and then use
the standard CDPConnection to send/receive messages, which
are forwarded nearly 1:1 to the worker.
On the worker-side, we create a custom transport with
a CDPConnection, and then wrap it with the new puppeteer
adapter.
Bug: 453469270
Change-Id: I737816f4ce657210079413ba888e9c26897dac82
Reviewed-by: Connor Clark <cja...@chromium.org>
Reviewed-by: Paul Irish <paul...@chromium.org>
Commit-Queue: Simon Zünd <szu...@chromium.org>
Files:
- M front_end/entrypoints/lighthouse_worker/BUILD.gn
- M front_end/entrypoints/lighthouse_worker/LighthouseWorkerService.ts
- M front_end/panels/lighthouse/BUILD.gn
- M front_end/panels/lighthouse/LighthouseProtocolService.test.ts
- M front_end/panels/lighthouse/LighthouseProtocolService.ts
Change size: M
Delta: 5 files changed, 86 insertions(+), 77 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Paul Irish, +1 by Connor Clark
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages