Remove IPH code [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Kim-Anh Tran (Gerrit)

unread,
3:46 AM (11 hours ago) 3:46 AM
to Kateryna Prokopenko, Jack Franklin, Devtools-frontend LUCI CQ, devtools-rev...@chromium.org
Attention needed from Jack Franklin and Kateryna Prokopenko

Kim-Anh Tran added 2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kim-Anh Tran . resolved

Hi Kateryna,

I'm removing the code for IPH in the front-end, PTAL!


Hi Jack,

please see the comment on `BaseInsightComponent`!

File front_end/panels/timeline/components/insights/BaseInsightComponent.ts
Line 413, Patchset 3 (Latest): const ariaLabel = `Ask AI about ${insightModel.title} insight`;
Kim-Anh Tran . unresolved

@jacktf...@chromium.org Hi Jack, I changed this to explicitly be `Ask AI` since it otherwise doesn't read well, but let me know if this should be changed.

Open in Gerrit

Related details

Attention is currently required from:
  • Jack Franklin
  • Kateryna Prokopenko
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: Id3262cd5d68c125ec4e0b9f218f1c91f817c9c32
Gerrit-Change-Number: 7207420
Gerrit-PatchSet: 3
Gerrit-Owner: Kim-Anh Tran <kim...@chromium.org>
Gerrit-Reviewer: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-CC: Jack Franklin <jacktf...@chromium.org>
Gerrit-Attention: Kateryna Prokopenko <kprok...@chromium.org>
Gerrit-Attention: Jack Franklin <jacktf...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 08:46:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages