Support getFormatLocalizedString in the imperative API lint rule [devtools/devtools-frontend : main]

0 views

Skip to first unread message

Kim-Anh Tran (Gerrit)

unread,

12:39 AM (13 hours ago) 12:39 AM

to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org

Attention needed from Danil Somsikov

Kim-Anh Tran voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Danil Somsikov

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Danil Somsikov (Gerrit)

unread,

3:44 AM (10 hours ago) 3:44 AM

to Kim-Anh Tran, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org

Danil Somsikov voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,

4:12 AM (9 hours ago) 4:12 AM

to Danil Somsikov, Kim-Anh Tran, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Support getFormatLocalizedString in the imperative API lint rule

Bug: 407749531

Change-Id: I90eda687f83d985a00bfa59e06900f36b2d5c0e5

Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7205975

Commit-Queue: Danil Somsikov <d...@chromium.org>

Auto-Submit: Danil Somsikov <d...@chromium.org>

Reviewed-by: Kim-Anh Tran <kim...@chromium.org>

Files:

M scripts/eslint_rules/lib/no-imperative-dom-api.ts
M scripts/eslint_rules/lib/no-imperative-dom-api/dom-fragment.ts
A scripts/eslint_rules/lib/no-imperative-dom-api/i18n.ts
M scripts/eslint_rules/lib/no-imperative-dom-api/ui-fragment.ts
M scripts/eslint_rules/tests/no-imperative-dom-api.test.ts

Change size: M

Delta: 5 files changed, 93 insertions(+), 7 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Kim-Anh Tran

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages