Support getFormatLocalizedString in the imperative API lint rule [devtools/devtools-frontend : main]

0 views
Skip to first unread message

Kim-Anh Tran (Gerrit)

unread,
12:39 AM (13 hours ago) 12:39 AM
to Danil Somsikov, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org
Attention needed from Danil Somsikov

Kim-Anh Tran voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Danil Somsikov
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I90eda687f83d985a00bfa59e06900f36b2d5c0e5
Gerrit-Change-Number: 7205975
Gerrit-PatchSet: 2
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Attention: Danil Somsikov <d...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Dec 2025 05:39:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Danil Somsikov (Gerrit)

unread,
3:44 AM (10 hours ago) 3:44 AM
to Kim-Anh Tran, Devtools-frontend LUCI CQ, AyeAye, devtools-rev...@chromium.org

Danil Somsikov voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I90eda687f83d985a00bfa59e06900f36b2d5c0e5
Gerrit-Change-Number: 7205975
Gerrit-PatchSet: 3
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Kim-Anh Tran <kim...@chromium.org>
Gerrit-CC: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Comment-Date: Mon, 01 Dec 2025 08:44:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Devtools-frontend LUCI CQ (Gerrit)

unread,
4:12 AM (9 hours ago) 4:12 AM
to Danil Somsikov, Kim-Anh Tran, AyeAye, devtools-rev...@chromium.org

Devtools-frontend LUCI CQ submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Support getFormatLocalizedString in the imperative API lint rule 
Bug: 407749531
Change-Id: I90eda687f83d985a00bfa59e06900f36b2d5c0e5
Commit-Queue: Danil Somsikov <d...@chromium.org>
Auto-Submit: Danil Somsikov <d...@chromium.org>
Reviewed-by: Kim-Anh Tran <kim...@chromium.org>
Files:
  • M scripts/eslint_rules/lib/no-imperative-dom-api.ts
  • M scripts/eslint_rules/lib/no-imperative-dom-api/dom-fragment.ts
  • A scripts/eslint_rules/lib/no-imperative-dom-api/i18n.ts
  • M scripts/eslint_rules/lib/no-imperative-dom-api/ui-fragment.ts
  • M scripts/eslint_rules/tests/no-imperative-dom-api.test.ts
Change size: M
Delta: 5 files changed, 93 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kim-Anh Tran
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: devtools/devtools-frontend
Gerrit-Branch: main
Gerrit-Change-Id: I90eda687f83d985a00bfa59e06900f36b2d5c0e5
Gerrit-Change-Number: 7205975
Gerrit-PatchSet: 4
Gerrit-Owner: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Danil Somsikov <d...@chromium.org>
Gerrit-Reviewer: Devtools-frontend LUCI CQ <devtools-fro...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages