[webauthn] Expose null signature counter to CDP [chromium/src : main]
0 views
Skip to first unread message
Nina Satragno (Gerrit)
Jul 24, 2026, 12:28:04 PM (2 days ago) Jul 24
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Andrey Kosyakov
Nina Satragno added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Nina Satragno . resolved
Andrey, please take a look. Thank you! ^_^
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Jul 24, 2026, 2:31:09 PM (2 days ago) Jul 24
to Nina Satragno, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Attention needed from Nina Satragno
Andrey Kosyakov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
1 comment
File content/browser/devtools/protocol/webauthn_handler.cc
Line 433, Patchset 5 (Latest):
// -1 is a special value to mean no signature counter.Andrey Kosyakov . unresolved
I'm a bit confused that not passing a signature counter does not mean "no signature counter" :-)
Related details
Attention is currently required from:
- Nina Satragno
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nina Satragno (Gerrit)
Jul 24, 2026, 2:37:41 PM (2 days ago) Jul 24
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Nina Satragno voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nina Satragno
| Commit-Queue | +2 |
1 comment
File content/browser/devtools/protocol/webauthn_handler.cc
Line 433, Patchset 5 (Latest):
// -1 is a special value to mean no signature counter.Andrey Kosyakov . resolved
I'm a bit confused that not passing a signature counter does not mean "no signature counter" :-)
Nina Satragno
It's for backwards compatibility. When I designed this API, every real authenticator had a signature counter so if you didn't set it, you got one that counted from one. Then the industry shipped syncing authenticators (passkeys) that set the signature counter to zero all the time (i.e. they don't have one), and developers wanted a way to test that behaviour. But we don't want to break existing tests, hence this design.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 24, 2026, 2:42:39 PM (2 days ago) Jul 24
to Nina Satragno, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[webauthn] Expose null signature counter to CDP
Expand WebAuthn virtual authenticator CDP commands to support setting a
null signature counter, and add support for modifying an existing
signature counter. This will be used to support an upgrade to the
WebAuthn webdriver commands.
Since CDP doesn't seem to support differentiating between an
integer value being missing or null, use -1 as a sentinel value to
indicate a counter missing. Webdriver will map null to -1.
See https://github.com/w3c/webauthn/pull/2382
TAG=agy
CONV=8a5aa474-7c70-4d3f-9d13-59d4a45e6971
Bug: 533056772
Change-Id: I18e8f9b58181274caef89ec3963a221fbc80c40e
Commit-Queue: Nina Satragno <nsat...@chromium.org>
Reviewed-by: Andrey Kosyakov <ca...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1668046}
Files:
- M content/browser/devtools/protocol/webauthn_handler.cc
- M content/browser/devtools/protocol/webauthn_handler.h
- M third_party/blink/public/devtools_protocol/domains/WebAuthn.pdl
- M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/resources/webauthn-test.https.html
- M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-errors-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-errors.js
- M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-add-credential-expected.txt
- M third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-get-credentials-expected.txt
- A third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-sign-count-expected.txt
- A third_party/blink/web_tests/http/tests/inspector-protocol/webauthn/webauthn-sign-count.js
Change size: M
Delta: 10 files changed, 165 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Andrey Kosyakov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
luci-bisection@appspot.gserviceaccount.com (Gerrit)
Jul 24, 2026, 4:51:33 PM (2 days ago) Jul 24
to Chromium LUCI CQ, Nina Satragno, Andrey Kosyakov, chromium...@chromium.org, devtools...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org
luci-bi...@appspot.gserviceaccount.com has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages