[Autofill] IWYU for //components/autofill/core/browser [chromium/src : main]

0 views

Skip to first unread message

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 6:07:27 PMMay 14

to chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 6:34:57 PMMay 14

to Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 6:58:05 PMMay 14

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 7:10:50 PMMay 14

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 7:15:43 PMMay 14

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 7:16:14 PMMay 14

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 7:30:29 PMMay 14

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 7:47:06 PMMay 14

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 7:59:35 PMMay 14

Attention needed from Christoph Schwering

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 8:16:10 PMMay 14

to Dominic Battré, Mohamed Amir Yosef, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Attention needed from Dominic Battré and Mohamed Amir Yosef

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Dominic Battré
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 8:16:28 PMMay 14

Attention needed from Christoph Schwering, Dominic Battré and Mohamed Amir Yosef

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Dominic Battré
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 8:31:46 PMMay 14

to android-bu...@system.gserviceaccount.com, Dominic Battré, Mohamed Amir Yosef, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, marq+...@chromium.org, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Attention needed from Christoph Schwering, Dominic Battré and Mohamed Amir Yosef

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering
Dominic Battré
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 8:44:05 PMMay 14

Attention needed from Christoph Schwering, Dominic Battré and Mohamed Amir Yosef

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering
Dominic Battré
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 14, 2026, 8:59:28 PMMay 14

Attention needed from Christoph Schwering, Dominic Battré and Mohamed Amir Yosef

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering
Dominic Battré
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 15, 2026, 3:08:16 AMMay 15

Attention needed from Dominic Battré and Mohamed Amir Yosef

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Dominic Battré
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

SLSA Policy Verification Service (Gerrit)

unread,

May 15, 2026, 3:10:50 AMMay 15

Attention needed from Dominic Battré and Mohamed Amir Yosef

SLSA Policy Verification Service voted SLSA-Policy-Verified+1

SLSA-Policy-Verified

Open in Gerrit

Related details

Attention is currently required from:

Dominic Battré
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Battré (Gerrit)

unread,

May 15, 2026, 3:12:18 AMMay 15

to SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, Mohamed Amir Yosef, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, marq+...@chromium.org, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Attention needed from Mohamed Amir Yosef

Dominic Battré added 2 comments

File chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc

Line 130, Patchset 14: CHECK(interaction_stats_.username_value == stats->username_value);

Dominic Battré . resolved

Let's try to revert these afterwards. This is surprising to me. components/password_manager/core/browser/password_store/interactions_stats.h misses an `#include <string>`.

File components/autofill/core/browser/crowdsourcing/randomized_encoder.h

Line 8, Patchset 14:#include <cstddef>

Dominic Battré . unresolved

I wonder where this comes from.

Open in Gerrit

Related details

Attention is currently required from:

Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Battré (Gerrit)

unread,

May 15, 2026, 3:22:48 AMMay 15

Attention needed from Christoph Schwering and Mohamed Amir Yosef

Dominic Battré voted and added 1 comment

Votes added by Dominic Battré

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 16 (Latest):

Dominic Battré . resolved

I don't understand the #include <cstddef> and #include <cstdint> because I think that they give us std::size_t instead of size_t and std::int64_t instead of int64_t. We can look into this asynchronously.

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering
Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christoph Schwering (Gerrit)

unread,

May 15, 2026, 3:24:43 AMMay 15

to Dominic Battré, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, Mohamed Amir Yosef, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, marq+...@chromium.org, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Attention needed from Mohamed Amir Yosef

Christoph Schwering added 2 comments

File chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc

Line 130, Patchset 14: CHECK(interaction_stats_.username_value == stats->username_value);

Dominic Battré . resolved

Let's try to revert these afterwards. This is surprising to me. components/password_manager/core/browser/password_store/interactions_stats.h misses an `#include <string>`.

Christoph Schwering

I can give it another try afterwards.

components/password_manager/core/browser/password_store/interactions_stats.h misses an #include <string

I had added that include manually in my attempts to make the CHECK work, and didn't remove it to avoid another bot run.

File components/autofill/core/browser/crowdsourcing/randomized_encoder.h

Line 8, Patchset 14:#include <cstddef>

Dominic Battré . resolved

I wonder where this comes from.

Christoph Schwering

Discussed offline: from `size_t`, but it should be `stddef.h`. I'd prefer fixing this in a followup to avoid another bot run.

Open in Gerrit

Related details

Attention is currently required from:

Mohamed Amir Yosef

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christoph Schwering (Gerrit)

unread,

May 15, 2026, 3:30:15 AMMay 15

Attention needed from Mohamed Amir Yosef

Christoph Schwering added 1 comment

File chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc

Line 130, Patchset 14: CHECK(interaction_stats_.username_value == stats->username_value);

Dominic Battré . resolved

Let's try to revert these afterwards. This is surprising to me. components/password_manager/core/browser/password_store/interactions_stats.h misses an `#include <string>`.

Christoph Schwering

I can give it another try afterwards.
components/password_manager/core/browser/password_store/interactions_stats.h misses an #include <string
I had added that include manually in my attempts to make the CHECK work, and didn't remove it to avoid another bot run.

Christoph Schwering

components/password_manager/core/browser/password_store/interactions_stats.h misses an #include <string
I had added that include manually in my attempts to make the CHECK work, and didn't remove it to avoid another bot run.

I responded too quickly. The include I was referring to is `#include <string>` in `chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc`, which isn't necessary.

`components/password_manager/core/browser/password_store/interactions_stats.h` actually contains and should contain an `#include <string>`.

satisfied_requirement

unsatisfied_requirement

open

diffy

Christoph Schwering (Gerrit)

unread,

May 15, 2026, 3:30:58 AMMay 15

Attention needed from Mohamed Amir Yosef

Christoph Schwering voted Auto-Submit+1

Auto-Submit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dominic Battré (Gerrit)

unread,

May 15, 2026, 3:34:07 AMMay 15

Attention needed from Christoph Schwering and Mohamed Amir Yosef

Dominic Battré added 1 comment

File chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc

Line 130, Patchset 14: CHECK(interaction_stats_.username_value == stats->username_value);

Dominic Battré . resolved

Let's try to revert these afterwards. This is surprising to me. components/password_manager/core/browser/password_store/interactions_stats.h misses an `#include <string>`.

Christoph Schwering

I can give it another try afterwards.
components/password_manager/core/browser/password_store/interactions_stats.h misses an #include <string
I had added that include manually in my attempts to make the CHECK work, and didn't remove it to avoid another bot run.

Christoph Schwering

components/password_manager/core/browser/password_store/interactions_stats.h misses an #include <string
I had added that include manually in my attempts to make the CHECK work, and didn't remove it to avoid another bot run.
I responded too quickly. The include I was referring to is `#include <string>` in `chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc`, which isn't necessary.
`components/password_manager/core/browser/password_store/interactions_stats.h` actually contains and should contain an `#include <string>`.

Dominic Battré

https://source.chromium.org/chromium/chromium/src/+/main:components/password_manager/core/browser/password_store/interactions_stats.h;drc=a8f56567951a7413780be19fabb2bfc7a7426bf3 does not show me an `#include <string>`.

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering
Mohamed Amir Yosef

satisfied_requirement

unsatisfied_requirement

open

diffy

Mohamed Amir Yosef (Gerrit)

unread,

May 15, 2026, 3:45:52 AMMay 15

to Dominic Battré, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, marq+...@chromium.org, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Attention needed from Christoph Schwering

Mohamed Amir Yosef voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Christoph Schwering

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 15, 2026, 3:50:22 AMMay 15

to Mohamed Amir Yosef, Dominic Battré, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, Akihiro Ota, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, marq+...@chromium.org, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[Autofill] IWYU for //components/autofill/core/browser

TLDR: This CL only affects #includes except two trivial non-#include
changes (see (3) and (4) below).

This CL applies clang-include-cleaner to the production-code C++ files
in //components/autofill/core/browser.

(This is a by-product of generating a dependency graph in preparation
of crbug.com/489636471.)

Afterwards, I applied the following steps manually:

(1) Since clang-include-cleaner used the wrong include paths for some
sources in third_party (abseil, icu, libaddress, libphonenumber,
protobuf, re2, tflite), I fixed those paths manually.

(2) Due to now-missing transitive includes, I added the necessary
includes to tests and some files outside of
//components/autofill/core/browser.

(3) In autofill_structured_address_utils.cc, clang-include-cleaner
added a lot of Blink files for some reason. I cleaned this up manually.

(4) In PWM's save_update_bubble_controller.cc, I replaced a
CHECK_EQ(x, y) of two std::u16strings with a CHECK(x == y) because
CHECK_EQ(x, y) doesn't compile; I couldn't figure out the reason.

(5) In test_credit_card_save_strike_database.h, I added a forward
declaration to make the compiler happy.

(6) I moved new includes from a file in //components/payments and six
files in //ios to headers in //components/autofill to avoid reviews
in other timezones. I've added TODOs and will fix this in a followup
CL.

To validate the CL, I:
- Ran clang-include-cleaner a second time to confirm the results.
- Spot-checked the added and removed includes in >10 files.
- Checked that only includes are affected (% (3) and (4) above):
  $ git diff -U0 origin/main | \
    grep -E '^[+-]' | \
    grep -Ev '^(---|\+\+\+)' | \
    grep -Ev '^.(#include|#if|#endif|$)'

Bug: 489636471

Change-Id: I4fb58aa090369165ea173b18375b022957d36233

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7849414

Reviewed-by: Mohamed Amir Yosef <ma...@chromium.org>

SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritco...@google.com>

Auto-Submit: Christoph Schwering <schw...@google.com>

Commit-Queue: Mohamed Amir Yosef <ma...@chromium.org>

Reviewed-by: Dominic Battré <bat...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1631134}

Files:

M chrome/browser/autofill/actor/actor_form_filling_service_impl.cc
M chrome/browser/autofill/android/save_update_address_profile_prompt_controller_unittest.cc
M chrome/browser/browsing_data/counters/autofill_counter_browsertest.cc
M chrome/browser/compose/proactive_nudge_tracker.cc
M chrome/browser/devtools/protocol/autofill_handler.cc
M chrome/browser/password_manager/password_manager_util_win.cc
M chrome/browser/sync/test/integration/autofill_helper.cc
M chrome/browser/sync/test/integration/performance/autofill_sync_perf_test.cc
M chrome/browser/sync/test/integration/select_type_and_migrate_local_data_items_when_active_sync_test.cc
M chrome/browser/sync/test/integration/single_client_contact_info_sync_test.cc
M chrome/browser/ui/autofill/autofill_keyboard_accessory_controller_impl.cc
M chrome/browser/ui/autofill/update_address_bubble_controller_unittest.cc
M chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc
M chrome/browser/ui/views/autofill/address_editor_view_unittest.cc
M chrome/browser/ui/views/autofill/edit_address_profile_view_unittest.cc
M chrome/browser/ui/views/autofill/save_address_profile_view_unittest.cc
M chrome/browser/ui/views/message_box_dialog.cc
M chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
M chrome/browser/ui/webui/settings/saved_info_handler.cc
M components/autofill/content/browser/content_autofill_driver_factory.cc
M components/autofill/core/browser/at_memory/at_memory_data_type.cc
M components/autofill/core/browser/at_memory/at_memory_data_type.h
M components/autofill/core/browser/at_memory/at_memory_funnel_metrics.cc
M components/autofill/core/browser/at_memory/at_memory_manager.cc
M components/autofill/core/browser/at_memory/at_memory_manager.h
M components/autofill/core/browser/at_memory/autofill_data_provider_impl.cc
M components/autofill/core/browser/at_memory/autofill_data_provider_impl.h
M components/autofill/core/browser/at_memory_promo_tracker.cc
M components/autofill/core/browser/autofill_ai_form_rationalization.cc
M components/autofill/core/browser/autofill_ai_form_rationalization.h
M components/autofill/core/browser/autofill_browser_util.cc
M components/autofill/core/browser/autofill_feedback_data.cc
M components/autofill/core/browser/autofill_field.cc
M components/autofill/core/browser/autofill_field.h
M components/autofill/core/browser/autofill_format_string.cc
M components/autofill/core/browser/autofill_format_string.h
M components/autofill/core/browser/autofill_server_prediction.cc
M components/autofill/core/browser/autofill_server_prediction.h
M components/autofill/core/browser/autofill_trigger_source.cc
M components/autofill/core/browser/autofill_type.cc
M components/autofill/core/browser/autofill_type.h
M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_encoding.cc
M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_encoding.h
M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_manager.cc
M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_manager.h
M components/autofill/core/browser/crowdsourcing/determine_possible_field_types.cc
M components/autofill/core/browser/crowdsourcing/determine_possible_field_types.h
M components/autofill/core/browser/crowdsourcing/disambiguate_possible_field_types.cc
M components/autofill/core/browser/crowdsourcing/disambiguate_possible_field_types.h
M components/autofill/core/browser/crowdsourcing/randomized_encoder.cc
M components/autofill/core/browser/crowdsourcing/randomized_encoder.h
M components/autofill/core/browser/crowdsourcing/server_prediction_overrides.cc
M components/autofill/core/browser/crowdsourcing/votes_uploader.cc
M components/autofill/core/browser/crowdsourcing/votes_uploader.h
M components/autofill/core/browser/data_manager/addresses/account_name_email_store.cc
M components/autofill/core/browser/data_manager/addresses/account_name_email_store.h
M components/autofill/core/browser/data_manager/addresses/account_name_email_strike_manager.cc
M components/autofill/core/browser/data_manager/addresses/account_name_email_strike_manager.h
M components/autofill/core/browser/data_manager/addresses/address_data_cleaner.cc
M components/autofill/core/browser/data_manager/addresses/address_data_cleaner.h
M components/autofill/core/browser/data_manager/addresses/address_data_manager.cc
M components/autofill/core/browser/data_manager/addresses/address_data_manager.h
M components/autofill/core/browser/data_manager/addresses/address_data_manager_unittest.cc
M components/autofill/core/browser/data_manager/addresses/home_and_work_metadata_store.cc
M components/autofill/core/browser/data_manager/autofill_ai/entity_data_manager.cc
M components/autofill/core/browser/data_manager/autofill_ai/entity_data_manager.h
M components/autofill/core/browser/data_manager/autofill_ai/entity_instance_cleaner.cc
M components/autofill/core/browser/data_manager/payments/payments_data_manager.cc
M components/autofill/core/browser/data_manager/payments/payments_data_manager.h
M components/autofill/core/browser/data_manager/personal_data_manager.cc
M components/autofill/core/browser/data_manager/personal_data_manager.h
M components/autofill/core/browser/data_manager/valuables/valuables_data_manager.cc
M components/autofill/core/browser/data_manager/valuables/valuables_data_manager.h
M components/autofill/core/browser/data_model/addresses/address.cc
M components/autofill/core/browser/data_model/addresses/address.h
M components/autofill/core/browser/data_model/addresses/autofill_i18n_api.cc
M components/autofill/core/browser/data_model/addresses/autofill_i18n_api.h
M components/autofill/core/browser/data_model/addresses/autofill_i18n_api_unittest.cc
M components/autofill/core/browser/data_model/addresses/autofill_i18n_formatting_expressions.h
M components/autofill/core/browser/data_model/addresses/autofill_i18n_hierarchies.h
M components/autofill/core/browser/data_model/addresses/autofill_i18n_parsing_expression_components.cc
M components/autofill/core/browser/data_model/addresses/autofill_i18n_parsing_expression_components.h
M components/autofill/core/browser/data_model/addresses/autofill_i18n_parsing_expressions.h
M components/autofill/core/browser/data_model/addresses/autofill_normalization_utils.cc
M components/autofill/core/browser/data_model/addresses/autofill_normalization_utils.h
M components/autofill/core/browser/data_model/addresses/autofill_profile.cc
M components/autofill/core/browser/data_model/addresses/autofill_profile.h
M components/autofill/core/browser/data_model/addresses/autofill_profile_comparator.cc
M components/autofill/core/browser/data_model/addresses/autofill_profile_comparator.h
M components/autofill/core/browser/data_model/addresses/autofill_profile_comparator_unittest.cc
M components/autofill/core/browser/data_model/addresses/autofill_profile_unittest.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address.h
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_component.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_component.h
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_component_store.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_component_store.h
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_component_unittest.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_format_provider.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_format_provider.h
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_name.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_name.h
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_regex_provider.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_utils.cc
M components/autofill/core/browser/data_model/addresses/autofill_structured_address_utils.h
M components/autofill/core/browser/data_model/addresses/autofill_synthesized_address_component.cc
M components/autofill/core/browser/data_model/addresses/contact_info.cc
M components/autofill/core/browser/data_model/addresses/contact_info.h
M components/autofill/core/browser/data_model/addresses/phone_number.cc
M components/autofill/core/browser/data_model/addresses/phone_number.h
M components/autofill/core/browser/data_model/addresses/phone_number_unittest.cc
M components/autofill/core/browser/data_model/autofill_ai/country_info.cc
M components/autofill/core/browser/data_model/autofill_ai/date_info.cc
M components/autofill/core/browser/data_model/autofill_ai/date_info.h
M components/autofill/core/browser/data_model/autofill_ai/entity_instance.cc
M components/autofill/core/browser/data_model/autofill_ai/entity_instance.h
M components/autofill/core/browser/data_model/autofill_ai/entity_type.cc
M components/autofill/core/browser/data_model/autofill_ai/entity_type.h
M components/autofill/core/browser/data_model/autofill_ai/from_accessibility_annotator.cc
M components/autofill/core/browser/data_model/autofill_ai/from_accessibility_annotator.h
M components/autofill/core/browser/data_model/data_model_utils.cc
M components/autofill/core/browser/data_model/data_model_utils.h
M components/autofill/core/browser/data_model/form_group.cc
M components/autofill/core/browser/data_model/identity_credential/identity_credential.cc
M components/autofill/core/browser/data_model/identity_credential/identity_credential.h
M components/autofill/core/browser/data_model/payments/autofill_offer_data.cc
M components/autofill/core/browser/data_model/payments/autofill_offer_data.h
M components/autofill/core/browser/data_model/payments/autofill_wallet_usage_data.cc
M components/autofill/core/browser/data_model/payments/autofill_wallet_usage_data.h
M components/autofill/core/browser/data_model/payments/bank_account.cc
M components/autofill/core/browser/data_model/payments/bank_account.h
M components/autofill/core/browser/data_model/payments/bnpl_issuer.cc
M components/autofill/core/browser/data_model/payments/bnpl_issuer.h
M components/autofill/core/browser/data_model/payments/credit_card.cc
M components/autofill/core/browser/data_model/payments/credit_card.h
M components/autofill/core/browser/data_model/payments/credit_card_benefit.cc
M components/autofill/core/browser/data_model/payments/credit_card_cloud_token_data.cc
M components/autofill/core/browser/data_model/payments/ewallet.cc
M components/autofill/core/browser/data_model/payments/ewallet.h
M components/autofill/core/browser/data_model/payments/iban.cc
M components/autofill/core/browser/data_model/payments/iban.h
M components/autofill/core/browser/data_model/payments/payment_instrument.cc
M components/autofill/core/browser/data_model/payments/payment_instrument.h
M components/autofill/core/browser/data_model/payments/payments_metadata.h
M components/autofill/core/browser/data_model/transliterator.cc
M components/autofill/core/browser/data_model/transliterator.h
M components/autofill/core/browser/data_model/usage_history_information.cc
M components/autofill/core/browser/data_model/valuables/loyalty_card.cc
M components/autofill/core/browser/data_model/valuables/loyalty_card.h
M components/autofill/core/browser/data_model/valuables/valuable_types.cc
M components/autofill/core/browser/data_quality/addresses/address_normalization_manager.cc
M components/autofill/core/browser/data_quality/addresses/address_normalization_manager_unittest.cc
M components/autofill/core/browser/data_quality/addresses/address_normalizer_impl.cc
M components/autofill/core/browser/data_quality/addresses/address_normalizer_impl.h
M components/autofill/core/browser/data_quality/addresses/address_normalizer_impl_unittest.cc
M components/autofill/core/browser/data_quality/addresses/profile_requirement_utils.cc
M components/autofill/core/browser/data_quality/addresses/profile_requirement_utils.h
M components/autofill/core/browser/data_quality/addresses/profile_token_quality.cc
M components/autofill/core/browser/data_quality/addresses/profile_token_quality.h
M components/autofill/core/browser/data_quality/addresses/profile_token_quality_unittest.cc
M components/autofill/core/browser/data_quality/addresses/test_address_normalizer.h
M components/autofill/core/browser/data_quality/autofill_data_util.cc
M components/autofill/core/browser/data_quality/autofill_data_util.h
M components/autofill/core/browser/data_quality/validation.cc
M components/autofill/core/browser/data_quality/validation.h
M components/autofill/core/browser/field_type_utils.cc
M components/autofill/core/browser/field_type_utils.h
M components/autofill/core/browser/field_types.cc
M components/autofill/core/browser/field_types.h
M components/autofill/core/browser/filling/addresses/field_filling_address_util.cc
M components/autofill/core/browser/filling/addresses/field_filling_address_util.h
M components/autofill/core/browser/filling/addresses/field_filling_address_util_unittest.cc
M components/autofill/core/browser/filling/autofill_ai/autofill_ai_access_manager.cc
M components/autofill/core/browser/filling/autofill_ai/autofill_ai_access_manager.h
M components/autofill/core/browser/filling/autofill_ai/field_filling_entity_util.cc
M components/autofill/core/browser/filling/autofill_ai/field_filling_entity_util.h
M components/autofill/core/browser/filling/autofill_ai/select_date_matching.cc
M components/autofill/core/browser/filling/autofill_ai/select_date_matching.h
M components/autofill/core/browser/filling/field_filling_util.cc
M components/autofill/core/browser/filling/field_filling_util.h
M components/autofill/core/browser/filling/filling_product.cc
M components/autofill/core/browser/filling/filling_product.h
M components/autofill/core/browser/filling/form_autofill_history.cc
M components/autofill/core/browser/filling/form_autofill_history.h
M components/autofill/core/browser/filling/form_filler.cc
M components/autofill/core/browser/filling/form_filler.h
M components/autofill/core/browser/filling/form_filler_unittest.cc
M components/autofill/core/browser/filling/payments/field_filling_payments_util.cc
M components/autofill/core/browser/filling/payments/field_filling_payments_util.h
M components/autofill/core/browser/form_import/addresses/address_form_data_importer.cc
M components/autofill/core/browser/form_import/addresses/address_form_data_importer.h
M components/autofill/core/browser/form_import/addresses/address_form_data_importer_unittest.cc
M components/autofill/core/browser/form_import/addresses/address_profile_save_manager.cc
M components/autofill/core/browser/form_import/addresses/address_profile_save_manager.h
M components/autofill/core/browser/form_import/addresses/address_profile_save_manager_unittest.cc
M components/autofill/core/browser/form_import/addresses/autofill_profile_import_process.cc
M components/autofill/core/browser/form_import/addresses/autofill_profile_import_process.h
M components/autofill/core/browser/form_import/addresses/autofill_save_update_address_profile_delegate_ios.h
M components/autofill/core/browser/form_import/form_data_importer.cc
M components/autofill/core/browser/form_import/form_data_importer.h
M components/autofill/core/browser/form_import/form_data_importer_utils.cc
M components/autofill/core/browser/form_import/form_data_importer_utils.h
M components/autofill/core/browser/form_import/payments/payments_form_data_importer.cc
M components/autofill/core/browser/form_import/payments/payments_form_data_importer.h
M components/autofill/core/browser/form_parsing/address_field_parser.cc
M components/autofill/core/browser/form_parsing/address_field_parser.h
M components/autofill/core/browser/form_parsing/address_field_parser_ng.cc
M components/autofill/core/browser/form_parsing/address_field_parser_ng.h
M components/autofill/core/browser/form_parsing/alternative_name_field_parser.cc
M components/autofill/core/browser/form_parsing/alternative_name_field_parser.h
M components/autofill/core/browser/form_parsing/autofill_parsing_utils.cc
M components/autofill/core/browser/form_parsing/autofill_parsing_utils.h
M components/autofill/core/browser/form_parsing/autofill_scanner.cc
M components/autofill/core/browser/form_parsing/credit_card_field_parser.cc
M components/autofill/core/browser/form_parsing/credit_card_field_parser.h
M components/autofill/core/browser/form_parsing/determine_regex_types.cc
M components/autofill/core/browser/form_parsing/determine_regex_types.h
M components/autofill/core/browser/form_parsing/email_field_parser.cc
M components/autofill/core/browser/form_parsing/email_field_parser.h
M components/autofill/core/browser/form_parsing/field_candidates.cc
M components/autofill/core/browser/form_parsing/form_field_parser.cc
M components/autofill/core/browser/form_parsing/form_field_parser.h
M components/autofill/core/browser/form_parsing/iban_field_parser.cc
M components/autofill/core/browser/form_parsing/iban_field_parser.h
M components/autofill/core/browser/form_parsing/loyalty_field_parser.cc
M components/autofill/core/browser/form_parsing/loyalty_field_parser.h
M components/autofill/core/browser/form_parsing/merchant_promo_code_field_parser.cc
M components/autofill/core/browser/form_parsing/merchant_promo_code_field_parser.h
M components/autofill/core/browser/form_parsing/name_field_parser.cc
M components/autofill/core/browser/form_parsing/name_field_parser.h
M components/autofill/core/browser/form_parsing/one_time_code_field_parser.cc
M components/autofill/core/browser/form_parsing/one_time_code_field_parser.h
M components/autofill/core/browser/form_parsing/phone_field_parser.cc
M components/autofill/core/browser/form_parsing/phone_field_parser.h
M components/autofill/core/browser/form_parsing/price_field_parser.cc
M components/autofill/core/browser/form_parsing/price_field_parser.h
M components/autofill/core/browser/form_parsing/regex_patterns.cc
M components/autofill/core/browser/form_parsing/regex_patterns.h
M components/autofill/core/browser/form_parsing/search_field_parser.cc
M components/autofill/core/browser/form_parsing/search_field_parser.h
M components/autofill/core/browser/form_parsing/standalone_cvc_field_parser.cc
M components/autofill/core/browser/form_parsing/standalone_cvc_field_parser.h
M components/autofill/core/browser/form_parsing/travel_field_parser.cc
M components/autofill/core/browser/form_parsing/travel_field_parser.h
M components/autofill/core/browser/form_predictions_tracker.cc
M components/autofill/core/browser/form_predictions_tracker.h
M components/autofill/core/browser/form_processing/autofill_ai/determine_attribute_types.cc
M components/autofill/core/browser/form_processing/autofill_ai/determine_attribute_types.h
M components/autofill/core/browser/form_processing/name_processing_util.cc
M components/autofill/core/browser/form_processing/name_processing_util.h
M components/autofill/core/browser/form_processing/optimization_guide_proto_util.cc
M components/autofill/core/browser/form_processing/optimization_guide_proto_util.h
M components/autofill/core/browser/form_qualifiers.cc
M components/autofill/core/browser/form_structure.cc
M components/autofill/core/browser/form_structure.h
M components/autofill/core/browser/form_structure_rationalization_engine.cc
M components/autofill/core/browser/form_structure_rationalization_engine.h
M components/autofill/core/browser/form_structure_rationalizer.cc
M components/autofill/core/browser/form_structure_rationalizer.h
M components/autofill/core/browser/form_structure_sectioning_util.cc
M components/autofill/core/browser/form_types.cc
M components/autofill/core/browser/form_types.h
M components/autofill/core/browser/foundations/autofill_client.cc
M components/autofill/core/browser/foundations/autofill_client.h
M components/autofill/core/browser/foundations/autofill_driver.cc
M components/autofill/core/browser/foundations/autofill_driver.h
M components/autofill/core/browser/foundations/autofill_driver_factory.h
M components/autofill/core/browser/foundations/autofill_driver_router.cc
M components/autofill/core/browser/foundations/autofill_driver_router.h
M components/autofill/core/browser/foundations/autofill_manager.cc
M components/autofill/core/browser/foundations/autofill_manager.h
M components/autofill/core/browser/foundations/browser_autofill_manager.cc
M components/autofill/core/browser/foundations/browser_autofill_manager.h
M components/autofill/core/browser/foundations/browser_autofill_manager_unittest.cc
M components/autofill/core/browser/foundations/form_forest.cc
M components/autofill/core/browser/foundations/form_forest.h
M components/autofill/core/browser/foundations/form_forest_util_inl.h
M components/autofill/core/browser/foundations/scoped_autofill_managers_observation.h
M components/autofill/core/browser/foundations/scoped_credit_card_access_managers_observation.cc
M components/autofill/core/browser/foundations/scoped_credit_card_access_managers_observation.h
M components/autofill/core/browser/geo/address_i18n.cc
M components/autofill/core/browser/geo/address_i18n.h
M components/autofill/core/browser/geo/address_i18n_unittest.cc
M components/autofill/core/browser/geo/address_rewriter.cc
M components/autofill/core/browser/geo/address_rewriter.h
M components/autofill/core/browser/geo/alternative_state_name_map.cc
M components/autofill/core/browser/geo/alternative_state_name_map.h
M components/autofill/core/browser/geo/alternative_state_name_map_constants.h
M components/autofill/core/browser/geo/alternative_state_name_map_updater.cc
M components/autofill/core/browser/geo/alternative_state_name_map_updater.h
M components/autofill/core/browser/geo/autofill_country.cc
M components/autofill/core/browser/geo/autofill_country.h
M components/autofill/core/browser/geo/country_data.cc
M components/autofill/core/browser/geo/country_data.h
M components/autofill/core/browser/geo/country_names.cc
M components/autofill/core/browser/geo/country_names.h
M components/autofill/core/browser/geo/country_names_for_locale.cc
M components/autofill/core/browser/geo/country_names_for_locale.h
M components/autofill/core/browser/geo/generate_country_native_names.cc
M components/autofill/core/browser/geo/phone_number_i18n.cc
M components/autofill/core/browser/geo/phone_number_i18n.h
M components/autofill/core/browser/geo/region_data_loader.h
M components/autofill/core/browser/geo/region_data_loader_impl.cc
M components/autofill/core/browser/geo/region_data_loader_impl.h
M components/autofill/core/browser/geo/state_names.cc
M components/autofill/core/browser/geo/subkey_requester.cc
M components/autofill/core/browser/heuristic_source.cc
M components/autofill/core/browser/heuristic_source.h
M components/autofill/core/browser/integrators/actor/actor_form_filling_types.cc
M components/autofill/core/browser/integrators/address_on_typing/address_on_typing_manager.cc
M components/autofill/core/browser/integrators/address_on_typing/address_on_typing_manager.h
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_import_utils.cc
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_import_utils.h
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_labels.cc
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_labels.h
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_manager.cc
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_manager.h
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_wallet_utils.cc
M components/autofill/core/browser/integrators/autofill_ai/autofill_ai_wallet_utils.h
M components/autofill/core/browser/integrators/autofill_ai/management_utils.cc
M components/autofill/core/browser/integrators/autofill_ai/management_utils.h
M components/autofill/core/browser/integrators/autofill_ai/metrics/autofill_ai_logger.cc
M components/autofill/core/browser/integrators/autofill_ai/metrics/autofill_ai_logger.h
M components/autofill/core/browser/integrators/autofill_ai/metrics/autofill_ai_metrics.cc
M components/autofill/core/browser/integrators/autofill_ai/metrics/autofill_ai_metrics.h
M components/autofill/core/browser/integrators/autofill_ai/metrics/autofill_ai_ukm_logger.cc
M components/autofill/core/browser/integrators/autofill_ai/metrics/autofill_ai_ukm_logger.h
M components/autofill/core/browser/integrators/compose/autofill_compose_delegate.h
M components/autofill/core/browser/integrators/identity_credential/identity_credential_delegate.h
M components/autofill/core/browser/integrators/one_time_tokens/metrics/otp_form_event_logger.cc
M components/autofill/core/browser/integrators/one_time_tokens/metrics/otp_form_event_logger.h
M components/autofill/core/browser/integrators/one_time_tokens/otp_field_detector.cc
M components/autofill/core/browser/integrators/one_time_tokens/otp_field_detector.h
M components/autofill/core/browser/integrators/one_time_tokens/otp_manager.h
M components/autofill/core/browser/integrators/one_time_tokens/otp_manager_impl.cc
M components/autofill/core/browser/integrators/one_time_tokens/otp_manager_impl.h
M components/autofill/core/browser/integrators/one_time_tokens/otp_suggestion.cc
M components/autofill/core/browser/integrators/optimization_guide/autofill_optimization_guide_decider.cc
M components/autofill/core/browser/integrators/optimization_guide/autofill_optimization_guide_decider.h
M components/autofill/core/browser/integrators/password_manager/password_manager_autofill_helper.cc
M components/autofill/core/browser/integrators/password_manager/password_manager_autofill_helper.h
M components/autofill/core/browser/integrators/password_manager/password_manager_delegate.h
M components/autofill/core/browser/integrators/touch_to_fill/touch_to_fill_delegate.h
M components/autofill/core/browser/logging/log_buffer_submitter.cc
M components/autofill/core/browser/logging/log_manager.cc
M components/autofill/core/browser/logging/log_manager.h
M components/autofill/core/browser/logging/log_router.cc
M components/autofill/core/browser/logging/log_router.h
M components/autofill/core/browser/logging/stub_log_manager.cc
M components/autofill/core/browser/logging/stub_log_manager.h
M components/autofill/core/browser/logging/text_log_receiver.cc
M components/autofill/core/browser/logging/text_log_receiver.h
M components/autofill/core/browser/manual_testing_import_unittest.cc
M components/autofill/core/browser/metrics/address_data_cleaner_metrics.cc
M components/autofill/core/browser/metrics/address_data_cleaner_metrics.h
M components/autofill/core/browser/metrics/autofill_in_devtools_metrics.cc
M components/autofill/core/browser/metrics/autofill_in_devtools_metrics.h
M components/autofill/core/browser/metrics/autofill_metrics.cc
M components/autofill/core/browser/metrics/autofill_metrics.h
M components/autofill/core/browser/metrics/autofill_metrics_test_base.cc
M components/autofill/core/browser/metrics/autofill_metrics_unittest.cc
M components/autofill/core/browser/metrics/autofill_metrics_utils.cc
M components/autofill/core/browser/metrics/autofill_metrics_utils.h
M components/autofill/core/browser/metrics/autofill_settings_metrics.cc
M components/autofill/core/browser/metrics/autofill_settings_metrics.h
M components/autofill/core/browser/metrics/field_filling_stats_and_score_metrics.cc
M components/autofill/core/browser/metrics/field_filling_stats_and_score_metrics.h
M components/autofill/core/browser/metrics/form_events/address_form_event_logger.cc
M components/autofill/core/browser/metrics/form_events/address_form_event_logger.h
M components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.cc
M components/autofill/core/browser/metrics/form_events/credit_card_form_event_logger.h
M components/autofill/core/browser/metrics/form_events/form_event_logger_base.cc
M components/autofill/core/browser/metrics/form_events/form_event_logger_base.h
M components/autofill/core/browser/metrics/form_events/loyalty_card_form_event_logger.cc
M components/autofill/core/browser/metrics/form_events/loyalty_card_form_event_logger.h
M components/autofill/core/browser/metrics/form_interactions_ukm_logger.cc
M components/autofill/core/browser/metrics/form_interactions_ukm_logger.h
M components/autofill/core/browser/metrics/log_event.h
M components/autofill/core/browser/metrics/payments/ai_amount_extraction_metrics.cc
M components/autofill/core/browser/metrics/payments/ai_amount_extraction_metrics.h
M components/autofill/core/browser/metrics/payments/amount_extraction_metrics.cc
M components/autofill/core/browser/metrics/payments/amount_extraction_metrics.h
M components/autofill/core/browser/metrics/payments/better_auth_metrics.cc
M components/autofill/core/browser/metrics/payments/better_auth_metrics.h
M components/autofill/core/browser/metrics/payments/bnpl_metrics.cc
M components/autofill/core/browser/metrics/payments/bnpl_metrics.h
M components/autofill/core/browser/metrics/payments/card_info_retrieval_enrolled_metrics.cc
M components/autofill/core/browser/metrics/payments/card_metadata_metrics.cc
M components/autofill/core/browser/metrics/payments/card_metadata_metrics.h
M components/autofill/core/browser/metrics/payments/card_unmask_authentication_metrics.cc
M components/autofill/core/browser/metrics/payments/card_unmask_authentication_metrics.h
M components/autofill/core/browser/metrics/payments/card_unmask_flow_metrics.cc
M components/autofill/core/browser/metrics/payments/credit_card_save_metrics.cc
M components/autofill/core/browser/metrics/payments/credit_card_save_metrics.h
M components/autofill/core/browser/metrics/payments/credit_card_save_metrics_android.cc
M components/autofill/core/browser/metrics/payments/credit_card_save_metrics_desktop.cc
M components/autofill/core/browser/metrics/payments/credit_card_save_metrics_desktop.h
M components/autofill/core/browser/metrics/payments/cvc_storage_metrics.h
M components/autofill/core/browser/metrics/payments/iban_metrics.cc
M components/autofill/core/browser/metrics/payments/iban_metrics.h
M components/autofill/core/browser/metrics/payments/mandatory_reauth_metrics.cc
M components/autofill/core/browser/metrics/payments/mandatory_reauth_metrics.h
M components/autofill/core/browser/metrics/payments/payments_window_metrics.cc
M components/autofill/core/browser/metrics/payments/risk_data_metrics.cc
M components/autofill/core/browser/metrics/payments/risk_data_metrics.h
M components/autofill/core/browser/metrics/payments/save_and_fill_metrics.cc
M components/autofill/core/browser/metrics/payments/save_and_fill_metrics.h
M components/autofill/core/browser/metrics/payments/virtual_card_enrollment_metrics.cc
M components/autofill/core/browser/metrics/payments/virtual_card_enrollment_metrics.h
M components/autofill/core/browser/metrics/payments/virtual_card_standalone_cvc_suggestion_metrics.cc
M components/autofill/core/browser/metrics/payments/virtual_card_standalone_cvc_suggestion_metrics.h
M components/autofill/core/browser/metrics/payments/wallet_usage_data_metrics.cc
M components/autofill/core/browser/metrics/payments/wallet_usage_data_metrics.h
M components/autofill/core/browser/metrics/per_fill_metrics.cc
M components/autofill/core/browser/metrics/per_fill_metrics.h
M components/autofill/core/browser/metrics/prediction_quality_metrics.cc
M components/autofill/core/browser/metrics/profile_import_metrics.cc
M components/autofill/core/browser/metrics/profile_import_metrics.h
M components/autofill/core/browser/metrics/profile_token_quality_metrics.cc
M components/autofill/core/browser/metrics/quality_metrics.cc
M components/autofill/core/browser/metrics/quality_metrics.h
M components/autofill/core/browser/metrics/quality_metrics_filling.cc
M components/autofill/core/browser/metrics/quality_metrics_filling.h
M components/autofill/core/browser/metrics/stored_profile_metrics.cc
M components/autofill/core/browser/metrics/stored_profile_metrics.h
M components/autofill/core/browser/metrics/suggestions_list_metrics.cc
M components/autofill/core/browser/metrics/suggestions_list_metrics.h
M components/autofill/core/browser/ml_model/autofill_ai/autofill_ai_model_cache.cc
M components/autofill/core/browser/ml_model/autofill_ai/autofill_ai_model_cache.h
M components/autofill/core/browser/ml_model/autofill_ai/autofill_ai_model_cache_impl.cc
M components/autofill/core/browser/ml_model/autofill_ai/autofill_ai_model_cache_impl.h
M components/autofill/core/browser/ml_model/autofill_ai/autofill_ai_model_executor_impl.cc
M components/autofill/core/browser/ml_model/autofill_ai/autofill_ai_model_executor_impl.h
M components/autofill/core/browser/ml_model/field_classification_model_encoder.cc
M components/autofill/core/browser/ml_model/field_classification_model_encoder.h
M components/autofill/core/browser/ml_model/field_classification_model_executor.cc
M components/autofill/core/browser/ml_model/field_classification_model_executor.h
M components/autofill/core/browser/ml_model/field_classification_model_handler.cc
M components/autofill/core/browser/ml_model/field_classification_model_handler.h
M components/autofill/core/browser/ml_model/logging/ml_log_router.h
M components/autofill/core/browser/ml_model/model_predictions.cc
M components/autofill/core/browser/ml_model/model_predictions.h
M components/autofill/core/browser/network/autofill_ai/private_pass_conversion_util.cc
M components/autofill/core/browser/network/autofill_ai/wallet_pass_access_manager.h
M components/autofill/core/browser/network/autofill_ai/wallet_pass_access_manager_impl.cc
M components/autofill/core/browser/network/autofill_ai/wallet_pass_access_manager_impl.h
M components/autofill/core/browser/payments/amount_extraction_heuristic_regexes.cc
M components/autofill/core/browser/payments/amount_extraction_heuristic_regexes.h
M components/autofill/core/browser/payments/amount_extraction_manager.cc
M components/autofill/core/browser/payments/amount_extraction_manager.h
M components/autofill/core/browser/payments/android_bnpl_strategy.cc
M components/autofill/core/browser/payments/android_bnpl_strategy.h
M components/autofill/core/browser/payments/autofill_offer_manager.cc
M components/autofill/core/browser/payments/autofill_offer_manager.h
M components/autofill/core/browser/payments/autofill_payments_feature_availability.cc
M components/autofill/core/browser/payments/autofill_save_card_delegate.cc
M components/autofill/core/browser/payments/autofill_save_card_delegate.h
M components/autofill/core/browser/payments/autofill_save_card_infobar_delegate_mobile.cc
M components/autofill/core/browser/payments/autofill_save_card_infobar_delegate_mobile.h
M components/autofill/core/browser/payments/autofill_save_card_ui_info.h
M components/autofill/core/browser/payments/autofill_virtual_card_enrollment_bottom_sheet_delegate_mobile.cc
M components/autofill/core/browser/payments/autofill_virtual_card_enrollment_bottom_sheet_delegate_mobile.h
M components/autofill/core/browser/payments/autofill_wallet_data_type_controller.cc
M components/autofill/core/browser/payments/autofill_wallet_data_type_controller.h
M components/autofill/core/browser/payments/bnpl_manager.cc
M components/autofill/core/browser/payments/bnpl_manager.h
M components/autofill/core/browser/payments/bnpl_strategy.cc
M components/autofill/core/browser/payments/bnpl_util.cc
M components/autofill/core/browser/payments/bnpl_util.h
M components/autofill/core/browser/payments/card_unmask_challenge_option.cc
M components/autofill/core/browser/payments/card_unmask_challenge_option.h
M components/autofill/core/browser/payments/constants.h
M components/autofill/core/browser/payments/credit_card_access_manager.cc
M components/autofill/core/browser/payments/credit_card_access_manager.h
M components/autofill/core/browser/payments/credit_card_cvc_authenticator.cc
M components/autofill/core/browser/payments/credit_card_cvc_authenticator.h
M components/autofill/core/browser/payments/credit_card_fido_authenticator.cc
M components/autofill/core/browser/payments/credit_card_fido_authenticator.h
M components/autofill/core/browser/payments/credit_card_otp_authenticator.cc
M components/autofill/core/browser/payments/credit_card_otp_authenticator.h
M components/autofill/core/browser/payments/credit_card_risk_based_authenticator.cc
M components/autofill/core/browser/payments/credit_card_risk_based_authenticator.h
M components/autofill/core/browser/payments/credit_card_save_manager.cc
M components/autofill/core/browser/payments/credit_card_save_manager.h
M components/autofill/core/browser/payments/desktop_bnpl_strategy.cc
M components/autofill/core/browser/payments/desktop_bnpl_strategy.h
M components/autofill/core/browser/payments/full_card_request.cc
M components/autofill/core/browser/payments/full_card_request.h
M components/autofill/core/browser/payments/iban_access_manager.cc
M components/autofill/core/browser/payments/iban_access_manager.h
M components/autofill/core/browser/payments/iban_manager.cc
M components/autofill/core/browser/payments/iban_manager.h
M components/autofill/core/browser/payments/iban_manager_unittest.cc
M components/autofill/core/browser/payments/iban_save_manager.cc
M components/autofill/core/browser/payments/iban_save_manager.h
M components/autofill/core/browser/payments/iban_save_manager_unittest.cc
M components/autofill/core/browser/payments/legal_message_line.cc
M components/autofill/core/browser/payments/legal_message_line.h
M components/autofill/core/browser/payments/mandatory_reauth_manager.cc
M components/autofill/core/browser/payments/mandatory_reauth_manager.h
M components/autofill/core/browser/payments/multiple_request_payments_network_interface.cc
M components/autofill/core/browser/payments/multiple_request_payments_network_interface.h
M components/autofill/core/browser/payments/multiple_request_payments_network_interface_base.cc
M components/autofill/core/browser/payments/offer_notification_handler.cc
M components/autofill/core/browser/payments/offer_notification_handler.h
M components/autofill/core/browser/payments/payments_access_token_fetcher.cc
M components/autofill/core/browser/payments/payments_autofill_client.cc
M components/autofill/core/browser/payments/payments_autofill_client.h
M components/autofill/core/browser/payments/payments_data_cleaner.cc
M components/autofill/core/browser/payments/payments_network_interface.cc
M components/autofill/core/browser/payments/payments_network_interface.h
M components/autofill/core/browser/payments/payments_network_interface_base.cc
M components/autofill/core/browser/payments/payments_network_interface_base.h
M components/autofill/core/browser/payments/payments_request_details.h
M components/autofill/core/browser/payments/payments_requests/create_bnpl_payment_instrument_request.cc
M components/autofill/core/browser/payments/payments_requests/create_card_request.cc
M components/autofill/core/browser/payments/payments_requests/create_card_request.h
M components/autofill/core/browser/payments/payments_requests/get_bnpl_payment_instrument_for_fetching_url_request.cc
M components/autofill/core/browser/payments/payments_requests/get_bnpl_payment_instrument_for_fetching_url_request.h
M components/autofill/core/browser/payments/payments_requests/get_bnpl_payment_instrument_for_fetching_vcn_request.cc
M components/autofill/core/browser/payments/payments_requests/get_bnpl_payment_instrument_for_fetching_vcn_request.h
M components/autofill/core/browser/payments/payments_requests/get_card_upload_details_request.cc
M components/autofill/core/browser/payments/payments_requests/get_card_upload_details_request.h
M components/autofill/core/browser/payments/payments_requests/get_details_for_create_bnpl_payment_instrument_request.cc
M components/autofill/core/browser/payments/payments_requests/get_details_for_create_card_request.cc
M components/autofill/core/browser/payments/payments_requests/get_details_for_create_card_request.h
M components/autofill/core/browser/payments/payments_requests/get_details_for_enrollment_request.cc
M components/autofill/core/browser/payments/payments_requests/get_details_for_enrollment_request.h
M components/autofill/core/browser/payments/payments_requests/get_details_for_update_bnpl_payment_instrument_request.cc
M components/autofill/core/browser/payments/payments_requests/get_iban_upload_details_request.cc
M components/autofill/core/browser/payments/payments_requests/get_iban_upload_details_request.h
M components/autofill/core/browser/payments/payments_requests/get_unmask_details_request.cc
M components/autofill/core/browser/payments/payments_requests/opt_change_request.cc
M components/autofill/core/browser/payments/payments_requests/payments_request.cc
M components/autofill/core/browser/payments/payments_requests/payments_request.h
M components/autofill/core/browser/payments/payments_requests/select_challenge_option_request.cc
M components/autofill/core/browser/payments/payments_requests/select_challenge_option_request.h
M components/autofill/core/browser/payments/payments_requests/unmask_card_request.cc
M components/autofill/core/browser/payments/payments_requests/unmask_card_request.h
M components/autofill/core/browser/payments/payments_requests/unmask_iban_request.cc
M components/autofill/core/browser/payments/payments_requests/update_bnpl_payment_instrument_request.cc
M components/autofill/core/browser/payments/payments_requests/update_virtual_card_enrollment_request.cc
M components/autofill/core/browser/payments/payments_requests/update_virtual_card_enrollment_request.h
M components/autofill/core/browser/payments/payments_requests/upload_card_request.cc
M components/autofill/core/browser/payments/payments_requests/upload_card_request.h
M components/autofill/core/browser/payments/payments_requests/upload_iban_request.cc
M components/autofill/core/browser/payments/payments_requests/upload_iban_request.h
M components/autofill/core/browser/payments/payments_requests/upload_iban_request_unittest.cc
M components/autofill/core/browser/payments/payments_service_url.cc
M components/autofill/core/browser/payments/payments_service_url.h
M components/autofill/core/browser/payments/payments_util.cc
M components/autofill/core/browser/payments/payments_window_manager.h
M components/autofill/core/browser/payments/payments_window_manager_util.cc
M components/autofill/core/browser/payments/payments_window_manager_util.h
M components/autofill/core/browser/payments/save_and_fill_manager.h
M components/autofill/core/browser/payments/save_and_fill_manager_impl.cc
M components/autofill/core/browser/payments/save_and_fill_manager_impl.h
M components/autofill/core/browser/payments/virtual_card_enroll_metrics_logger.cc
M components/autofill/core/browser/payments/virtual_card_enroll_metrics_logger.h
M components/autofill/core/browser/payments/virtual_card_enrollment_manager.cc
M components/autofill/core/browser/payments/virtual_card_enrollment_manager.h
M components/autofill/core/browser/payments/wait_for_signal_or_timeout.cc
M components/autofill/core/browser/permissions/autofill_ai/autofill_ai_permission_utils.cc
M components/autofill/core/browser/permissions/autofill_ai/autofill_ai_permission_utils.h
M components/autofill/core/browser/permissions/autofill_policy_handler.cc
M components/autofill/core/browser/permissions/autofill_policy_handler.h
M components/autofill/core/browser/single_field_fillers/autocomplete/autocomplete_history_manager.cc
M components/autofill/core/browser/single_field_fillers/autocomplete/autocomplete_history_manager.h
M components/autofill/core/browser/single_field_fillers/payments/merchant_promo_code_manager.cc
M components/autofill/core/browser/single_field_fillers/payments/merchant_promo_code_manager.h
M components/autofill/core/browser/single_field_fillers/single_field_fill_router.cc
M components/autofill/core/browser/single_field_fillers/single_field_fill_router.h
M components/autofill/core/browser/strike_databases/addresses/address_on_typing_suggestion_strike_database.h
M components/autofill/core/browser/strike_databases/addresses/address_suggestion_strike_database.cc
M components/autofill/core/browser/strike_databases/addresses/address_suggestion_strike_database.h
M components/autofill/core/browser/strike_databases/addresses/autofill_on_typing_suggestion_strike_database.h
M components/autofill/core/browser/strike_databases/addresses/autofill_profile_migration_strike_database.h
M components/autofill/core/browser/strike_databases/addresses/autofill_profile_save_strike_database.h
M components/autofill/core/browser/strike_databases/addresses/autofill_profile_update_strike_database.h
M components/autofill/core/browser/strike_databases/autofill_ai/autofill_ai_save_strike_database_by_attribute.h
M components/autofill/core/browser/strike_databases/autofill_ai/autofill_ai_save_strike_database_by_host.cc
M components/autofill/core/browser/strike_databases/autofill_ai/autofill_ai_save_strike_database_by_host.h
M components/autofill/core/browser/strike_databases/autofill_ai/autofill_ai_update_strike_database.h
M components/autofill/core/browser/strike_databases/payments/credit_card_save_strike_database.cc
M components/autofill/core/browser/strike_databases/payments/credit_card_save_strike_database.h
M components/autofill/core/browser/strike_databases/payments/cvc_storage_strike_database.cc
M components/autofill/core/browser/strike_databases/payments/fido_authentication_strike_database.h
M components/autofill/core/browser/strike_databases/payments/iban_save_strike_database.h
M components/autofill/core/browser/strike_databases/payments/save_and_fill_strike_database.cc
M components/autofill/core/browser/strike_databases/payments/save_and_fill_strike_database.h
M components/autofill/core/browser/strike_databases/payments/test_credit_card_save_strike_database.cc
M components/autofill/core/browser/strike_databases/payments/test_credit_card_save_strike_database.h
M components/autofill/core/browser/strike_databases/payments/virtual_card_enrollment_strike_database.cc
M components/autofill/core/browser/strike_databases/payments/virtual_card_enrollment_strike_database.h
M components/autofill/core/browser/studies/autofill_ablation_study.cc
M components/autofill/core/browser/studies/autofill_experiments.cc
M components/autofill/core/browser/suggestions/addresses/address_suggestion_generator.cc
M components/autofill/core/browser/suggestions/addresses/address_suggestion_generator.h
M components/autofill/core/browser/suggestions/addresses/address_suggestion_generator_unittest.cc
M components/autofill/core/browser/suggestions/at_memory/at_memory_nudge_generator.cc
M components/autofill/core/browser/suggestions/at_memory/at_memory_nudge_generator.h
M components/autofill/core/browser/suggestions/autocomplete_suggestion_generator.cc
M components/autofill/core/browser/suggestions/autocomplete_suggestion_generator.h
M components/autofill/core/browser/suggestions/autofill_ai/autofill_ai_suggestion_generator.cc
M components/autofill/core/browser/suggestions/autofill_ai/autofill_ai_suggestion_generator.h
M components/autofill/core/browser/suggestions/compose/compose_suggestion_generator.cc
M components/autofill/core/browser/suggestions/compose/compose_suggestion_generator.h
M components/autofill/core/browser/suggestions/identity_credential_suggestion_utils.cc
M components/autofill/core/browser/suggestions/identity_credential_suggestion_utils.h
M components/autofill/core/browser/suggestions/one_time_passwords/otp_suggestion_generator.cc
M components/autofill/core/browser/suggestions/one_time_passwords/otp_suggestion_generator.h
M components/autofill/core/browser/suggestions/passkeys/passkey_suggestion_generator.cc
M components/autofill/core/browser/suggestions/passkeys/passkey_suggestion_generator.h
M components/autofill/core/browser/suggestions/payments/credit_card_suggestion_generator.cc
M components/autofill/core/browser/suggestions/payments/credit_card_suggestion_generator.h
M components/autofill/core/browser/suggestions/payments/iban_suggestion_generator.cc
M components/autofill/core/browser/suggestions/payments/iban_suggestion_generator.h
M components/autofill/core/browser/suggestions/payments/merchant_promo_code_suggestion_generator.cc
M components/autofill/core/browser/suggestions/payments/merchant_promo_code_suggestion_generator.h
M components/autofill/core/browser/suggestions/payments/payments_suggestion_generator_util.cc
M components/autofill/core/browser/suggestions/payments/payments_suggestion_generator_util.h
M components/autofill/core/browser/suggestions/payments/virtual_card_suggestion_data.h
M components/autofill/core/browser/suggestions/suggestion.cc
M components/autofill/core/browser/suggestions/suggestion.h
M components/autofill/core/browser/suggestions/suggestion_generator.h
M components/autofill/core/browser/suggestions/suggestion_type.cc
M components/autofill/core/browser/suggestions/suggestion_type.h
M components/autofill/core/browser/suggestions/suggestion_util.cc
M components/autofill/core/browser/suggestions/suggestions_context.cc
M components/autofill/core/browser/suggestions/suggestions_context.h
M components/autofill/core/browser/suggestions/valuables/valuable_suggestion_generator.cc
M components/autofill/core/browser/suggestions/valuables/valuable_suggestion_generator.h
M components/autofill/core/browser/test_utils/autofill_test_utils.cc
M components/autofill/core/browser/test_utils/autofill_test_utils.h
M components/autofill/core/browser/ui/addresses/autofill_address_util.cc
M components/autofill/core/browser/ui/addresses/autofill_address_util.h
M components/autofill/core/browser/ui/addresses/autofill_address_util_unittest.cc
M components/autofill/core/browser/ui/autofill_external_delegate.cc
M components/autofill/core/browser/ui/autofill_external_delegate.h
M components/autofill/core/browser/ui/autofill_image_fetcher.cc
M components/autofill/core/browser/ui/autofill_image_fetcher.h
M components/autofill/core/browser/ui/autofill_image_fetcher_base.h
M components/autofill/core/browser/ui/autofill_resource_utils.cc
M components/autofill/core/browser/ui/autofill_suggestion_delegate.h
M components/autofill/core/browser/ui/country_combobox_model.cc
M components/autofill/core/browser/ui/country_combobox_model.h
M components/autofill/core/browser/ui/payments/autofill_error_dialog_controller_impl.cc
M components/autofill/core/browser/ui/payments/autofill_progress_dialog_controller.h
M components/autofill/core/browser/ui/payments/autofill_progress_dialog_controller_impl.cc
M components/autofill/core/browser/ui/payments/autofill_progress_dialog_controller_impl.h
M components/autofill/core/browser/ui/payments/autofill_progress_dialog_view.h
M components/autofill/core/browser/ui/payments/bnpl_tos_controller.h
M components/autofill/core/browser/ui/payments/bnpl_tos_controller_impl.cc
M components/autofill/core/browser/ui/payments/bnpl_tos_controller_impl.h
M components/autofill/core/browser/ui/payments/bnpl_ui_delegate.h
M components/autofill/core/browser/ui/payments/card_expiration_date_fix_flow_controller.h
M components/autofill/core/browser/ui/payments/card_expiration_date_fix_flow_controller_impl.h
M components/autofill/core/browser/ui/payments/card_name_fix_flow_controller_impl.cc
M components/autofill/core/browser/ui/payments/card_unmask_authentication_selection_dialog_controller_impl.cc
M components/autofill/core/browser/ui/payments/card_unmask_authentication_selection_dialog_controller_impl.h
M components/autofill/core/browser/ui/payments/card_unmask_otp_input_dialog_controller.h
M components/autofill/core/browser/ui/payments/card_unmask_otp_input_dialog_controller_impl.cc
M components/autofill/core/browser/ui/payments/card_unmask_otp_input_dialog_controller_impl.h
M components/autofill/core/browser/ui/payments/card_unmask_otp_input_dialog_view.h
M components/autofill/core/browser/ui/payments/card_unmask_prompt_controller_impl.cc
M components/autofill/core/browser/ui/payments/card_unmask_prompt_controller_impl.h
M components/autofill/core/browser/ui/payments/card_unmask_prompt_options.cc
M components/autofill/core/browser/ui/payments/card_unmask_prompt_options.h
M components/autofill/core/browser/ui/payments/omnibox_autofill_delegate.cc
M components/autofill/core/browser/ui/payments/payments_window_user_consent_dialog.h
M components/autofill/core/browser/ui/payments/payments_window_user_consent_dialog_controller_impl.cc
M components/autofill/core/browser/ui/payments/payments_window_user_consent_dialog_controller_impl.h
M components/autofill/core/browser/ui/payments/save_and_fill_dialog_controller.h
M components/autofill/core/browser/ui/payments/save_and_fill_dialog_controller_impl.cc
M components/autofill/core/browser/ui/payments/save_and_fill_dialog_controller_impl.h
M components/autofill/core/browser/ui/payments/save_payment_method_and_virtual_card_enroll_confirmation_ui_params.cc
M components/autofill/core/browser/ui/payments/select_bnpl_issuer_dialog_controller.h
M components/autofill/core/browser/ui/payments/select_bnpl_issuer_dialog_controller_impl.cc
M components/autofill/core/browser/ui/payments/select_bnpl_issuer_dialog_controller_impl.h
M components/autofill/core/browser/ui/payments/virtual_card_enroll_bubble_controller.h
M components/autofill/core/browser/ui/payments/virtual_card_enroll_ui_model.cc
M components/autofill/core/browser/ui/region_combobox_model.cc
M components/autofill/core/browser/ui/region_combobox_model.h
M components/autofill/core/browser/webdata/addresses/address_autofill_table.cc
M components/autofill/core/browser/webdata/addresses/address_autofill_table.h
M components/autofill/core/browser/webdata/addresses/address_autofill_table_unittest.cc
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_bridge.cc
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_bridge.h
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_bridge_unittest.cc
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_difference_tracker.cc
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_difference_tracker.h
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_difference_tracker_unittest.cc
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_util.cc
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_util.h
M components/autofill/core/browser/webdata/addresses/autofill_profile_sync_util_unittest.cc
M components/autofill/core/browser/webdata/addresses/contact_info_data_type_controller.cc
M components/autofill/core/browser/webdata/addresses/contact_info_data_type_controller.h
M components/autofill/core/browser/webdata/addresses/contact_info_local_data_batch_uploader.cc
M components/autofill/core/browser/webdata/addresses/contact_info_local_data_batch_uploader.h
M components/autofill/core/browser/webdata/addresses/contact_info_precondition_checker.cc
M components/autofill/core/browser/webdata/addresses/contact_info_precondition_checker.h
M components/autofill/core/browser/webdata/addresses/contact_info_sync_bridge.cc
M components/autofill/core/browser/webdata/addresses/contact_info_sync_bridge.h
M components/autofill/core/browser/webdata/addresses/contact_info_sync_bridge_unittest.cc
M components/autofill/core/browser/webdata/addresses/contact_info_sync_util.cc
M components/autofill/core/browser/webdata/addresses/contact_info_sync_util_unittest.cc
M components/autofill/core/browser/webdata/autocomplete/autocomplete_entry.cc
M components/autofill/core/browser/webdata/autocomplete/autocomplete_entry_label_sensitive.cc
M components/autofill/core/browser/webdata/autocomplete/autocomplete_entry_label_sensitive.h
M components/autofill/core/browser/webdata/autocomplete/autocomplete_sync_bridge.cc
M components/autofill/core/browser/webdata/autocomplete/autocomplete_sync_bridge.h
M components/autofill/core/browser/webdata/autocomplete/autocomplete_table.cc
M components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive.cc
M components/autofill/core/browser/webdata/autocomplete/autocomplete_table_label_sensitive.h
M components/autofill/core/browser/webdata/autofill_ai/entity_sync_util.cc
M components/autofill/core/browser/webdata/autofill_ai/entity_sync_util.h
M components/autofill/core/browser/webdata/autofill_ai/entity_table.cc
M components/autofill/core/browser/webdata/autofill_ai/entity_table.h
M components/autofill/core/browser/webdata/autofill_change.cc
M components/autofill/core/browser/webdata/autofill_change.h
M components/autofill/core/browser/webdata/autofill_sync_metadata_table.cc
M components/autofill/core/browser/webdata/autofill_sync_metadata_table.h
M components/autofill/core/browser/webdata/autofill_table_utils.cc
M components/autofill/core/browser/webdata/autofill_table_utils.h
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
M components/autofill/core/browser/webdata/autofill_webdata_service.cc
M components/autofill/core/browser/webdata/autofill_webdata_service.h
M components/autofill/core/browser/webdata/payments/autofill_wallet_credential_sync_bridge.cc
M components/autofill/core/browser/webdata/payments/autofill_wallet_credential_sync_bridge.h
M components/autofill/core/browser/webdata/payments/autofill_wallet_metadata_sync_bridge.cc
M components/autofill/core/browser/webdata/payments/autofill_wallet_metadata_sync_bridge.h
M components/autofill/core/browser/webdata/payments/autofill_wallet_offer_sync_bridge.cc
M components/autofill/core/browser/webdata/payments/autofill_wallet_offer_sync_bridge.h
M components/autofill/core/browser/webdata/payments/autofill_wallet_sync_bridge.cc
M components/autofill/core/browser/webdata/payments/autofill_wallet_sync_bridge.h
M components/autofill/core/browser/webdata/payments/autofill_wallet_usage_data_sync_bridge.cc
M components/autofill/core/browser/webdata/payments/autofill_wallet_usage_data_sync_bridge.h
M components/autofill/core/browser/webdata/payments/payments_autofill_table.cc
M components/autofill/core/browser/webdata/payments/payments_autofill_table.h
M components/autofill/core/browser/webdata/payments/payments_sync_bridge_util.cc
M components/autofill/core/browser/webdata/payments/payments_sync_bridge_util.h
M components/autofill/core/browser/webdata/payments/payments_sync_util.cc
M components/autofill/core/browser/webdata/payments/server_cvc.h
M components/autofill/core/browser/webdata/valuables/valuable_data_type_controller.cc
M components/autofill/core/browser/webdata/valuables/valuable_data_type_controller.h
M components/autofill/core/browser/webdata/valuables/valuable_metadata_sync_bridge.cc
M components/autofill/core/browser/webdata/valuables/valuable_metadata_sync_bridge.h
M components/autofill/core/browser/webdata/valuables/valuable_sync_bridge.cc
M components/autofill/core/browser/webdata/valuables/valuable_sync_bridge.h
M components/autofill/core/browser/webdata/valuables/valuables_sync_util.cc
M components/autofill/core/browser/webdata/valuables/valuables_sync_util.h
M components/autofill/core/browser/webdata/valuables/valuables_table.cc
M components/autofill/core/browser/webdata/valuables/valuables_table.h
M components/autofill/core/browser/webdata/web_data_service_unittest.cc
M components/password_manager/core/browser/origin_credential_store.cc
M components/password_manager/core/browser/password_store/interactions_stats.h
M components/password_manager/core/browser/sharing/password_receiver_service_impl.cc
M components/password_manager/core/browser/votes_uploader_unittest.cc
M ios/chrome/browser/autofill/model/autofill_controller_unittest.mm
M ios/chrome/browser/autofill/model/autofill_tab_helper.mm
M ios/chrome/browser/autofill/model/automation/automation_app_interface.mm
M ios/chrome/browser/autofill/model/form_structure_browsertest.mm

Change size: XL

Delta: 763 files changed, 4191 insertions(+), 1159 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mohamed Amir Yosef, +1 by Dominic Battré

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Christoph Schwering (Gerrit)

unread,

May 15, 2026, 3:53:06 AMMay 15

to Chromium LUCI CQ, Mohamed Amir Yosef, Dominic Battré, SLSA Policy Verification Service, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, (Julie)Jeongeun Kim, Peter Williamson, feature-me...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, tmartino+tran...@chromium.org, marq+...@chromium.org, abigailbk...@google.com, accessibility-a...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, dtseng...@chromium.org, dullweb...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, josiah...@chromium.org, jshin...@chromium.org, kyungjunle...@google.com, msrame...@chromium.org, nektar...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sloboda...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, yuzo+...@chromium.org

Christoph Schwering added 1 comment

File chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc

Line 130, Patchset 14: CHECK(interaction_stats_.username_value == stats->username_value);

Dominic Battré . resolved

Let's try to revert these afterwards. This is surprising to me. components/password_manager/core/browser/password_store/interactions_stats.h misses an `#include <string>`.

Christoph Schwering

I can give it another try afterwards.
components/password_manager/core/browser/password_store/interactions_stats.h misses an #include <string
I had added that include manually in my attempts to make the CHECK work, and didn't remove it to avoid another bot run.

Christoph Schwering

components/password_manager/core/browser/password_store/interactions_stats.h misses an #include <string
I had added that include manually in my attempts to make the CHECK work, and didn't remove it to avoid another bot run.
I responded too quickly. The include I was referring to is `#include <string>` in `chrome/browser/ui/passwords/bubble_controllers/save_update_bubble_controller.cc`, which isn't necessary.
`components/password_manager/core/browser/password_store/interactions_stats.h` actually contains and should contain an `#include <string>`.

Dominic Battré

https://source.chromium.org/chromium/chromium/src/+/main:components/password_manager/core/browser/password_store/interactions_stats.h;drc=a8f56567951a7413780be19fabb2bfc7a7426bf3 does not show me an `#include <string>`.

Christoph Schwering

That's right, but this CL adds it: https://chromium-review.git.corp.google.com/c/chromium/src/+/7849414/17/components/password_manager/core/browser/password_store/interactions_stats.h 😊

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Side Yilmaz (Gerrit)

unread,

May 15, 2026, 6:35:59 AMMay 15

Side Yilmaz has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages